smbXsrv_version: Use a struct assignment
authorVolker Lendecke <vl@samba.org>
Sat, 10 Feb 2024 09:40:46 +0000 (10:40 +0100)
committerVolker Lendecke <vl@samba.org>
Tue, 12 Mar 2024 13:31:31 +0000 (13:31 +0000)
Make sure everything is initialized

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/smbd/smbXsrv_version.c

index 2a54833ee6695a831ec3bd685ab043867866b3c4..538f70dd146eabd839853a1adcf029ae0c77043b 100644 (file)
@@ -209,10 +209,12 @@ NTSTATUS smbXsrv_version_global_init(const struct server_id *server_id)
                num_valid++;
        }
 
-       local_node->server_id = *server_id;
-       local_node->min_version = SMBXSRV_VERSION_0;
-       local_node->max_version = SMBXSRV_VERSION_CURRENT;
-       local_node->current_version = global_blob.version;
+       *local_node = (struct smbXsrv_version_node0){
+               .server_id = *server_id,
+               .min_version = SMBXSRV_VERSION_0,
+               .max_version = SMBXSRV_VERSION_CURRENT,
+               .current_version = global_blob.version,
+       };
 
        global->num_nodes = num_valid;
        global->nodes = valid;