Dissectors should not use dfilter.h, don't include it.

XXX ncp2222 dissector is using dfilter_compile(), why?

git-svn-id: http://anonsvn.wireshark.org/wireshark/trunk@53766 f5534014-38df-0310-8fa8-9805f1628bb7

diff --git a/color_filters.h b/color_filters.h
index 6e21a181a6a1f1b70a374e8c1b9a60843283c056..ef074d1ec13dd2ef049041ea40d6f5573ce7b32e 100644 (file)
--- a/color_filters.h
+++ b/color_filters.h
@@ -43,7 +43,7 @@ typedef struct _color_filter {
     gboolean   selected;            /* set if the filter is selected in the color dialog box */
 
                                     /* only used inside of color_filters.c */
-    dfilter_t *c_colorfilter;       /* compiled filter expression */
+    struct epan_dfilter *c_colorfilter;  /* compiled filter expression */
 
                                     /* only used outside of color_filters.c (beside init) */
     void      *color_edit_dlg_info; /* if filter is being edited, ptr to req'd info */

diff --git a/epan/column-utils.c b/epan/column-utils.c
index f5cbbc39b39ec4bb6740523289db6bb74c3d49f0..db4c485e6f0668f1a37c8ac4fb6cbea43f322b50 100644 (file)
--- a/epan/column-utils.c
+++ b/epan/column-utils.c
@@ -61,7 +61,7 @@ col_setup(column_info *cinfo, const gint num_cols)
   cinfo->col_custom_field      = g_new(gchar*, num_cols);
   cinfo->col_custom_occurrence = g_new(gint, num_cols);
   cinfo->col_custom_field_id   = g_new(int, num_cols);
-  cinfo->col_custom_dfilter    = g_new(dfilter_t*, num_cols);
+  cinfo->col_custom_dfilter    = g_new(struct epan_dfilter*, num_cols);
   cinfo->col_data              = g_new(const gchar*, num_cols);
   cinfo->col_buf               = g_new(gchar*, num_cols);
   cinfo->col_fence             = g_new(int, num_cols);

diff --git a/epan/dissectors/packet-ansi_a.h b/epan/dissectors/packet-ansi_a.h
index edb4d97db6924a0679bb0655cecb0a0d42a301e6..dde8c4004e3672b0e65662ab5b40ece1dc715ba6 100644 (file)
--- a/epan/dissectors/packet-ansi_a.h
+++ b/epan/dissectors/packet-ansi_a.h
@@ -24,6 +24,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include <epan/proto.h>
+
 typedef struct _ansi_a_tap_rec_t {
     /*
      * value from packet-bssap.h

diff --git a/epan/dissectors/packet-gsm_a_common.h b/epan/dissectors/packet-gsm_a_common.h
index 137105c72a44851a99eb1aa30c4f9d78cb30d436..b1b42f835e86707323d42d9fd23e2b4d7decfe6a 100644 (file)
--- a/epan/dissectors/packet-gsm_a_common.h
+++ b/epan/dissectors/packet-gsm_a_common.h
@@ -51,6 +51,8 @@
 #ifndef __PACKET_GSM_A_COMMON_H__
 #define __PACKET_GSM_A_COMMON_H__
 
+#include <epan/proto.h>
+
 #include "packet-sccp.h"
 #include "ws_symbol_export.h"
 

diff --git a/epan/dissectors/packet-ncp-int.h b/epan/dissectors/packet-ncp-int.h
index b7daacb15a273838ffc9f73b802809c215bd9dcc..2bdc09815d49b5dc683b1de640ce22d98e019508 100644 (file)
--- a/epan/dissectors/packet-ncp-int.h
+++ b/epan/dissectors/packet-ncp-int.h
@@ -78,7 +78,7 @@ struct _sub_ptvc_record {
 
 typedef struct {
        const char              *dfilter_text;
-       dfilter_t               *dfilter;
+       struct epan_dfilter     *dfilter;
 } conditional_record;
 
 typedef struct {

diff --git a/epan/dissectors/packet-radius.h b/epan/dissectors/packet-radius.h
index c85ace294cfc8641a63ce413bb8bcd5263ccf963..e6a5c7cf9fc7ae05f74103a0ece6d7f2c6836fad 100644 (file)
--- a/epan/dissectors/packet-radius.h
+++ b/epan/dissectors/packet-radius.h
@@ -23,6 +23,8 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
  */
 
+#include <epan/proto.h>
+
 /* radius packet-type codes */
 /* 09/12/2011: Updated from IANA:
  * http://www.iana.org/assignments/radius-types/radius-types.xml#radius-types-27

diff --git a/epan/dissectors/packet-smb.h b/epan/dissectors/packet-smb.h
index 73bcfe02a1cd5a31560228397aeb6d1b3d1494b9..45f9b3fe8047a19e0872947b30d23efe031925f9 100644 (file)
--- a/epan/dissectors/packet-smb.h
+++ b/epan/dissectors/packet-smb.h
@@ -28,6 +28,7 @@
 
 #include "ws_symbol_export.h"
 
+#include <epan/proto.h>
 #include <epan/wmem/wmem.h>
 
 WS_DLL_PUBLIC gboolean sid_name_snooping;

diff --git a/epan/dissectors/packet-wsp.h b/epan/dissectors/packet-wsp.h
index afafed666f47e69af07bc2917a91c0773ee59dc0..caf238c12db53a00790976e64c95aaf9cd29dbe4 100644 (file)
--- a/epan/dissectors/packet-wsp.h
+++ b/epan/dissectors/packet-wsp.h
@@ -30,6 +30,7 @@
 #ifndef __PACKET_WSP_H__
 #define __PACKET_WSP_H__
 
+#include <epan/proto.h>
 #include "ws_symbol_export.h"
 
 /* These reason codes are used in the WTP dissector as the WTP user is

diff --git a/epan/epan.c b/epan/epan.c
index 80a4648e736c7e4085c4d10d9519b15b0d304c13..e4d6be73ef1a16586921dfa4d029ed8a19f5abef 100644 (file)
--- a/epan/epan.c
+++ b/epan/epan.c
@@ -36,8 +36,10 @@
 #endif /* HAVE_LIBGNUTLS */
 
 #include <glib.h>
+
 #include "epan-int.h"
 #include "epan.h"
+#include "dfilter/dfilter.h"
 #include "epan_dissect.h"
 #include "wsutil/report_err.h"
 

diff --git a/epan/epan.h b/epan/epan.h
index 9347fb69f7cb32116543e7ef6c60468ef610f5c5..bae341d6e356231094c46a53ee6635e03333c2f4 100644 (file)
--- a/epan/epan.h
+++ b/epan/epan.h
@@ -36,7 +36,7 @@ extern "C" {
 
 typedef struct _epan_dissect_t epan_dissect_t;
 
-#include "dfilter/dfilter.h"
+struct epan_dfilter;
 
 /**
        @mainpage Wireshark EPAN the packet analyzing engine. Source code can be found in the epan directory
@@ -185,7 +185,7 @@ epan_dissect_run_with_taps(epan_dissect_t *edt, struct wtap_pkthdr *phdr,
 /** Prime a proto_tree using the fields/protocols used in a dfilter. */
 WS_DLL_PUBLIC
 void
-epan_dissect_prime_dfilter(epan_dissect_t *edt, const dfilter_t *dfcode);
+epan_dissect_prime_dfilter(epan_dissect_t *edt, const struct epan_dfilter *dfcode);
 
 /** fill the dissect run output into the packet list columns */
 WS_DLL_PUBLIC

diff --git a/epan/uat.h b/epan/uat.h
index aa2c5da030234839c2cea4796829c9cfcb39c8ff..0c22ba1dfbf86e6ff16aa5bbd22e070860f1c8b5 100644 (file)
--- a/epan/uat.h
+++ b/epan/uat.h
@@ -32,6 +32,8 @@
 
 #include <stdlib.h>
 
+#include <epan/emem.h>
+
 #include "ws_symbol_export.h"
 
 #ifdef __cplusplus

diff --git a/tools/ncp2222.py b/tools/ncp2222.py
index 9e07440d271f091910fe4205776229da4e17a7b8..d5b07ed815e4f50243fa1548d18301af00588574 100755 (executable)
--- a/tools/ncp2222.py
+++ b/tools/ncp2222.py
@@ -5737,6 +5737,7 @@ def produce_code():
 #include <string.h>
 #include <glib.h>
 #include <epan/packet.h>
+#include <epan/dfilter/dfilter.h>
 #include <epan/exceptions.h>
 #include <ftypes/ftypes-int.h>
 #include <epan/to_str.h>

diff --git a/ui/gtk/color_edit_dlg.c b/ui/gtk/color_edit_dlg.c
index 0afdd00e58250306044bbf02bc025661d1d4c100..24b34cef7b900364c96ac618a02b05551d4b63bf 100644 (file)
--- a/ui/gtk/color_edit_dlg.c
+++ b/ui/gtk/color_edit_dlg.c
@@ -26,7 +26,7 @@
 
 #include <gtk/gtk.h>
 
-#include <epan/packet.h>
+#include <epan/dfilter/dfilter.h>
 
 #include "../color.h"
 #include "../color_filters.h"

diff --git a/ui/gtk/gui_stat_menu.h b/ui/gtk/gui_stat_menu.h
index 57502b68a63b5ae46e8a7e1d30f68c65798dfd67..69c19f76ff544988b9cd296b24f3b0e760c6eb9d 100644 (file)
--- a/ui/gtk/gui_stat_menu.h
+++ b/ui/gtk/gui_stat_menu.h
@@ -25,6 +25,8 @@
 #ifndef __GTK_STAT_MENU_H__
 #define __GTK_STAT_MENU_H__
 
+#include <epan/proto.h>
+
 #ifdef __cplusplus
 extern "C" {
 #endif /* __cplusplus */