s4-rpc_server/backupkey: Use samdb_system_container_dn() in set_lsa_secret()
authorAndrew Bartlett <abartlet@samba.org>
Thu, 27 Jul 2023 05:09:31 +0000 (17:09 +1200)
committerJule Anger <janger@samba.org>
Tue, 1 Aug 2023 09:53:17 +0000 (09:53 +0000)
This is now exactly the same actions, but just uses common code to do it.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=9959

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 13eed1e0e7d0bdef6b5cdb6b858f124b812adbea)

source4/rpc_server/backupkey/dcesrv_backupkey.c

index 0eda3ce70188fd63fea745f36999c6b8f5f80ba1..5faffdc022cd9143b1ef5323626a24df287970e6 100644 (file)
@@ -88,17 +88,12 @@ static NTSTATUS set_lsa_secret(TALLOC_CTX *mem_ctx,
         * * taillor the function to the particular needs of backup protocol
         */
 
-       system_dn = ldb_dn_copy(frame, ldb_get_default_basedn(ldb));
+       system_dn = samdb_system_container_dn(ldb, frame);
        if (system_dn == NULL) {
                talloc_free(frame);
                return NT_STATUS_NO_MEMORY;
        }
 
-       if (!ldb_dn_add_child_fmt(system_dn, "CN=System")) {
-               talloc_free(frame);
-               return NT_STATUS_NO_MEMORY;
-       }
-
        name2 = talloc_asprintf(msg, "%s Secret", name);
        if (name2 == NULL) {
                talloc_free(frame);