libsmb: Fix CID 1034605 Incorrect pointer comparison
authorAnoop C S <anoopcs@redhat.com>
Wed, 9 Sep 2015 06:35:15 +0000 (06:35 +0000)
committerMichael Adam <obnox@samba.org>
Wed, 9 Sep 2015 16:33:08 +0000 (18:33 +0200)
Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
source3/libsmb/libsmb_printjob.c

index 62e54f47b1bd845b84de10cf99daa45d4d6cb5ad..b9b8e666593b40f63d04faf2ca6d2923b172cb1f 100644 (file)
@@ -125,7 +125,7 @@ SMBC_print_file_ctx(SMBCCTX *c_file,
        }
 
        fid1 = f_open1(c_file, fname, O_RDONLY, 0666);
-       if (fid1 < 0) {
+       if (fid1 == NULL) {
                DEBUG(3, ("Error, fname=%s, errno=%i\n", fname, errno));
                TALLOC_FREE(frame);
                return -1;  /* smbc_open sets errno */