s4:scripting: Prefer ‘x not in y’ to ‘not x in y’
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Fri, 1 Sep 2023 01:26:04 +0000 (13:26 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 14 Sep 2023 21:35:29 +0000 (21:35 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/scripting/bin/samba_dnsupdate

index 8ab78708f45d084f0e985a4c66ca3c6c6d477e0b..6d9d5bc3deebcdd002d38d40425e5deac9050621 100755 (executable)
@@ -906,7 +906,7 @@ for d in delete_list:
             if opts.verbose:
                 print("skip delete (rodc): %s" % d)
             continue
-        if not d.type in [ 'A', 'AAAA' ]:
+        if d.type not in [ 'A', 'AAAA' ]:
             if opts.verbose:
                 print("delete (rodc): %s" % d)
             call_rodc_update(d, op="delete")
@@ -931,7 +931,7 @@ for d in update_list:
             if opts.verbose:
                 print("skip (rodc): %s" % d)
             continue
-        if not d.type in [ 'A', 'AAAA' ]:
+        if d.type not in [ 'A', 'AAAA' ]:
             if opts.verbose:
                 print("update (rodc): %s" % d)
             call_rodc_update(d)