signed / unsigned issues

diff --git a/source/rpc_client/cli_pipe.c b/source/rpc_client/cli_pipe.c
index 12e2cc243c5917c771b06bf3ddf97834b467a3e7..002c86cafc3e04b53baa246c3ff0de37c5d100cd 100644 (file)
--- a/source/rpc_client/cli_pipe.c
+++ b/source/rpc_client/cli_pipe.c
@@ -104,7 +104,7 @@ static BOOL rpc_read(struct cli_state *cli,
        DEBUG(5,("rpc_read: offset end: 0x%x.  data left to read:0x%x\n",
                  rdata->data->offset.end, data_to_read));
 
-       return data_to_read >= 0;
+       return rdata->data.data != NULL;
 }
 
 /****************************************************************************

diff --git a/source/rpc_parse/parse_samr.c b/source/rpc_parse/parse_samr.c
index 5797fab31f1834da80626f36147c03aef5164657..3fab30bf8b07ea22ea94b04c80ea4692a9872d6e 100644 (file)
--- a/source/rpc_parse/parse_samr.c
+++ b/source/rpc_parse/parse_samr.c
@@ -2734,7 +2734,7 @@ void make_samr_q_chgpasswd_user(SAMR_Q_CHGPASSWD_USER *q_u,
 
        make_enc_passwd(&(q_u->lm_newpass), lm_newpass);
        make_enc_hash  (&(q_u->lm_oldhash), lm_oldhash);
-};
+}
 
 /*******************************************************************
 reads or writes a structure.

diff --git a/source/smbd/chgpasswd.c b/source/smbd/chgpasswd.c
index 45497e4cf81f1bb69382484ebc1e1172b598ac04..91062268f9cbb768fb6c952b67bd2e4604767c73 100644 (file)
--- a/source/smbd/chgpasswd.c
+++ b/source/smbd/chgpasswd.c
@@ -613,7 +613,7 @@ BOOL check_oem_password(char *user,
        uchar unenc_old_pw[16];
        uchar null_pw[16];
        uchar null_ntpw[16];
-       uchar no_pw[2];
+       char no_pw[2];
        BOOL nt_pass_set = (ntdata != NULL && nthash != NULL);
 
        become_root(False);

diff --git a/source/smbd/ipc.c b/source/smbd/ipc.c
index 249c286ec7bba28ca2527d7bf71b221f67a46716..4e4eeb40ca0f5039a87de57f01822f1231706417 100644 (file)
--- a/source/smbd/ipc.c
+++ b/source/smbd/ipc.c
@@ -1732,7 +1732,7 @@ static BOOL api_SamOEMChangePassword(connection_struct *conn,uint16 vuid, char *
    */
   (void)Get_Pwnam( user, True);
 
-  if (pass_oem_change(user, (uchar*) data, &data[516], NULL, NULL))
+  if (pass_oem_change(user, (uchar*) data, (uchar*)(&data[516]), NULL, NULL))
   {
     SSVAL(*rparam,0,NERR_Success);
   }