smbd: Remove an obsolete comment
authorVolker Lendecke <vl@samba.org>
Tue, 14 May 2024 15:01:40 +0000 (17:01 +0200)
committerJeremy Allison <jra@samba.org>
Wed, 15 May 2024 16:51:39 +0000 (16:51 +0000)
notify_fname only sends a message to the notify daemon. There is no
potential deadlock anymore.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/close.c

index 7c5c4d68bee20d7db31250814799a46c41e829a1..90c28158322cab59ae72c9347ad5809e1a9f4005 100644 (file)
@@ -633,17 +633,6 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
        }
 
        if (lck_state.delete_object) {
-               /*
-                * Do the notification after we released the share
-                * mode lock. Inside notify_fname we take out another
-                * tdb lock. With ctdb also accessing our databases,
-                * this can lead to deadlocks. Putting this notify
-                * after the TALLOC_FREE(lck) above we avoid locking
-                * two records simultaneously. Notifies are async and
-                * informational only, so calling the notify_fname
-                * without holding the share mode lock should not do
-                * any harm.
-                */
                notify_fname(conn, NOTIFY_ACTION_REMOVED,
                             FILE_NOTIFY_CHANGE_FILE_NAME,
                             fsp->fsp_name->base_name);