s3/lib/smbconf: clang: 'Value stored during its initialization is never read'

Fixes:

source3/lib/smbconf/smbconf_reg.c:123:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
        WERROR werr = WERR_OK;
               ^~~~   ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:178:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
        WERROR werr = WERR_OK;
               ^~~~   ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:444:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
        WERROR werr = WERR_OK;
               ^~~~   ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:583:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
        WERROR werr = WERR_OK;
               ^~~~   ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:712:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
        WERROR werr = WERR_OK;
               ^~~~   ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:995:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
        WERROR werr = WERR_OK;
               ^~~~   ~~~~~~~
source3/lib/smbconf/smbconf_reg.c:1103:9: warning: Value stored to 'werr' during its initialization is never read <--[clang]
        WERROR werr = WERR_OK;
               ^~~~   ~~~~~~~
7 warnings generated.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Wed Jul 17 00:07:48 UTC 2019 on sn-devel-184

diff --git a/source3/lib/smbconf/smbconf_reg.c b/source3/lib/smbconf/smbconf_reg.c
index d4a8b8c2989538183f26df42c659564b451acbcb..c923f3b68201f63233b270b4b81721db9255f3e3 100644 (file)
--- a/source3/lib/smbconf/smbconf_reg.c
+++ b/source3/lib/smbconf/smbconf_reg.c
@@ -120,7 +120,7 @@ static sbcErr smbconf_reg_open_service_key(TALLOC_CTX *mem_ctx,
 static bool smbconf_value_exists(struct registry_key *key, const char *param)
 {
        bool ret = false;
-       WERROR werr = WERR_OK;
+       WERROR werr;
        TALLOC_CTX *ctx = talloc_stackframe();
        struct registry_value *value = NULL;
 
@@ -175,7 +175,7 @@ static sbcErr smbconf_reg_set_value(struct registry_key *key,
                                    const char *valstr)
 {
        struct registry_value val;
-       WERROR werr = WERR_OK;
+       WERROR werr;
        sbcErr err;
        char *subkeyname;
        const char *canon_valname;
@@ -441,7 +441,7 @@ static sbcErr smbconf_reg_get_values(TALLOC_CTX *mem_ctx,
                                     char ***value_strings)
 {
        TALLOC_CTX *tmp_ctx = NULL;
-       WERROR werr = WERR_OK;
+       WERROR werr;
        sbcErr err;
        uint32_t count;
        struct registry_value *valvalue = NULL;
@@ -580,7 +580,7 @@ done:
  */
 static sbcErr smbconf_reg_init(struct smbconf_ctx *ctx, const char *path)
 {
-       WERROR werr = WERR_OK;
+       WERROR werr;
        sbcErr err;
        struct security_token *token;
 
@@ -709,7 +709,7 @@ static void smbconf_reg_get_csn(struct smbconf_ctx *ctx,
 static sbcErr smbconf_reg_drop(struct smbconf_ctx *ctx)
 {
        char *path, *p;
-       WERROR werr = WERR_OK;
+       WERROR werr;
        sbcErr err = SBC_ERR_OK;
        struct registry_key *parent_key = NULL;
        struct registry_key *new_key = NULL;
@@ -992,7 +992,7 @@ static sbcErr smbconf_reg_get_parameter(struct smbconf_ctx *ctx,
                                        const char *param,
                                        char **valstr)
 {
-       WERROR werr = WERR_OK;
+       WERROR werr;
        sbcErr err;
        struct registry_key *key = NULL;
        struct registry_value *value = NULL;
@@ -1100,7 +1100,6 @@ static sbcErr smbconf_reg_set_includes(struct smbconf_ctx *ctx,
                                       uint32_t num_includes,
                                       const char **includes)
 {
-       WERROR werr = WERR_OK;
        sbcErr err;
        struct registry_key *key = NULL;
        TALLOC_CTX *tmp_ctx = talloc_stackframe();
@@ -1112,6 +1111,7 @@ static sbcErr smbconf_reg_set_includes(struct smbconf_ctx *ctx,
        }
 
        if (num_includes == 0) {
+               WERROR werr;
                if (!smbconf_value_exists(key, INCLUDES_VALNAME)) {
                        err = SBC_ERR_OK;
                        goto done;