ldb_mod_op_test: Fix core dump on ldb_case_attrs_index_test_teardown
authorGary Lockyer <gary@catalyst.net.nz>
Mon, 22 Jan 2018 22:02:28 +0000 (11:02 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 5 Mar 2018 19:50:14 +0000 (20:50 +0100)
With no schema syntax, this would occasionally crash as it dereferenced
some possibly NULL sequence of memory.

Note: Removing all tests except this one, made it crash reliably.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb/tests/ldb_mod_op_test.c

index 766ca7983354bf88dda2a37ea9b9da0fc3895bb0..5878143d8f629847bf850ef3556ede4e8fa24784 100644 (file)
@@ -2587,6 +2587,14 @@ static void test_ldb_attrs_index_handler(void **state)
                                                    syntax, &cn_attr_2);
        assert_int_equal(ret, LDB_SUCCESS);
 
+       syntax = ldb_standard_syntax_by_name(ldb, LDB_SYNTAX_OCTET_STRING);
+       assert_non_null(syntax);
+
+       ret = ldb_schema_attribute_fill_with_syntax(ldb, ldb,
+                                                   "", 0,
+                                                   syntax, &default_attr);
+       assert_int_equal(ret, LDB_SUCCESS);
+
        /*
         * Set an attribute handler
         */