CVE-2020-25719 heimdal:kdc: Check return code

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14873

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/heimdal/kdc/krb5tgs.c b/source4/heimdal/kdc/krb5tgs.c
index d4a1c78e153c1e8ff6ad3da870363d74e04bf57c..5cc45826cbe8174bb7dc3d44e06ba401ce2471a7 100644 (file)
--- a/source4/heimdal/kdc/krb5tgs.c
+++ b/source4/heimdal/kdc/krb5tgs.c
@@ -1361,7 +1361,10 @@ tgs_build_reply(krb5_context context,
            ret = KRB5KDC_ERR_POLICY;
            goto out;
        }
-       _krb5_principalname2krb5_principal(context, &p, t->sname, t->realm);
+       ret = _krb5_principalname2krb5_principal(context, &p, t->sname, t->realm);
+       if (ret) {
+           goto out;
+       }
        if(t->enc_part.kvno){
            second_kvno = *t->enc_part.kvno;
            kvno_ptr = &second_kvno;