Drop NotifyAccess=all from systemd units
authorMarcos Mello <marcosfrm@gmail.com>
Fri, 8 May 2020 10:44:51 +0000 (07:44 -0300)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 12 May 2020 10:48:39 +0000 (10:48 +0000)
The implicit NotifyAccess=main is enough since Samba daemons do not
fork()/exit() anymore under systemd.

Signed-off-by: Marcos Mello <marcosfrm@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Alexander Bokovoy <ab@samba.org>
packaging/systemd/nmb.service.in
packaging/systemd/samba.service.in
packaging/systemd/smb.service.in
packaging/systemd/winbind.service.in

index a30812320c0546eb5c5e67254fe60832ad86a155..ceeeea408ec8312fc80dc238a7049beaf6c68a4d 100644 (file)
@@ -6,7 +6,6 @@ After=network.target network-online.target
 
 [Service]
 Type=notify
-NotifyAccess=all
 PIDFile=@PIDDIR@/nmbd.pid
 EnvironmentFile=-@SYSCONFDIR@/sysconfig/samba
 ExecStart=@SBINDIR@/nmbd --foreground --no-process-group $NMBDOPTIONS
index f8ea527536b87dcfaec1d9c060de8bbf3f1bf20d..e4baee1aeec37f9ac25e693c67c90336ee7a6ae5 100644 (file)
@@ -6,7 +6,6 @@ After=network.target network-online.target
 
 [Service]
 Type=notify
-NotifyAccess=all
 PIDFile=@PIDDIR@/samba.pid
 LimitNOFILE=16384
 EnvironmentFile=-@SYSCONFDIR@/sysconfig/samba
index 18912ef0e98fb62bfa79319b31b13809d993fabd..64c77c01502b8f71a94f3348b0f6681481ae742b 100644 (file)
@@ -6,7 +6,6 @@ After=network.target network-online.target nmb.service winbind.service
 
 [Service]
 Type=notify
-NotifyAccess=all
 PIDFile=@PIDDIR@/smbd.pid
 LimitNOFILE=16384
 EnvironmentFile=-@SYSCONFDIR@/sysconfig/samba
index c28d94ca9501502f5d66ba4c2da65114774a8e2f..ac5c922c19f30e406c9710b7408ce8e10551d4d1 100644 (file)
@@ -5,7 +5,6 @@ After=network.target nmb.service
 
 [Service]
 Type=notify
-NotifyAccess=all
 PIDFile=@PIDDIR@/winbindd.pid
 EnvironmentFile=-@SYSCONFDIR@/sysconfig/samba
 ExecStart=@SBINDIR@/winbindd --foreground --no-process-group "$WINBINDOPTIONS"