nsswitch: fix memory leak in winbind_open_pipe_sock() when the privileged pipe is...

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13400

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit ffe970007bf934955f72ec2d73bf8f94a2b796eb)

Autobuild-User(v4-7-test): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(v4-7-test): Wed May  2 15:36:48 CEST 2018 on sn-devel-144

diff --git a/nsswitch/wb_common.c b/nsswitch/wb_common.c
index 262181a3cff2e5a25127e0d86ea667fe5f19fd66..336092b3f286940544bc9cad38ef42c2b2a4d8ed 100644 (file)
--- a/nsswitch/wb_common.c
+++ b/nsswitch/wb_common.c
@@ -420,14 +420,14 @@ static int winbind_open_pipe_sock(struct winbindd_context *ctx,
                        ctx->winbindd_fd = fd;
                        ctx->is_privileged = 1;
                }
+
+               SAFE_FREE(response.extra_data.data);
        }
 
        if ((need_priv != 0) && (ctx->is_privileged == 0)) {
                return -1;
        }
 
-       SAFE_FREE(response.extra_data.data);
-
        return ctx->winbindd_fd;
 #else
        return -1;