git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4f56c70
)
libcli/security: avoid leak on SDDL encode failure
author
Douglas Bagnall
<douglas.bagnall@catalyst.net.nz>
Thu, 16 Nov 2023 23:01:15 +0000
(12:01 +1300)
committer
Andrew Bartlett
<abartlet@samba.org>
Mon, 27 Nov 2023 22:37:32 +0000
(22:37 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
libcli/security/sddl.c
patch
|
blob
|
history
diff --git
a/libcli/security/sddl.c
b/libcli/security/sddl.c
index 1f2ac644f67f5272ec5346184f460fd3fbe1dc22..3b92404634c33a03f361f718088ecbfba3c64c63 100644
(file)
--- a/
libcli/security/sddl.c
+++ b/
libcli/security/sddl.c
@@
-1289,7
+1289,10
@@
char *sddl_encode(TALLOC_CTX *mem_ctx, const struct security_descriptor *sd,
sddl = talloc_strdup(mem_ctx, "");
if (sddl == NULL) goto failed;
- tmp_ctx = talloc_new(mem_ctx);
+ tmp_ctx = talloc_new(sddl);
+ if (tmp_ctx == NULL) {
+ goto failed;
+ }
if (sd->owner_sid != NULL) {
char *sid = sddl_transition_encode_sid(tmp_ctx, sd->owner_sid, &state);