s4-upgradedns: Make sure the attribute exists before accessing it

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Mar 28 10:27:40 CEST 2012 on sn-devel-104

diff --git a/source4/scripting/bin/samba_upgradedns b/source4/scripting/bin/samba_upgradedns
index 1a42e0c8cefe7a73671cfef875969ace5554f9e2..86172a762d8844e563c79f3ca813577a756f845b 100755 (executable)
--- a/source4/scripting/bin/samba_upgradedns
+++ b/source4/scripting/bin/samba_upgradedns
@@ -379,12 +379,16 @@ if __name__ == '__main__':
         msg = msgs[0]
 
         master_nclist = []
-        for nc in msg["msDS-hasMasterNCs"]:
-            master_nclist.append(nc)
+        ncs = msg.get("msDS-hasMasterNCs")
+        if ncs:
+            for nc in ncs:
+                master_nclist.append(nc)
 
         partial_nclist = []
-        for nc in msg["hasPartialReplicaNCs"]:
-            partial_nclist.append(nc)
+        ncs = msg.get("hasPartialReplicaNCs")
+        if ncs:
+            for nc in ncs:
+                partial_nclist.append(nc)
 
         modified = False
         for nc in dns_nclist: