CVE-2019-14847 dsdb/modules/dirsync: ensure attrs exist (CID 1107212)

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14040

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
(cherry picked from commit 23f72c4d712f8d1fec3d67a66d477709d5b0abe2)

diff --git a/source4/dsdb/samdb/ldb_modules/dirsync.c b/source4/dsdb/samdb/ldb_modules/dirsync.c
index b5510eccd24673b8000d651213978c0c6323a136..62a66fef8d4931684b98876ec6c3b50d034a8c43 100644 (file)
--- a/source4/dsdb/samdb/ldb_modules/dirsync.c
+++ b/source4/dsdb/samdb/ldb_modules/dirsync.c
@@ -343,6 +343,10 @@ skip:
 
                attr = dsdb_attribute_by_lDAPDisplayName(dsc->schema,
                                el->name);
+               if (attr == NULL) {
+                       continue;
+               }
+
                keep = false;
 
                if (attr->linkID & 1) {