ndr_size_dom_sid returns a size_t, so that can't be <0. Also, the only
case that ndr_size_dom_sid returns 0 is a NULL sid
pointer. ndr_size_dom_sid can reasonably be assumed to not overflow, the
number of sub-auths is a uint8. That times 4 plus 8 always fits into a
size_t.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
sid_len = ndr_size_dom_sid(&pqt->sid, 0);
query.return_single = 1;
- if (sid_len < 0) {
- status = NT_STATUS_INVALID_PARAMETER;
- goto fail;
- }
info.next_entry_offset = 0;
info.sid_length = sid_len;