auth: Cope with NULL upn_name in PAC

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14995

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/auth/auth_sam_reply.c b/auth/auth_sam_reply.c
index b5b6362dc93bf5515f9cfb45496809f097ca62d7..fda014c87d5c1e24af764454a83bc79b771de45c 100644 (file)
--- a/auth/auth_sam_reply.c
+++ b/auth/auth_sam_reply.c
@@ -616,11 +616,13 @@ NTSTATUS make_user_info_dc_pac(TALLOC_CTX *mem_ctx,
        }
 
        if (pac_upn_dns_info != NULL) {
-               user_info_dc->info->user_principal_name =
-                       talloc_strdup(user_info_dc->info,
-                                     pac_upn_dns_info->upn_name);
-               if (user_info_dc->info->user_principal_name == NULL) {
-                       return NT_STATUS_NO_MEMORY;
+               if (pac_upn_dns_info->upn_name != NULL) {
+                       user_info_dc->info->user_principal_name =
+                               talloc_strdup(user_info_dc->info,
+                                             pac_upn_dns_info->upn_name);
+                       if (user_info_dc->info->user_principal_name == NULL) {
+                               return NT_STATUS_NO_MEMORY;
+                       }
                }
 
                user_info_dc->info->dns_domain_name =