r25019: Fix coverity bug #105, run #332. Use of uninitialized variable.
authorJeremy Allison <jra@samba.org>
Sat, 8 Sep 2007 04:45:59 +0000 (04:45 +0000)
committerJeremy Allison <jra@samba.org>
Sat, 8 Sep 2007 04:45:59 +0000 (04:45 +0000)
Jeremy.

source/utils/net_sam.c

index 3cc838e71b83bad304a2dbef807d7aec46fd1fb7..056bd6a0ccfdf6867c57996e0a8fa1fcc7c7832c 100644 (file)
@@ -362,7 +362,8 @@ static int net_sam_set(int argc, const char **argv)
 static int net_sam_policy_set(int argc, const char **argv)
 {
        const char *account_policy = NULL;
-       uint32 value, old_value;
+       uint32 value = 0;
+       uint32 old_value = 0;
        int field;
        char *endptr;
 
@@ -409,19 +410,20 @@ static int net_sam_policy_set(int argc, const char **argv)
        if (!pdb_get_account_policy(field, &old_value)) {
                d_fprintf(stderr, "Valid account policy, but unable to fetch "
                          "value!\n");
+       } else {
+               d_printf("Account policy \"%s\" value was: %d\n", account_policy,
+                       old_value);
        }
 
        if (!pdb_set_account_policy(field, value)) {
                d_fprintf(stderr, "Valid account policy, but unable to "
                          "set value!\n");
                return -1;
+       } else {
+               d_printf("Account policy \"%s\" value is now: %d\n", account_policy,
+                       value);
        }
 
-       d_printf("Account policy \"%s\" value was: %d\n", account_policy,
-                old_value);
-
-       d_printf("Account policy \"%s\" value is now: %d\n", account_policy,
-                value);
        return 0;
 }