selftest: Remove auth_log test for RAP password change

RAP is SMB1, the password change routine requires LM hashes and so everything
here is going away or has now gone, so remove the test.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/python/samba/tests/auth_log_pass_change.py b/python/samba/tests/auth_log_pass_change.py
index f19512deaf86f8ffa0261de1d196212a5bdf259c..cb4c42167d22e33e53ec5052b2502f5658e6ca9d 100644 (file)
--- a/python/samba/tests/auth_log_pass_change.py
+++ b/python/samba/tests/auth_log_pass_change.py
@@ -200,35 +200,6 @@ class AuthLogPassChangeTests(samba.tests.auth_log_base.AuthLogTestBase):
         self.assertTrue(self.waitForMessages(isLastExpectedMessage),
                         "Did not receive the expected message")
 
-    # net rap password changes are broken, but they trigger enough of the
-    # server side behaviour to exercise the code paths of interest.
-    # if we used the real password it would be too long and does not hash
-    # correctly, so we just check it triggers the wrong password path.
-    def test_rap_change_password(self):
-        def isLastExpectedMessage(msg):
-            return ((msg["type"] == "Authentication") and
-                    (msg["Authentication"]["serviceDescription"] ==
-                        "SAMR Password Change") and
-                    (msg["Authentication"]["status"] ==
-                        "NT_STATUS_WRONG_PASSWORD") and
-                    (msg["Authentication"]["authDescription"] ==
-                        "OemChangePasswordUser2") and
-                    (msg["Authentication"]["eventId"] ==
-                        EVT_ID_UNSUCCESSFUL_LOGON) and
-                    (msg["Authentication"]["logonType"] ==
-                        EVT_LOGON_NETWORK))
-
-        username = os.environ["USERNAME"]
-        server = os.environ["SERVER"]
-        password = os.environ["PASSWORD"]
-        server_param = "--server=%s" % server
-        creds = "-U%s%%%s" % (username, password)
-        call(["bin/net", "rap", server_param,
-              "password", USER_NAME, "notMyPassword", "notGoingToBeMyPassword",
-              server, creds, "--option=client ipc max protocol=nt1"])
-        self.assertTrue(self.waitForMessages(isLastExpectedMessage),
-                        "Did not receive the expected message")
-
     def test_ldap_change_password(self):
         def isLastExpectedMessage(msg):
             return ((msg["type"] == "Authentication") and

diff --git a/selftest/knownfail b/selftest/knownfail
index 7e897dd026d5bd0ee5feb20b8cd3ef145a8725c1..99c8768485bf89416fcbaf56c75d2f8fad4cbe1b 100644 (file)
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -371,10 +371,7 @@
 ^samba.tests.dcerpc.dnsserver.samba.tests.dcerpc.dnsserver.DnsserverTests.test_security_descriptor.*
 ^samba4.blackbox.dbcheck-links.release-4-5-0-pre1.dbcheck_dangling_multi_valued_clean
 ^samba4.blackbox.dbcheck-links.release-4-5-0-pre1.dangling_multi_valued_check_missing
-#
-# rap password tests don't function in the ad_dc_ntvfs environment
-#
-^samba.tests.auth_log_pass_change.samba.tests.auth_log_pass_change.AuthLogPassChangeTests.test_rap_change_password\(ad_dc_ntvfs\)
+
 # We currently don't send referrals for LDAP modify of non-replicated attrs
 ^samba4.ldap.rodc.python\(rodc\).__main__.RodcTests.test_modify_nonreplicated.*
 # NETLOGON is disabled in any non-DC environments

diff --git a/selftest/knownfail.d/lm-hash-support-gone b/selftest/knownfail.d/lm-hash-support-gone
index 11a9cefc2715c95d1cd2857ed6a59b7d8719db79..9700bb65719cfafe6c86e64b7b928539659d9b18 100644 (file)
--- a/selftest/knownfail.d/lm-hash-support-gone
+++ b/selftest/knownfail.d/lm-hash-support-gone
@@ -7,4 +7,3 @@
 ^samba.tests.ntlm_auth.samba.tests.ntlm_auth.NTLMAuthHelpersTests.test_diagnostics\(nt4_dc:local\)
 ^samba.tests.ntlm_auth.samba.tests.ntlm_auth.NTLMAuthHelpersTests.test_diagnostics\(nt4_member:local\)
 ^samba4.rpc.samlogon on ncacn_np with .samlogon\(ad_dc_slowtests\)
-^samba.tests.auth_log_pass_change.samba.tests.auth_log_pass_change.AuthLogPassChangeTests.test_rap_change_password\(ad_dc_smb1\)