From: Douglas Bagnall Date: Sun, 17 Mar 2024 10:08:23 +0000 (+1300) Subject: libcli/security: check again for NULL values X-Git-Tag: samba-4.20.0~16 X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=28fc1850e5c0b02f2ca0e0a8516457d56dc17cbd;p=samba.git libcli/security: check again for NULL values BUG: https://bugzilla.samba.org/show_bug.cgi?id=156067 Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett Autobuild-User(master): Andrew Bartlett Autobuild-Date(master): Mon Mar 18 02:51:08 UTC 2024 on atb-devel-224 (cherry picked from commit b815abe77991d7929717ea3ed4b9d7bef7179715) Autobuild-User(v4-20-test): Jule Anger Autobuild-Date(v4-20-test): Wed Mar 20 12:03:45 UTC 2024 on atb-devel-224 --- diff --git a/libcli/security/claims-conversions.c b/libcli/security/claims-conversions.c index 0d3b06de4fe..ccf1375fc8f 100644 --- a/libcli/security/claims-conversions.c +++ b/libcli/security/claims-conversions.c @@ -262,6 +262,9 @@ static bool claim_v1_offset_to_ace_token( uint8_t f = claim->flags & CLAIM_SECURITY_ATTRIBUTE_VALUE_CASE_SENSITIVE; result->flags = f | CONDITIONAL_ACE_FLAG_TOKEN_FROM_ATTR; + if (claim->values[offset].int_value == NULL) { + return false; + } switch (claim->value_type) { case CLAIM_SECURITY_ATTRIBUTE_TYPE_INT64: return claim_v1_int_to_ace_int(claim, offset, result);