From: Matthias Dieter Wallnöfer <mdw@samba.org>
Date: Fri, 14 Oct 2011 07:51:04 +0000 (+0200)
Subject: s4:repl_meta_data LDB module - rename operation - do not overwrite error messages
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=2ee42ebab3776cea89a5b00464d7cb9db78cd27c;p=obnox%2Fsamba%2Fsamba-obnox.git

s4:repl_meta_data LDB module - rename operation - do not overwrite error messages

"ldb_error" could overwrite possibly useful error messages.

Reviewed-by: abartlet
---

diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index d6609733e2c..bffe5a64e00 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -2567,9 +2567,7 @@ static int replmd_rename_callback(struct ldb_request *req, struct ldb_reply *are
 
 	if (ret != LDB_SUCCESS) {
 		talloc_free(ares);
-		return ldb_module_done(ac->req, NULL, NULL,
-				       ldb_error(ldb, ret,
-					"failed to call replmd_update_rpmd()"));
+		return ldb_module_done(ac->req, NULL, NULL, ret);
 	}
 
 	if (ac->seq_num == 0) {