From: Andrew Bartlett <abartlet@samba.org>
Date: Tue, 12 Sep 2023 07:01:03 +0000 (+1200)
Subject: CVE-2023-42669 s3-rpc_server: Disable rpcecho for consistency with the AD DC
X-Git-Tag: samba-4.18.8~4
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=2ef556473bd858fc3dbcd6372835ded48f75135d;p=samba.git

CVE-2023-42669 s3-rpc_server: Disable rpcecho for consistency with the AD DC

The rpcecho server in source3 does have samba the sleep() feature that
the s4 version has, but the task architecture is different, so there
is not the same impact.  Hoever equally this is not something that
should be enabled on production builds of Samba, so restrict to
selftest builds.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15474

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/source3/rpc_server/wscript_build b/source3/rpc_server/wscript_build
index 341df41a321..5ed81283395 100644
--- a/source3/rpc_server/wscript_build
+++ b/source3/rpc_server/wscript_build
@@ -38,6 +38,7 @@ bld.SAMBA3_BINARY('rpcd_rpcecho',
                   RPC_WORKER
                   RPC_RPCECHO
                   ''',
+                  for_selftest=True,
                   install_path='${SAMBA_LIBEXECDIR}')
 
 bld.SAMBA3_BINARY('rpcd_classic',