From: Christof Schmitt <cs@samba.org>
Date: Wed, 19 Jun 2019 20:53:54 +0000 (-0700)
Subject: nfs4_acls: Add warning for deprecated setting nfs4:mode special
X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=728de59740925665d55c72c7f67c85c7b6b4a5e1;p=autobuild.flakey.sn-devel-184%2F.git

nfs4_acls: Add warning for deprecated setting nfs4:mode special

The documentation states this has been deprecated for years. Add logging
a warning when this is set. Maybe this can be removed in the future.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
---

diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c
index 46b69ac3d82..5b4d43adc8a 100644
--- a/source3/modules/nfs4_acls.c
+++ b/source3/modules/nfs4_acls.c
@@ -82,6 +82,9 @@ int smbacl4_get_vfs_params(struct connection_struct *conn,
 		return -1;
 	}
 	params->mode = (enum smbacl4_mode_enum)enumval;
+	if (params->mode == e_special) {
+		DBG_WARNING("nfs4:mode special is deprecated.\n");
+	}
 
 	params->do_chown = lp_parm_bool(SNUM(conn), SMBACL4_PARAM_TYPE_NAME,
 		"chown", true);