From: David Disseldorp Date: Wed, 15 Feb 2012 15:30:27 +0000 (+0100) Subject: s3-printing: fix crash in printer_list_set_printer() X-Git-Url: http://git.samba.org/?a=commitdiff_plain;h=a6bd7f3d574998419cac01b1f7b4fa2e1067bb7c;p=obnox%2Fsamba%2Fsamba-obnox.git s3-printing: fix crash in printer_list_set_printer() The printer list database format was recently changed to accommodate for the printcap location field. One of the tdb_pack calls is not provided with a location string argument, this causes a crash on some platforms. https://bugzilla.samba.org/show_bug.cgi?id=8762 Signed-off-by: Günther Deschner Signed-off-by: Jim McDonough Signed-off-by: Lars Müller Autobuild-User: David Disseldorp Autobuild-Date: Wed Feb 15 19:34:38 CET 2012 on sn-devel-104 --- diff --git a/source3/printing/printer_list.c b/source3/printing/printer_list.c index d9e87376606..7079ddc037a 100644 --- a/source3/printing/printer_list.c +++ b/source3/printing/printer_list.c @@ -191,7 +191,7 @@ NTSTATUS printer_list_set_printer(TALLOC_CTX *mem_ctx, data.dsize = len; len = tdb_pack(data.dptr, data.dsize, - PL_DATA_FORMAT, time_h, time_l, name, str); + PL_DATA_FORMAT, time_h, time_l, name, str, str2); status = dbwrap_store_bystring_upper(db, key, data, TDB_REPLACE);