metze/samba/wip.git
13 years agos3:build: determine full version of libtdb for the samba build
Michael Adam [Fri, 6 May 2011 14:42:53 +0000 (16:42 +0200)]
s3:build: determine full version of libtdb for the samba build
(cherry picked from commit 23637b5789a43fe75bb4eadabd33fb321272b42b)

13 years agos3:build: link libtalloc as shared lib if using shared libs at all
Michael Adam [Fri, 6 May 2011 14:42:07 +0000 (16:42 +0200)]
s3:build: link libtalloc as shared lib if using shared libs at all
(cherry picked from commit 6c300ec4b51bfd57837d193f0b17b60cb152fc27)

13 years agos3:build: determine full version of libtalloc for the samba build
Michael Adam [Fri, 6 May 2011 14:40:59 +0000 (16:40 +0200)]
s3:build: determine full version of libtalloc for the samba build
(cherry picked from commit 472cabbdea3d5def7e7a36b19c5851a0cf0d8d83)

13 years agos3:build: fix typo in definition of --enable-external-libtdb
Michael Adam [Fri, 6 May 2011 14:39:03 +0000 (16:39 +0200)]
s3:build: fix typo in definition of --enable-external-libtdb
(cherry picked from commit b731b6e032d9ba1469c349d6c46bd7bb52b18c28)

13 years agos3:build: reformat AC_ARG_ENABLE(external_libtalloc...)
Michael Adam [Fri, 6 May 2011 14:38:38 +0000 (16:38 +0200)]
s3:build: reformat AC_ARG_ENABLE(external_libtalloc...)
(cherry picked from commit abef191fb9fa9edbdb68d7cbbf017e1fa74583f2)

13 years agos3:build: print the full version number in the showlibs targets
Michael Adam [Fri, 6 May 2011 10:57:03 +0000 (12:57 +0200)]
s3:build: print the full version number in the showlibs targets
(cherry picked from commit 7e230b31d19fcd37d5765e9649ccfca39af5541d)

13 years agos3:build: add LIBWBCLIENT_FULLVER for consistency with SMB_LIBRARY()
Michael Adam [Fri, 6 May 2011 14:37:58 +0000 (16:37 +0200)]
s3:build: add LIBWBCLIENT_FULLVER for consistency with SMB_LIBRARY()
(cherry picked from commit d5d53ba5148d57bae207ded7525a4a38fcb5836f)

13 years agos3:build: add an optional full version argument to the SMB_LIBRARY() macro.
Michael Adam [Fri, 6 May 2011 10:44:04 +0000 (12:44 +0200)]
s3:build: add an optional full version argument to the SMB_LIBRARY() macro.
(cherry picked from commit adb3fc2f1d85f7621043d087ed2afb0fd053a009)

13 years agos3:configure: add --enable-smbtorture4 switch
Michael Adam [Fri, 6 May 2011 16:35:06 +0000 (18:35 +0200)]
s3:configure: add --enable-smbtorture4 switch
(cherry picked from commit f8e32980f4fab8d6cad5c9f95fab0d1828717cd2)

13 years agoFix 3.6 headers
Simo Sorce [Fri, 13 May 2011 20:36:42 +0000 (16:36 -0400)]
Fix 3.6 headers

13 years agos3-gse: Use gss_get_name_attribute to fetch the pac
Simo Sorce [Mon, 9 May 2011 15:33:41 +0000 (11:33 -0400)]
s3-gse: Use gss_get_name_attribute to fetch the pac

This is the only way to be sure the pac signatures are correct.
It requires a fairly new version of MIT Kerberos, but that should be fine, it
is new functionality in 3.6 anyways.

13 years agoWHATSNEW: Start 3.6.0rc1 release notes.
Karolin Seeger [Fri, 13 May 2011 19:47:57 +0000 (21:47 +0200)]
WHATSNEW: Start 3.6.0rc1 release notes.

Karolin

13 years agoVERSION: Bump version up to 3.6.0rc1.
Karolin Seeger [Fri, 13 May 2011 19:44:45 +0000 (21:44 +0200)]
VERSION: Bump version up to 3.6.0rc1.

Karolin

13 years agorpc_server: Always use rpc_pipe_open_interface()
Simo Sorce [Wed, 11 May 2011 20:38:46 +0000 (16:38 -0400)]
rpc_server: Always use rpc_pipe_open_interface()

This way we can configure which rpc service we actually want to connect to.
By default it uses an "embedded" interface and calls rpc_pipe_open_internal()

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 14:40:26 CEST 2011 on sn-devel-104
(cherry picked from commit d31181214cee1ce459b58f0ca60b40a38f396dac)

13 years agos3:registry: add a warning debug message when the sorted subkeys is created from...
Michael Adam [Wed, 11 May 2011 14:19:41 +0000 (16:19 +0200)]
s3:registry: add a warning debug message when the sorted subkeys is created from key_exists()

13 years agos3:registry: recreate the sorted subkeys cache when storing keys
Michael Adam [Wed, 11 May 2011 13:58:48 +0000 (15:58 +0200)]
s3:registry: recreate the sorted subkeys cache when storing keys

This is to avoid turning the next read operation into a write op.

13 years agos3:registry: add create_sorted_subkeys() to delete and recreate the sorted subkeys key
Michael Adam [Wed, 11 May 2011 13:27:01 +0000 (15:27 +0200)]
s3:registry: add create_sorted_subkeys() to delete and recreate the sorted subkeys key

This is to be used from other places than the key_exists() code path.

13 years agos3:registry: turn create_sorted_subkeys_internal to NTSTATUS return type
Michael Adam [Wed, 11 May 2011 12:53:48 +0000 (14:53 +0200)]
s3:registry: turn create_sorted_subkeys_internal to NTSTATUS return type

(from bool)

13 years agos3:registry: rename create_sorted_subkeys() to create_sorted_subkeys_internal()
Michael Adam [Wed, 11 May 2011 12:49:10 +0000 (14:49 +0200)]
s3:registry: rename create_sorted_subkeys() to create_sorted_subkeys_internal()

13 years agos3:registry: fix a typo in a debug message
Michael Adam [Wed, 11 May 2011 12:17:21 +0000 (14:17 +0200)]
s3:registry: fix a typo in a debug message

13 years agos3-libnetjoin: fix uninitialized variable.
Günther Deschner [Thu, 12 May 2011 22:19:13 +0000 (00:19 +0200)]
s3-libnetjoin: fix uninitialized variable.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May 13 01:22:18 CEST 2011 on sn-devel-104
(cherry picked from commit 62862e27bbf94aa52623f64f17fbda8a2db38095)

13 years agos3-libnetapi/libnetjoin: fix uninitialized variables after the libsmbconf changes.
Günther Deschner [Thu, 12 May 2011 22:15:41 +0000 (00:15 +0200)]
s3-libnetapi/libnetjoin: fix uninitialized variables after the libsmbconf changes.

Guenther
(cherry picked from commit 04c101e873bd758fae6b7131551f6069ab2fcce3)

13 years agos3-includes: move enum flush_reason_enum to smb.h
Günther Deschner [Tue, 3 May 2011 14:25:20 +0000 (16:25 +0200)]
s3-includes: move enum flush_reason_enum to smb.h

Guenther
(cherry picked from commit 89e60556065c6e3dc7a8447cdba5a8fed1d19ea4)

13 years agos3-lib/smbconf: fix uninitialized error code in smbconf_reg_init().
Günther Deschner [Thu, 12 May 2011 15:03:20 +0000 (17:03 +0200)]
s3-lib/smbconf: fix uninitialized error code in smbconf_reg_init().

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May 12 18:09:16 CEST 2011 on sn-devel-104
(cherry picked from commit 7da530e1e42ab15152bc39d4edd4e9a10f091a22)

13 years agolibsmbconf: Define a doxygen group for libsmbconf.
Andreas Schneider [Thu, 14 Apr 2011 09:59:57 +0000 (11:59 +0200)]
libsmbconf: Define a doxygen group for libsmbconf.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_transaction_cancel().
Andreas Schneider [Thu, 14 Apr 2011 09:54:11 +0000 (11:54 +0200)]
libsmbconf: Document smbconf_transaction_cancel().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_transaction_commit().
Andreas Schneider [Thu, 14 Apr 2011 09:53:25 +0000 (11:53 +0200)]
libsmbconf: Document smbconf_transaction_commit().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_transaction_start().
Andreas Schneider [Thu, 14 Apr 2011 09:52:30 +0000 (11:52 +0200)]
libsmbconf: Document smbconf_transaction_start().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_global_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:50:05 +0000 (11:50 +0200)]
libsmbconf: Document smbconf_delete_global_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:49:24 +0000 (11:49 +0200)]
libsmbconf: Document smbconf_delete_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_set_global_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:48:15 +0000 (11:48 +0200)]
libsmbconf: Document smbconf_set_global_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_set_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:47:41 +0000 (11:47 +0200)]
libsmbconf: Document smbconf_set_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_global_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:45:14 +0000 (11:45 +0200)]
libsmbconf: Document smbconf_get_global_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_includes().
Andreas Schneider [Thu, 14 Apr 2011 09:44:22 +0000 (11:44 +0200)]
libsmbconf: Document smbconf_get_includes().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_global_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:38:31 +0000 (11:38 +0200)]
libsmbconf: Document smbconf_delete_global_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:37:59 +0000 (11:37 +0200)]
libsmbconf: Document smbconf_delete_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_global_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:36:36 +0000 (11:36 +0200)]
libsmbconf: Document smbconf_get_global_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:35:11 +0000 (11:35 +0200)]
libsmbconf: Document smbconf_get_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_set_global_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:32:06 +0000 (11:32 +0200)]
libsmbconf: Document smbconf_set_global_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_set_parameter().
Andreas Schneider [Thu, 14 Apr 2011 09:31:17 +0000 (11:31 +0200)]
libsmbconf: Document smbconf_set_parameter().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_delete_share().
Andreas Schneider [Thu, 14 Apr 2011 09:28:00 +0000 (11:28 +0200)]
libsmbconf: Document smbconf_delete_share().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_share().
Andreas Schneider [Thu, 14 Apr 2011 09:27:03 +0000 (11:27 +0200)]
libsmbconf: Document smbconf_get_share().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_create_share().
Andreas Schneider [Thu, 14 Apr 2011 09:25:07 +0000 (11:25 +0200)]
libsmbconf: Document smbconf_create_share().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_share_exists().
Andreas Schneider [Thu, 14 Apr 2011 09:23:56 +0000 (11:23 +0200)]
libsmbconf: Document smbconf_share_exists().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_share_names().
Andreas Schneider [Thu, 14 Apr 2011 09:22:25 +0000 (11:22 +0200)]
libsmbconf: Document smbconf_get_share_names().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_get_config().
Andreas Schneider [Thu, 14 Apr 2011 09:19:36 +0000 (11:19 +0200)]
libsmbconf: Document smbconf_get_config().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_drop().
Andreas Schneider [Thu, 14 Apr 2011 09:13:49 +0000 (11:13 +0200)]
libsmbconf: Document smbconf_drop().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_changed().
Andreas Schneider [Thu, 14 Apr 2011 09:12:27 +0000 (11:12 +0200)]
libsmbconf: Document smbconf_changed().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_shutdown().
Andreas Schneider [Thu, 14 Apr 2011 09:05:09 +0000 (11:05 +0200)]
libsmbconf: Document smbconf_shutdown().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_is_writeable().
Andreas Schneider [Thu, 14 Apr 2011 09:04:15 +0000 (11:04 +0200)]
libsmbconf: Document smbconf_is_writeable().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Document smbconf_backend_requires_messaging().
Andreas Schneider [Thu, 14 Apr 2011 09:02:49 +0000 (11:02 +0200)]
libsmbconf: Document smbconf_backend_requires_messaging().

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agos3-waf: Create a public libsmconf.
Andreas Schneider [Tue, 12 Apr 2011 09:02:07 +0000 (11:02 +0200)]
s3-waf: Create a public libsmconf.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agos3-waf: Create a registry private library.
Andreas Schneider [Tue, 12 Apr 2011 08:59:20 +0000 (10:59 +0200)]
s3-waf: Create a registry private library.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_config() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 15:43:10 +0000 (17:43 +0200)]
libsmbconf: Convert smbconf_get_config() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_transaction_*() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 15:24:13 +0000 (17:24 +0200)]
libsmbconf: Convert smbconf_transaction_*() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_delete_includes() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 14:01:22 +0000 (16:01 +0200)]
libsmbconf: Convert smbconf_delete_includes() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_set_includes() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 13:14:52 +0000 (15:14 +0200)]
libsmbconf: Convert smbconf_set_includes() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_includes() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 12:52:52 +0000 (14:52 +0200)]
libsmbconf: Convert smbconf_get_includes() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_delete_parameter() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 12:20:32 +0000 (14:20 +0200)]
libsmbconf: Convert smbconf_delete_parameter() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_parameter() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 11:50:53 +0000 (13:50 +0200)]
libsmbconf: Convert smbconf_get_parameter() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_set_parameter() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 11:23:26 +0000 (13:23 +0200)]
libsmbconf: Convert smbconf_set_parameter() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_delete_share() to sbcErr.
Andreas Schneider [Mon, 11 Apr 2011 09:39:03 +0000 (11:39 +0200)]
libsmbconf: Convert smbconf_delete_share() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_share() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 15:20:35 +0000 (17:20 +0200)]
libsmbconf: Convert smbconf_get_share() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_create_share() to smbErr.
Andreas Schneider [Fri, 8 Apr 2011 13:48:01 +0000 (15:48 +0200)]
libsmbconf: Convert smbconf_create_share() to smbErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_get_share_names() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 12:19:15 +0000 (14:19 +0200)]
libsmbconf: Convert smbconf_get_share_names() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_drop() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 08:40:02 +0000 (10:40 +0200)]
libsmbconf: Convert smbconf_drop() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_open() to sbcErr.
Andreas Schneider [Fri, 8 Apr 2011 08:28:17 +0000 (10:28 +0200)]
libsmbconf: Convert smbconf_open() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Convert smbconf_init() to sbcErr.
Andreas Schneider [Thu, 7 Apr 2011 15:19:03 +0000 (17:19 +0200)]
libsmbconf: Convert smbconf_init() to sbcErr.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agolibsmbconf: Added a sbcErrorString() function.
Andreas Schneider [Thu, 7 Apr 2011 13:27:52 +0000 (15:27 +0200)]
libsmbconf: Added a sbcErrorString() function.

Signed-off-by: Michael Adam <obnox@samba.org>
(cherry picked from commit b34e1768b762ae46e4fe761d9691ed09d285c9a9)

13 years agolibsmbconf: Introduce a sbcErrType.
Andreas Schneider [Thu, 7 Apr 2011 13:27:26 +0000 (15:27 +0200)]
libsmbconf: Introduce a sbcErrType.

Signed-off-by: Michael Adam <obnox@samba.org>
13 years agos3-printing: make cups_pull_comment_location() work again.
Günther Deschner [Wed, 11 May 2011 08:30:42 +0000 (10:30 +0200)]
s3-printing: make cups_pull_comment_location() work again.

we deal with lp_cups_server in cups_connect() already, inside the URI all our
other cups functions we use ipp://localhost, do the same here.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May 11 11:36:07 CEST 2011 on sn-devel-104
(cherry picked from commit f99d6f079a0060e4d08d7384bdf230d4d2c62b86)

13 years agos3-printing: Fix double free of cups request.
Günther Deschner [Tue, 10 May 2011 13:49:05 +0000 (15:49 +0200)]
s3-printing: Fix double free of cups request.

We never free the request in our cups api usage except for here. The reason is
probably htis (from the cupsDoConnect API docs):

"This function sends the IPP request to the specified server, retrying and
authenticating as necessary. The request is freed with ippDelete() after
receiving a valid IPP response."

Revert "Fix a memory leak in cups_pull_comment_location"

This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632.

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
(cherry picked from commit 019f11dd5b3240d05c1abe30dec3d793d6919313)

13 years agos3-printing: very obvious fix for cups_pull_comment_location().
Günther Deschner [Tue, 10 May 2011 13:48:25 +0000 (15:48 +0200)]
s3-printing: very obvious fix for cups_pull_comment_location().

This has been in there since 2008...

Guenther
(cherry picked from commit 3ba3f68e03510e3bb5b7627c200af0395e853bc2)

13 years agos3-events: tevent_internal.h is not a public header
Andrew Tridgell [Tue, 10 May 2011 12:55:45 +0000 (14:55 +0200)]
s3-events: tevent_internal.h is not a public header

We need to use the "foo.h" form instead of the <foo.h> form for
headers that are not installed publicly. Otherwise when an external
version of tevent is used we won't find the header and the build will
fail.

Note that this creates a structure dependency between the
tevent structures in the external library and the headers in our
source tree. That is not ideal, but is currently OK as the waf build
will only use the external library if it is at least the same version
as the internal tree, which means it will actually be the same
version, as we release the external version from our tree.

We should come up with a better solution, but for now this allows
openchange to build again.

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Tue May 10 16:06:40 CEST 2011 on sn-devel-104
(cherry picked from commit 628fcd111af9b51020191a6ee916896c127c88c1)

13 years agos3: Use tevent_req_ntstatus properly in a few places
Volker Lendecke [Tue, 10 May 2011 09:05:47 +0000 (11:05 +0200)]
s3: Use tevent_req_ntstatus properly in a few places

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue May 10 13:11:10 CEST 2011 on sn-devel-104
(cherry picked from commit 44cc1656276d99816614408b5cd846e6a57eacf0)

13 years agos3: Use tevent_req_ntstatus properly in a few places
Volker Lendecke [Tue, 10 May 2011 09:05:47 +0000 (11:05 +0200)]
s3: Use tevent_req_ntstatus properly in a few places
(cherry picked from commit 06a2ff579692ea062944e5bd90d3526327004954)

13 years agoasync_smb.c: convert cli->timeout properly
Rusty Russell [Tue, 10 May 2011 08:03:11 +0000 (17:33 +0930)]
async_smb.c: convert cli->timeout properly

I have a test failure on my 32-bit Ubuntu system, in that
samba3.smbtorture_s3.plain(s3dc).LOCK9 immediately times out (rather than
waiting 5 seconds for the child).

Debugging revealed this code: timeout is in ms and is set to > 1000 in
various places.  The code dates from 2002, and other perturbations didn't
reveal why it breaks now, but fix it anyway.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Tue May 10 12:09:07 CEST 2011 on sn-devel-104
(cherry picked from commit 87e35421744df568721a7f9c7fa141d62665d183)

13 years agoA couple more off-by-one calculations with strlcpy.
Jeremy Allison [Fri, 6 May 2011 14:54:18 +0000 (07:54 -0700)]
A couple more off-by-one calculations with strlcpy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 18:39:17 CEST 2011 on sn-devel-104
(cherry picked from commit f7b3909103a0acd5ee0426b85112f2c9ed4e7730)

13 years agos3-waf: add vfs_gpfs_hsm_notify to the build.
Günther Deschner [Wed, 4 May 2011 16:01:04 +0000 (18:01 +0200)]
s3-waf: add vfs_gpfs_hsm_notify to the build.

Volker, can you please check this is correct ?

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May  4 19:03:45 CEST 2011 on sn-devel-104
(cherry picked from commit 0d1b2d2033e9cc33accea29a4c3a8fafd3d75aa2)

13 years agotdb: fix a build warning.
Günther Deschner [Thu, 5 May 2011 10:52:05 +0000 (12:52 +0200)]
tdb: fix a build warning.

Guenther
(cherry picked from commit 73c31f044e32103276558a194698ea6cf876b4f2)

13 years agolibcli/security: fix build warning, cr_descr_log_acl() is not used currently.
Günther Deschner [Thu, 5 May 2011 10:52:29 +0000 (12:52 +0200)]
libcli/security: fix build warning, cr_descr_log_acl() is not used currently.

Guenther
(cherry picked from commit 03b9a9938b934ff774ad49c5b409c7060e66b999)

13 years agos3-spoolss: remove unused struct in construct_notify_printer_info().
Günther Deschner [Thu, 5 May 2011 19:52:57 +0000 (21:52 +0200)]
s3-spoolss: remove unused struct in construct_notify_printer_info().

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May  6 12:07:17 CEST 2011 on sn-devel-104
(cherry picked from commit ab8219a6f39360da742d0f3ca702f2173d798538)

13 years agos3-proto: remove some duplicate prototypes.
Günther Deschner [Fri, 6 May 2011 12:03:00 +0000 (14:03 +0200)]
s3-proto: remove some duplicate prototypes.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May  6 16:21:08 CEST 2011 on sn-devel-104
(cherry picked from commit 41134f7f4bb6cd2ff84422782dfb82845d881950)

13 years agos3: Fix a typo
Volker Lendecke [Thu, 5 May 2011 13:09:09 +0000 (15:09 +0200)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May  5 16:10:35 CEST 2011 on sn-devel-104
(cherry picked from commit 1c407da7c357d7cad693a152c0eecafc3dc97c61)

13 years agos3: Fix dup_smb2_vec3
Volker Lendecke [Thu, 5 May 2011 10:17:41 +0000 (12:17 +0200)]
s3: Fix dup_smb2_vec3

Metze, Jeremy, please check!

Thanks,

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May  5 13:39:40 CEST 2011 on sn-devel-104
(cherry picked from commit 82b9fa3a199031217bd98d846f2386b556911fa2)

13 years agoFix off-by-one when used with safe_strcpy.
Jeremy Allison [Tue, 3 May 2011 20:57:30 +0000 (13:57 -0700)]
Fix off-by-one when used with safe_strcpy.
(cherry picked from commit 18582016d96e3f41f8828f0539969678ad7d233e)

13 years agoBUGFIX when converting from safe_strcpy to strlcpy.
Jeremy Allison [Tue, 3 May 2011 20:49:28 +0000 (13:49 -0700)]
BUGFIX when converting from safe_strcpy to strlcpy.

We must have a blob legth > 0 in order to safely copy
the (possibly) 16 bytes + 1 byte zero character safely.
(cherry picked from commit 265338c194ceab2520ed1df0f64b62e7169406dd)

13 years agoRemove unused function parse_add_domuser().
Jeremy Allison [Tue, 3 May 2011 19:55:42 +0000 (12:55 -0700)]
Remove unused function parse_add_domuser().

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May  4 20:05:42 CEST 2011 on sn-devel-104
(cherry picked from commit 54727f93163f1529eb78dfab5ac605e138391797)

13 years agos3-vfs: make vfswrap_llistxattr and vfswrap_flistxattr static.
Günther Deschner [Tue, 3 May 2011 19:42:04 +0000 (21:42 +0200)]
s3-vfs: make vfswrap_llistxattr and vfswrap_flistxattr static.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May  4 12:31:10 CEST 2011 on sn-devel-104
(cherry picked from commit b8eaec6b666b1f0d3711540c492edd79cd02b1fe)

13 years agoAlways build before commit ... :-)
Volker Lendecke [Wed, 4 May 2011 15:48:12 +0000 (17:48 +0200)]
Always build before commit ... :-)
(cherry picked from commit d4d3d7383a9e3c2c0910a848f33755ca54c32b99)

13 years agoRHEL-CTDB: Build vfs_gpfs_hsm_notify
Volker Lendecke [Wed, 4 May 2011 14:02:15 +0000 (16:02 +0200)]
RHEL-CTDB: Build vfs_gpfs_hsm_notify

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 17:12:14 CEST 2011 on sn-devel-104
(cherry picked from commit 3e211510034dd3854017e1b35ef5e1964085df5d)

13 years agovfs_gpfs: Properly notify the offline->online changes
Volker Lendecke [Wed, 4 May 2011 13:48:27 +0000 (15:48 +0200)]
vfs_gpfs: Properly notify the offline->online changes

This needs to be a separate module that cooperates with vfs_gpfs. If aio_fork
is used early in the module chain it (correctly) does not propagate the aio ops
down, so vfs_gpfs does not see them. This slim module must come early in the
chain for notifies to work properly.
(cherry picked from commit 3f68b43dd56b8f338a18074741162bf6437ae78d)

13 years agovfs_gpfs: Block sendfile for offline files
Volker Lendecke [Wed, 4 May 2011 13:47:42 +0000 (15:47 +0200)]
vfs_gpfs: Block sendfile for offline files
(cherry picked from commit 41bde55821a6c18ace24330aede8d4928215e658)

13 years agovfs_gpfs: Store the winattrs in st.vfs_private
Volker Lendecke [Wed, 4 May 2011 13:42:54 +0000 (15:42 +0200)]
vfs_gpfs: Store the winattrs in st.vfs_private

This avoids a considerable amount of gpfs_winattr calls
(cherry picked from commit 2329fb56a701804585d866817586b4d567966b92)

13 years agos3: Properly deal with exited winbind children
Volker Lendecke [Wed, 4 May 2011 10:11:04 +0000 (12:11 +0200)]
s3: Properly deal with exited winbind children

When a winbind child exits, we need to immediately close the socket. If not,
the next request to that child will be sent to a socket without a listener,
leading to a failed request. This failed request will then trigger a proper
re-init.

This patch avoids the one failed request.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 13:32:16 CEST 2011 on sn-devel-104
(cherry picked from commit d08414b6799747f224ba02300585c8b15ac6bc0e)

13 years agos3: Filter out duplicates in name_query()
Volker Lendecke [Tue, 3 May 2011 19:28:37 +0000 (21:28 +0200)]
s3: Filter out duplicates in name_query()

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 00:03:47 CEST 2011 on sn-devel-104
(cherry picked from commit 7febcb5ffeb2d92f2a4f8abe2c0dac91f5c8a53e)

13 years agos3-includes: when MADVISE support was reverted back in 2009, someone forgot this...
Günther Deschner [Tue, 3 May 2011 14:28:44 +0000 (16:28 +0200)]
s3-includes: when MADVISE support was reverted back in 2009, someone forgot this hunk.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue May  3 22:06:20 CEST 2011 on sn-devel-104
(cherry picked from commit c616379e14f7db35429ac849bbc6eb3d4dc641ec)

13 years agoѕ3/configure: move out generic CPPFLAGS in the solaris case here
Björn Jacke [Wed, 20 Apr 2011 21:40:30 +0000 (23:40 +0200)]
ѕ3/configure: move out generic CPPFLAGS in the solaris case here

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 862ff644ee564b2b3ed316da8c19df2f958aef66)

13 years agoѕ3/configure: move out generic LDFLAGS in the solaris case here
Björn Jacke [Wed, 20 Apr 2011 21:32:12 +0000 (23:32 +0200)]
ѕ3/configure: move out generic LDFLAGS in the solaris case here

Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit 9738f35f2cef0af11c3390162a9c2a3841d6073b)

13 years agos3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path
Björn Jacke [Wed, 20 Apr 2011 22:11:21 +0000 (00:11 +0200)]
s3: reply_readbraw_error needs an sconn as argument also in the non-LFS code path

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Tue May  3 13:04:11 CEST 2011 on sn-devel-104
(cherry picked from commit cd9a7c143c87fa0f1fda8a6c9b331b21ae6148a2)