Yan, Zheng [Wed, 18 Mar 2015 03:34:25 +0000 (11:34 +0800)]
vfs_ceph: remove cephwrap_init_stat_ex_from_stat()
cephwrap_init_stat_ex_from_stat() lacks code that makes 'create'
timestamp. Besides that, it's identical to init_stat_ex_from_stat().
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Yan, Zheng [Thu, 19 Mar 2015 01:58:45 +0000 (09:58 +0800)]
vfs_ceph: fix ntimes_fn callback
add null timespec check for atime/mtime. Also add code that stores
create_time by EA.
Signed-off-by: Yan, Zheng <zyan@redhat.com>
Reviewed-by: Michael Adam <obnox@samba.org>
Jelmer Vernooij [Wed, 18 Mar 2015 02:20:02 +0000 (03:20 +0100)]
Update update-external.sh to use mirrors of third party projects on git.samba.org.
Change-Id: Id86c3f5233224d0337efc8e5fefe9a966b0c30fd
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Mar 19 02:50:49 CET 2015 on sn-devel-104
Michael Adam [Wed, 18 Mar 2015 16:41:42 +0000 (17:41 +0100)]
selftet: fix the flapping entry for the drs.delete_object test.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Mar 19 00:09:23 CET 2015 on sn-devel-104
Michael Adam [Wed, 18 Mar 2015 16:41:11 +0000 (17:41 +0100)]
selftest: fix the flapping entry for the tombstone reanimation test
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
David Disseldorp [Thu, 12 Mar 2015 10:01:17 +0000 (11:01 +0100)]
torture/ioctl: add simple FSCTL_FILE_LEVEL_TRIM test
This test writes out a 128K file and then attempts to trim the first
half of the file. Trim support is first detected using an
FS_SECTOR_SIZE_INFORMATION query-info request. If the server doesn't
support trim, then the test is skipped.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar 18 21:32:47 CET 2015 on sn-devel-104
David Disseldorp [Wed, 11 Mar 2015 13:50:16 +0000 (14:50 +0100)]
idl: FSCTL_FILE_LEVEL_TRIM request & response structs
As defined in MS-FSCC 2.3.73 - 2.3.74.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
David Disseldorp [Fri, 13 Mar 2015 00:06:26 +0000 (01:06 +0100)]
torture: test FS_SECTOR_SIZE_INFORMATION queries
The smb2.fsinfo test is run against ntvfs and s3fs. With both now
offering support for the FS_SECTOR_SIZE_INFORMATION query-info level,
it can be added to the existing level enumeration.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
David Disseldorp [Fri, 13 Mar 2015 00:00:51 +0000 (01:00 +0100)]
s4/ntvfs: support FS_SECTOR_SIZE_INFORMATION query-info
Return the same values as used by s3fs.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
David Disseldorp [Thu, 12 Mar 2015 23:46:21 +0000 (00:46 +0100)]
s4/client: add FS_SECTOR_SIZE_INFORMATION query support
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
David Disseldorp [Thu, 12 Mar 2015 23:34:58 +0000 (00:34 +0100)]
s3/smbd: support FS_SECTOR_SIZE_INFORMATION query-info
The FS_SECTOR_SIZE_INFORMATION query-info level reports sector alignment
information for an underlying share volume, as well as NO_SEEK_PENALTY
and TRIM_ENABLED flags useful for SSD / thin-provisioned storage
detection.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
David Disseldorp [Thu, 12 Mar 2015 16:02:56 +0000 (17:02 +0100)]
smbd/trans2: function scope qfsinfo bytes_per_sector
It's needed for multiple info levels.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Stefan Metzmacher [Sun, 15 Mar 2015 21:25:49 +0000 (22:25 +0100)]
s4:kdc: fix realm for outgoing trusts in samba_kdc_trust_message2entry()
This is a regression introduced in commit
8dd37327b02eaea33915a9cd206667981b8df872.
Now we change 'realm' before calling
ret = krb5_principal_set_realm(context, entry_ex->entry.principal, realm);
as before commit
8dd37327b02eaea33915a9cd206667981b8df872.
Without this we'd set entry_ex->entry.principal to
krbtgt/DOMA.EXAMPLE.COM@DOMA.EXAMPLE.COM instead
of krbtgt/DOMA.EXAMPLE.COM@DOMB.EXAMPLE.COM,
while we use krbtgt/DOMA.EXAMPLE.COM@DOMB.EXAMPLE.COM as
salt for the keys.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Mar 18 18:56:51 CET 2015 on sn-devel-104
Michael Adam [Wed, 18 Mar 2015 08:51:02 +0000 (09:51 +0100)]
selftest: the drs.delete_object is currently flakey.
See
https://git.samba.org/autobuild.flakey/2015-03-18-0813/samba.stdout
[1692(11281)/1735 at 1h54m29s] samba4.drs.delete_object.python(promoted_dc)(promoted_dc)
Testing for DrsDelObjUser_1426658948 with GUID
80f07b62-7edd-4175-8e5c-
f44b6081f39c
UNEXPECTED(failure): samba4.drs.delete_object.python(promoted_dc).delete_object.DrsDeleteObjectTestCase.test_ReplicateDeletedObject1(promoted_dc)
REASON: Exception: Exception: Traceback (most recent call last):
File "bin/python/samba/tests/__init__.py", line 113, in run
testMethod()
File "/memdisk/autobuild/fl/b21901/samba/source4/torture/drs/python/delete_object.py", line 214, in test_ReplicateDeletedObject1
self._check_obj(sam_ldb=self.ldb_dc2, obj_orig=user_orig, is_deleted=True)
File "/memdisk/autobuild/fl/b21901/samba/source4/torture/drs/python/delete_object.py", line 82, in _check_obj
self.assertEquals(name_cur, name_orig + "\nDEL:" + guid_str)
AssertionError: 'DrsDelObjUser_1426658948' != 'DrsDelObjUser_1426658948\nDEL:
80f07b62-7edd-4175-8e5c-
f44b6081f39c'
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
There are many more occurrences:
https://git.samba.org/autobuild.flakey/2013-08-02-1537/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-04-1536/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-05-0336/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-09-1141/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-13-1537/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-14-0936/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-14-1736/samba.stdout
https://git.samba.org/autobuild.flakey/2013-08-15-1936/samba.stdout
...
https://git.samba.org/autobuild.flakey/2014-05-01-1707/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-03-1411/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-03-1710/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-04-1710/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-13-0507/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-23-1113/samba.stdout
https://git.samba.org/autobuild.flakey/2014-05-29-0213/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-02-0513/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-08-1713/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-09-0512/samba.stdout
https://git.samba.org/autobuild.flakey/2014-06-14-0214/samba.stdout
...
https://git.samba.org/autobuild.flakey/2015-03-02-0213/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-02-0813/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-03-0513/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-04-0811/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-07-1113/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-07-1713/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-08-2013/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-09-0813/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-09-2008/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-12-0807/samba.stdout
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Mar 18 15:20:57 CET 2015 on sn-devel-104
Michael Adam [Tue, 17 Mar 2015 22:00:03 +0000 (23:00 +0100)]
selftest: the tombstone_reanimation test is currently flakey.
See
https://git.samba.org/autobuild.flakey/2015-03-18-0456/samba.stdout
[1657(10627)/1735 at 1h37m36s] samba4.tombstone_reanimation.python(fl2003dc)
Test Container reanimation
UNEXPECTED(failure): samba4.tombstone_reanimation.python.tombstone_reanimation.RestoreContainerObjectTestCase.test_container(fl2003dc)
REASON: Exception: Exception: Traceback (most recent call last):
File "bin/python/samba/tests/__init__.py", line 113, in run
testMethod()
File "/memdisk/autobuild/fl/b2199/samba/source4/dsdb/tests/python/tombstone_reanimation.py", line 541, in test_container
self.assertAttributesEqual(obj, attr_orig, obj_restore, attr_rest)
File "/memdisk/autobuild/fl/b2199/samba/source4/dsdb/tests/python/tombstone_reanimation.py", line 86, in assertAttributesEqual
self.assertEqual(attrs_orig, attrs_rest, "Actual object does not have expected attributes")
AssertionError: Actual object does not have expected attributes
FAILED (1 failures, 0 errors and 0 unexpected successes in 0 testsuites)
There are more occurrences:
https://git.samba.org/autobuild.flakey/2015-03-17-1952/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-17-1350/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-16-0452/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-16-0156/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-15-1654/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-14-2253/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-14-1400/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-14-0153/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-13-2251/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-13-1059/samba.stdout
https://git.samba.org/autobuild.flakey/2015-03-13-0759/samba.stdout
Note that this fails in all environments it is configured to run in.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Matthew Newton [Tue, 17 Mar 2015 00:56:12 +0000 (00:56 +0000)]
Ensure we always initialise the winbind context
Stops segfault when a context is passed. Internal Samba code will
currently always call this with NULL so won't trigger the bug.
Signed-off-by: Matthew Newton <matthew-git@newtoncomputing.co.uk>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Mar 18 01:41:32 CET 2015 on sn-devel-104
Jeremy Allison [Mon, 16 Mar 2015 19:18:17 +0000 (12:18 -0700)]
lib: talloc: tests - add test_pthread_talloc_passing() testing talloc in a pthread environment.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo <simo@samba.org>
Reviewed-by: "Stefan (metze) Metzmacher" <metze@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Mar 17 19:23:29 CET 2015 on sn-devel-104
Jeremy Allison [Mon, 16 Mar 2015 19:17:40 +0000 (12:17 -0700)]
lib: docs: talloc: Add a threads tutorial and samples showing how to use talloc with threads.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo <simo@samba.org>
Michael Adam [Mon, 16 Mar 2015 17:45:52 +0000 (18:45 +0100)]
dsdb: fix error message in tombstone_reanimation test.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Michael Adam [Mon, 16 Mar 2015 17:40:53 +0000 (18:40 +0100)]
dsdb: fix error message in sam test
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 15:07:54 +0000 (15:07 +0000)]
lib: Remove ccan
The only component, that really used more than tiny bits of ccan was ntdb. Now
that ntdb is gone, ccan is not required anymore either.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Mar 17 14:06:15 CET 2015 on sn-devel-104
Volker Lendecke [Thu, 12 Mar 2015 15:07:38 +0000 (15:07 +0000)]
texpect: Do not depend on ccan
texpect is the only remaining user of ccan code. Copy in the two routines
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 15:03:22 +0000 (15:03 +0000)]
source3: Remove ccan-hash dependency
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 15:00:58 +0000 (15:00 +0000)]
source3: Replace ccan hash calls with tdb_jenkins_hash
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 14:50:01 +0000 (14:50 +0000)]
smbd: Remove an unused #include
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 14:40:16 +0000 (14:40 +0000)]
lib: Remove tdb_compat
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 14:23:17 +0000 (14:23 +0000)]
lib: Remove tdb_fetch_compat
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 14:19:02 +0000 (14:19 +0000)]
lib: Remove tdb_errorstr_compat
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 14:14:24 +0000 (14:14 +0000)]
Remove tdb_[first|next]key_compat
This is essentially a revert of
3a8faefd.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:56:09 +0000 (13:56 +0000)]
lib: Remove tdb_open_compat
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:17:15 +0000 (13:17 +0000)]
lib: Remove ntdb
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:16:49 +0000 (13:16 +0000)]
waf: Do not recurse into ntdb
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:40:43 +0000 (13:40 +0000)]
dbwrap: Remove a ntdb reference
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:39:40 +0000 (13:39 +0000)]
Remove ntdb protection from db_open_tdb
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:39:12 +0000 (13:39 +0000)]
Remove ntdb protection from tdb_wrap
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:34:15 +0000 (13:34 +0000)]
Docs: Remove some ntdb references
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:27:49 +0000 (13:27 +0000)]
python: Remove ntdb references
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:25:38 +0000 (13:25 +0000)]
autobuild: Remove ntdb target
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:18:34 +0000 (13:18 +0000)]
Remove ntdb from scripts
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:10:12 +0000 (13:10 +0000)]
param: Remove "use ntdb" reference
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:09:01 +0000 (13:09 +0000)]
Revert "Samba3-HOWTO: mention NTDB."
This reverts commit
c5bd2ae338c0b67304ee253e3b5139b50cc1d0e5.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:07:31 +0000 (13:07 +0000)]
param: Remove "use ntdb"
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:05:25 +0000 (13:05 +0000)]
lib: Remove unused util_ntdb.[ch]
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 13:03:07 +0000 (13:03 +0000)]
dbwrap: Remove dbwrap_ntdb
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 12:57:33 +0000 (12:57 +0000)]
dbwrap: Remove ntdb logic from dbwrap_local_open
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 12:45:12 +0000 (12:45 +0000)]
lib: Remove "use_ntdb" param from secrets_init_path
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Thu, 12 Mar 2015 12:39:37 +0000 (12:39 +0000)]
Remove callers of lp_use_ntdb
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Fri, 13 Mar 2015 14:34:36 +0000 (14:34 +0000)]
samdb: Ignore ntdb in secrets_tdb_sync
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 16 Mar 2015 06:45:28 +0000 (07:45 +0100)]
passdb: Fix the O3 developer build
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Mar 17 11:29:38 CET 2015 on sn-devel-104
Andrew Bartlett [Wed, 18 Feb 2015 23:41:34 +0000 (12:41 +1300)]
lib/util: Make ECHILD in samba_runcmd_io_handler an error
We now print out a nasty message and set and error if we get ECHILD,
as we no longer set SIGIGN on SIGCHLD in the standard process model.
This was why samba_kcc was able to fail totally without us noticing.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Mar 17 07:05:43 CET 2015 on sn-devel-104
Andrew Bartlett [Wed, 18 Feb 2015 23:45:31 +0000 (12:45 +1300)]
s4-process_standard: Remove signal(SIGCHLD, SIG_IGN)
We replace this with a pipe between parent and child, and then watch
for a read event in the parent to indicate that the child has gone away.
The removal of signal(SIGCHLD, SIG_IGN) requires us to then call
waitpid(). We can't do that in a main loop as we want to get the exit
status to the legitimate waitpid calls in routines like
samba_runcmd_*().
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Fri, 6 Mar 2015 09:01:33 +0000 (10:01 +0100)]
selftest: rename env member to nt4_member
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Mar 17 01:46:18 CET 2015 on sn-devel-104
Michael Adam [Fri, 6 Mar 2015 08:39:54 +0000 (09:39 +0100)]
selftest: rename env s3dc_schannel to nt4_dc_schannel
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Fri, 6 Mar 2015 08:34:11 +0000 (09:34 +0100)]
selftest: rename env s3dc to nt4_dc
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Thu, 5 Mar 2015 23:58:45 +0000 (00:58 +0100)]
selftest: rename env s3member_rfc2307 to ad_member_rfc2307
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Thu, 5 Mar 2015 22:46:14 +0000 (23:46 +0100)]
selftest: rename env s3member to ad_member.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Thu, 5 Mar 2015 22:38:26 +0000 (23:38 +0100)]
selftest: rename env dc to ad_dc_ntvfs
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Thu, 5 Mar 2015 17:08:43 +0000 (18:08 +0100)]
selftest: rename env plugin_s4_dc to ad_dc
This is the environment that represents our supported production
setup of an active directory domain controller.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 16 Mar 2015 09:37:35 +0000 (10:37 +0100)]
selftest: make blackbox.pkinit test independent of test environment.
This lets the test not clutter the main selftest prefix directory
with temporary data.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 16 Mar 2015 09:34:37 +0000 (10:34 +0100)]
selftest: make blackbox.ktpass test independent of test environment.
This also prevents the test from cluttering the main
selftest prefix directory with temporary data.
Note: this test is currently skipped but it should
be adapted because of the environment renames anyways.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 16 Mar 2015 09:27:56 +0000 (10:27 +0100)]
selftest: make blackbox.passwords test independent of test environment.
This also prevents the test from cluttering the main
selftest directort with temporary data.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Mon, 16 Mar 2015 09:20:01 +0000 (10:20 +0100)]
selftest:test_kinit: remove commented out line with outdated content.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Michael Adam [Tue, 3 Feb 2015 13:41:27 +0000 (14:41 +0100)]
doc: fix the idmap_script manpage to be named idmap_script
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Mar 16 23:03:34 CET 2015 on sn-devel-104
Michael Adam [Sun, 25 Jan 2015 11:16:50 +0000 (12:16 +0100)]
s3:winbind:grent: don't stop when querying one domain fails.
Just continue with the next domain.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Fri, 23 Jan 2015 13:23:16 +0000 (14:23 +0100)]
s3:winbind:grent: convert wb_next_grent to use wb_query_group_list.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Fri, 23 Jan 2015 13:06:40 +0000 (14:06 +0100)]
s3:winbind: add wb_query_group_list module - async query group list
Modeled after wb_query_user_list.c
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Wed, 21 Jan 2015 11:32:04 +0000 (12:32 +0100)]
s3:winbind:grent: refactor duplication into wb_next_grent_send_do()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Tue, 20 Jan 2015 11:25:29 +0000 (12:25 +0100)]
s3:winbind:grent: move resetting next_group up.
This is to make it more obvious that this is a case
of code duplication.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Tue, 20 Jan 2015 09:25:37 +0000 (10:25 +0100)]
s3:winbind:grent: use wb_next_domain() in wb_next_grent.c
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Sun, 25 Jan 2015 11:20:35 +0000 (12:20 +0100)]
s3:winbind:grent: fix a debug message.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Mon, 19 Jan 2015 12:51:39 +0000 (13:51 +0100)]
s3:winbind:pwent: refactor duplication into wb_next_pwent_send_do()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Tue, 20 Jan 2015 10:06:51 +0000 (11:06 +0100)]
s3:winbind:pwent: move resetting next_user up.
This does not change the behaviour and makes it more evident
that we have anothe code duplication here:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
if (state->gstate->num_users == 0) {
...
}
subreq = wb_fill_pwent_send(...)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
is for the current setting of variables equivalent
to the block found elsewhere:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
if (state->gstate->next_user >= state->gstate->num_users) {
...
}
subreq = wb_fill_pwent_send(...)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
because both num_users is set to a non-negative
value and num_users starts at 0 and is incremented up to
num_users.
The code duplication will be factored out next.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Tue, 20 Jan 2015 09:07:59 +0000 (10:07 +0100)]
s3:winbind:pwent: move wb_next_domain() to winbindd_util.c for re-use
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Tue, 20 Jan 2015 08:41:31 +0000 (09:41 +0100)]
s3:winbind:pwent: rename wb_next_find_domain to wb_next_domain
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Sat, 17 Jan 2015 22:34:37 +0000 (23:34 +0100)]
s3:winbind:pwent: use wb_next_find_domain()
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Tue, 20 Jan 2015 07:39:58 +0000 (08:39 +0100)]
s3:winbind:util: fix comment typo
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Mon, 19 Jan 2015 07:14:44 +0000 (08:14 +0100)]
s3:util_sid: donate an empty line.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Mon, 19 Jan 2015 12:51:55 +0000 (13:51 +0100)]
s3:winbind:grent: don't stop group enumeration when a group has no gid
simply continue with the next group
Note: this patch introduces some code duplication to make it
easier to create minimal backport patch. Subsequent patches
will provide some refactoring to reduce the duplication.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=8905
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Michael Adam [Mon, 16 Mar 2015 16:22:01 +0000 (17:22 +0100)]
dsdb: fix the user_account_control test.
On my system (Fedora 21) the test fails with:
[1(0)/1 at 0s] samba4.user_account_control.python(dc)
teardown_env(dc)
Traceback (most recent call last):
File "/home/obnox/devel/samba/master-push.git/source4/dsdb/tests/python/user_account_control.py", line 23, in <module>
from subunit.run import SubunitTestRunner
ImportError: No module named subunit.run
This fixes it for me.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Mar 16 20:25:33 CET 2015 on sn-devel-104
Andreas Schneider [Mon, 16 Mar 2015 16:43:59 +0000 (17:43 +0100)]
selftest: Add missing variable to @exported_envvars
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Martin Schwenke [Fri, 13 Mar 2015 04:00:03 +0000 (15:00 +1100)]
ctdb-tests: Add tests for "ctdb reloadips" and "ctdb recover"
Although much of the test infrastructure in recent commits is actually
targeted for "reloadnodes", it is worthwhile adding some tests for
"reloadips" and "recover". This allows most of the test
infrastructure to be tried out against known good code.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Mar 16 09:18:55 CET 2015 on sn-devel-104
Martin Schwenke [Sat, 7 Feb 2015 21:16:47 +0000 (08:16 +1100)]
ctdb-tools: Drop a debug message to DEBUG level
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Wed, 25 Feb 2015 00:41:48 +0000 (11:41 +1100)]
ctdb-tests: Add stub for ctdb_client_async_control()
With support for CTDB_CONTROL_RELOAD_PUBLIC_IPS and
CTDB_CONTROL_RELOAD_NODES_FILE for now.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Wed, 4 Feb 2015 03:57:03 +0000 (14:57 +1100)]
ctdb-tests: Add stub for ctdb_ctrl_reload_nodes_file()
ctdb_ctrl_reload_nodes_file_stub() does nothing except print a helpful
message. That's enough to help test the tool. It could update the
nodemap but that would not be incredibly useful.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Sat, 7 Feb 2015 21:07:56 +0000 (08:07 +1100)]
ctdb-tests: Add stubs for some CTDB client messaging functions
Stub for ctdb_client_send_message() only implements
CTDB_SRVID_TAKEOVER_RUN and CTDB_SRVID_DISABLE_TAKEOVER_RUNS. It
assumes srvid_broadcast() is in use and just calls handler to fake
appropriate replies.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Sat, 7 Feb 2015 21:14:41 +0000 (08:14 +1100)]
ctdb-tests: Test stub fixes
Initialise ctdb->ev in ctdb_cmdline_client_stub().
Add a comment to tevent_context_init_stub() explaining why the ctdb
context is initialised there instead of ctdb_cmdline_client_stub().
This information is in the git log but that doesn't help someone who
is reading the code.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Mon, 9 Feb 2015 06:04:30 +0000 (17:04 +1100)]
ctdb-tests: Handle deleted nodes when loading fake nodemap
The daemon uses an IP address of "0.0.0.0" when handling deleted
nodes. Do the same in the tests when loading a fake nodemap.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Wed, 4 Feb 2015 03:56:17 +0000 (14:56 +1100)]
ctdb-tests: Support CTDB_DEBUGLEVEL in tool tests
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Mon, 9 Feb 2015 10:55:59 +0000 (21:55 +1100)]
ctdb-tests: Add ctdb_ctrl_setrecmode() stub
If recovery mode is set to active then it updates the generation and
immediately sets recovery mode back to normal.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Martin Schwenke [Wed, 26 Mar 2014 05:50:59 +0000 (16:50 +1100)]
ctdb-eventscripts: Make 11.natgw stateful
IP addresses and routes are only changed if either the NAT gateway
configuration or the NAT gateway master node has changed. If running
"ip monitor" this will minimise the amount of noise seen. It should
also be more lightweight at the expense of managing a couple of state
files.
Add a test to check that configuration changes behave correctly.
Tweak the static route result generation code so that the required
output is sorted.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Andrew Bartlett [Sun, 15 Mar 2015 22:26:16 +0000 (11:26 +1300)]
Do not use popt_common.h in dlz_bind9
We do not use popt_common structures here
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Andrew Bartlett [Sun, 1 Mar 2015 07:04:00 +0000 (20:04 +1300)]
param: Use IDL-based constants for NBT and NBT dgram ports
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Mar 16 05:35:56 CET 2015 on sn-devel-104
Andrew Bartlett [Sun, 1 Mar 2015 07:00:05 +0000 (20:00 +1300)]
smb.conf.5: Mark "dgram port" and "nbt port" as deprecated
These are not honored in the source3 codebase, so keeping them is confusing.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11126
Andrew Bartlett [Fri, 20 Feb 2015 04:54:32 +0000 (17:54 +1300)]
samba-tool drs: Ensure we do not replicate all secrets to an RODC, even with --local
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Sun, 22 Feb 2015 22:52:58 +0000 (11:52 +1300)]
torture3: Rename LOCAL-WBCLIENT to WBCLIENT-MULTI-PING
This is not a local test, it should not be named LOCAL-*
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Sun, 22 Feb 2015 22:49:29 +0000 (11:49 +1300)]
selftest: Run LOCAL-WBCLIENT against a test environment, not none
The issue with this test was that it ran against whatever was
listening (or not) at the build prefix, not what was running under
make test
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Fri, 20 Feb 2015 04:55:49 +0000 (17:55 +1300)]
dsdb-repl: Always set DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING when we are an RODC
Unless we are using DRSUAPI_EXOP_REPL_SECRET, always remove
DRSUAPI_DRS_WRIT_REP and always set
DRSUAPI_DRS_SPECIAL_SECRET_PROCESSING
Otherwise, we will not work as an RODC, because replication will fail
with access denied errors.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Thu, 19 Feb 2015 01:44:00 +0000 (14:44 +1300)]
s4-process_model: Remove prefork and onefork
While it is possible to run Samba in these modes, it isn't tested and
isn't required.
Each of these modes requires that SIGCHLD be set to SIGIGN, and that
breaks samba_runcmd_*().
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Tue, 17 Feb 2015 02:47:47 +0000 (15:47 +1300)]
selftest: Fix comments in provision_promoted_dc
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
Andrew Bartlett [Mon, 2 Mar 2015 00:58:21 +0000 (13:58 +1300)]
pygensec: Add bindings for gensec_set_target_service and gensec_set_target_hostname
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jelmer Vernooij <jelmer@samba.org>
git.samba.org / obnox / samba / samba-obnox.git / log