obnox/samba/samba-obnox.git
9 years agoRevert "assert num_fds == 0" master3-multichannel
Michael Adam [Wed, 25 Jun 2014 11:41:57 +0000 (13:41 +0200)]
Revert "assert num_fds == 0"

This reverts commit 578a059d4fa5be0c41509a9e3fbfb518af9083bc.

9 years agoassert num_fds == 0
Michael Adam [Wed, 25 Jun 2014 11:41:47 +0000 (13:41 +0200)]
assert num_fds == 0

9 years agobla .. DOOFE commit message ;)
Michael Adam [Wed, 25 Jun 2014 11:30:59 +0000 (13:30 +0200)]
bla .. DOOFE commit message ;)

9 years agoREAL CONNECTION
Michael Adam [Wed, 25 Jun 2014 08:37:57 +0000 (10:37 +0200)]
REAL CONNECTION
PASSING!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

9 years agodebug session lookup
Stefan Metzmacher [Wed, 25 Jun 2014 07:55:24 +0000 (09:55 +0200)]
debug session lookup

9 years agolookup_raw
Stefan Metzmacher [Wed, 25 Jun 2014 07:54:58 +0000 (09:54 +0200)]
lookup_raw

9 years agopass_loop
Stefan Metzmacher [Wed, 25 Jun 2014 07:54:33 +0000 (09:54 +0200)]
pass_loop

9 years agoRevert "HACK bind on existing connection REQUEST_NOT_ACCEPTED..."
Stefan Metzmacher [Wed, 25 Jun 2014 07:05:43 +0000 (09:05 +0200)]
Revert "HACK bind on existing connection REQUEST_NOT_ACCEPTED..."

This reverts commit 88f82b3849434a4c692c499ea19452c6f7835465.

9 years agoCONNECTION PASSING !!!!!!
Stefan Metzmacher [Wed, 25 Jun 2014 07:05:07 +0000 (09:05 +0200)]
CONNECTION PASSING !!!!!!

9 years agoHACK bind on existing connection REQUEST_NOT_ACCEPTED...
Stefan Metzmacher [Tue, 24 Jun 2014 18:20:57 +0000 (20:20 +0200)]
HACK bind on existing connection REQUEST_NOT_ACCEPTED...

9 years agosmb2_sesssetup...
Stefan Metzmacher [Tue, 24 Jun 2014 18:20:39 +0000 (20:20 +0200)]
smb2_sesssetup...

9 years agoonly smb2.session.bind1
Stefan Metzmacher [Tue, 24 Jun 2014 18:05:09 +0000 (20:05 +0200)]
only smb2.session.bind1

9 years agosq pass_loop
Stefan Metzmacher [Tue, 24 Jun 2014 18:03:11 +0000 (20:03 +0200)]
sq pass_loop

9 years agofirst_negprot talloc_memdup
Stefan Metzmacher [Tue, 24 Jun 2014 18:02:53 +0000 (20:02 +0200)]
first_negprot talloc_memdup

9 years agoHACK accept unix sockets...
Stefan Metzmacher [Tue, 24 Jun 2014 18:02:25 +0000 (20:02 +0200)]
HACK accept unix sockets...

9 years agosq DLIST
Stefan Metzmacher [Tue, 24 Jun 2014 17:42:11 +0000 (19:42 +0200)]
sq DLIST

9 years agoaccept smbXsrv_connection passing...
Stefan Metzmacher [Tue, 24 Jun 2014 17:39:53 +0000 (19:39 +0200)]
accept smbXsrv_connection passing...

9 years agosq use add_connection
Stefan Metzmacher [Tue, 24 Jun 2014 17:37:48 +0000 (19:37 +0200)]
sq use add_connection

9 years agosq add_connection
Stefan Metzmacher [Tue, 24 Jun 2014 17:37:27 +0000 (19:37 +0200)]
sq add_connection

9 years agosock_fd filtered_read ...
Stefan Metzmacher [Tue, 24 Jun 2014 17:30:47 +0000 (19:30 +0200)]
sock_fd filtered_read ...

9 years agoTODO: DLIST connections TODO remove...
Stefan Metzmacher [Tue, 24 Jun 2014 17:29:35 +0000 (19:29 +0200)]
TODO: DLIST connections TODO remove...

9 years agoremove NBT_HDR_SIZE from first_negprot
Stefan Metzmacher [Tue, 24 Jun 2014 17:28:51 +0000 (19:28 +0200)]
remove NBT_HDR_SIZE from first_negprot

9 years agonum_fds64...
Stefan Metzmacher [Tue, 24 Jun 2014 17:27:54 +0000 (19:27 +0200)]
num_fds64...

9 years agodebug messaging recv
Stefan Metzmacher [Tue, 24 Jun 2014 17:27:32 +0000 (19:27 +0200)]
debug messaging recv

9 years agofix dispatch fd passing
Stefan Metzmacher [Tue, 24 Jun 2014 17:26:51 +0000 (19:26 +0200)]
fix dispatch fd passing

9 years agomessaging_dgm_recv fds64
Stefan Metzmacher [Tue, 24 Jun 2014 16:15:01 +0000 (18:15 +0200)]
messaging_dgm_recv fds64

9 years agofix exit_server_common
Stefan Metzmacher [Tue, 24 Jun 2014 16:39:29 +0000 (18:39 +0200)]
fix exit_server_common

9 years agofix unix_dgram_send
Stefan Metzmacher [Tue, 24 Jun 2014 16:39:14 +0000 (18:39 +0200)]
fix unix_dgram_send

9 years agoRevert "messaging_dgm_recv fds64"
Stefan Metzmacher [Tue, 24 Jun 2014 16:15:25 +0000 (18:15 +0200)]
Revert "messaging_dgm_recv fds64"

This reverts commit 7ffedafc33f396d6f80767dc52e9f25199865f94.

9 years agomessaging_dgm_recv fds64
Stefan Metzmacher [Tue, 24 Jun 2014 16:15:01 +0000 (18:15 +0200)]
messaging_dgm_recv fds64

9 years agodebug messaging_dgm_send/recv
Stefan Metzmacher [Tue, 24 Jun 2014 16:14:34 +0000 (18:14 +0200)]
debug messaging_dgm_send/recv

9 years agorec_dup debug
Stefan Metzmacher [Tue, 24 Jun 2014 16:13:00 +0000 (18:13 +0200)]
rec_dup debug

9 years agoexit_common no panic
Stefan Metzmacher [Tue, 24 Jun 2014 16:12:41 +0000 (18:12 +0200)]
exit_common no panic

9 years agodebug filter_pass
Stefan Metzmacher [Tue, 24 Jun 2014 16:12:23 +0000 (18:12 +0200)]
debug filter_pass

9 years agouse smbXsrv_client_update for >= smb2.1
Stefan Metzmacher [Tue, 24 Jun 2014 16:10:51 +0000 (18:10 +0200)]
use smbXsrv_client_update for >= smb2.1

9 years agoconnection_pass pass sock...
Stefan Metzmacher [Tue, 24 Jun 2014 16:08:08 +0000 (18:08 +0200)]
connection_pass pass sock...

9 years agoRevert "always zero guid"
Stefan Metzmacher [Tue, 24 Jun 2014 15:02:37 +0000 (17:02 +0200)]
Revert "always zero guid"

This reverts commit 9bf0976a096f6f5f0a78ec59559e3891068b558d.

9 years agoalways zero guid
Stefan Metzmacher [Tue, 24 Jun 2014 15:02:27 +0000 (17:02 +0200)]
always zero guid

9 years agodebug...
Stefan Metzmacher [Tue, 24 Jun 2014 15:02:18 +0000 (17:02 +0200)]
debug...

9 years agolookup_raw
Stefan Metzmacher [Tue, 24 Jun 2014 15:01:53 +0000 (17:01 +0200)]
lookup_raw

9 years agofix table_create
Stefan Metzmacher [Tue, 24 Jun 2014 15:01:18 +0000 (17:01 +0200)]
fix table_create

9 years agobla...
Michael Adam [Tue, 24 Jun 2014 14:33:40 +0000 (16:33 +0200)]
bla...

9 years agoglobal->stored
Michael Adam [Tue, 24 Jun 2014 12:46:40 +0000 (14:46 +0200)]
global->stored

9 years agosmbXsrv_connection_init_tables at the end can return NT_STATUS_OBJECTID_EXISTS
Michael Adam [Tue, 24 Jun 2014 11:37:09 +0000 (13:37 +0200)]
smbXsrv_connection_init_tables at the end can return NT_STATUS_OBJECTID_EXISTS
if the connection was passed to a different process

9 years agofix bad conflict handling...
Michael Adam [Tue, 24 Jun 2014 11:36:26 +0000 (13:36 +0200)]
fix bad conflict handling...

9 years agouse smbXsrv_client_create
Michael Adam [Tue, 24 Jun 2014 11:03:05 +0000 (13:03 +0200)]
use smbXsrv_client_create

9 years agobla smbXsrv_client
Stefan Metzmacher [Tue, 24 Jun 2014 10:33:45 +0000 (12:33 +0200)]
bla smbXsrv_client

9 years agobla
Stefan Metzmacher [Tue, 24 Jun 2014 09:09:07 +0000 (11:09 +0200)]
bla

9 years agoMSG_SMBXSRV_CONNECTION_PASS
Stefan Metzmacher [Tue, 24 Jun 2014 05:43:27 +0000 (07:43 +0200)]
MSG_SMBXSRV_CONNECTION_PASS

9 years agosqq messaging_rec *fds
Stefan Metzmacher [Tue, 24 Jun 2014 06:58:42 +0000 (08:58 +0200)]
sqq messaging_rec *fds

9 years agoTODO messaging_dispatch_rec *fds
Stefan Metzmacher [Tue, 24 Jun 2014 06:51:02 +0000 (08:51 +0200)]
TODO messaging_dispatch_rec *fds

9 years agoTODO messaging_rec *fds
Stefan Metzmacher [Tue, 24 Jun 2014 06:50:24 +0000 (08:50 +0200)]
TODO messaging_rec *fds

9 years agomessaging_send_iov fd-passing only local process
Stefan Metzmacher [Tue, 24 Jun 2014 06:48:48 +0000 (08:48 +0200)]
messaging_send_iov fd-passing only local process

9 years agoRevert "messaging fds..."
Stefan Metzmacher [Tue, 24 Jun 2014 06:47:19 +0000 (08:47 +0200)]
Revert "messaging fds..."

This reverts commit d0281d1d835df6de211fc5f9d48186eecb3197b2.

9 years agomessaging fds...
Stefan Metzmacher [Tue, 24 Jun 2014 05:39:05 +0000 (07:39 +0200)]
messaging fds...

9 years agoCMSG_DATA void
Stefan Metzmacher [Tue, 24 Jun 2014 04:56:26 +0000 (06:56 +0200)]
CMSG_DATA void

9 years agoTODO: recv_callback part1
Stefan Metzmacher [Mon, 23 Jun 2014 15:16:32 +0000 (17:16 +0200)]
TODO: recv_callback part1

9 years agoRevert "TODO doesn't pass tests??? libcli: use LOCK_ORDER_1 for schannel_store.tdb"
Stefan Metzmacher [Thu, 6 Feb 2014 05:56:46 +0000 (06:56 +0100)]
Revert "TODO doesn't pass tests??? libcli: use LOCK_ORDER_1 for schannel_store.tdb"

This reverts commit 0af53545ddeeba4bef6bb8e474e96c397f3b9511.

9 years agoTODO doesn't pass tests??? libcli: use LOCK_ORDER_1 for schannel_store.tdb
Michael Adam [Tue, 28 Jan 2014 12:03:26 +0000 (13:03 +0100)]
TODO doesn't pass tests??? libcli: use LOCK_ORDER_1 for schannel_store.tdb

I.e. don't allow any other simultaneous locks.

Signed-off-by: Michael Adam <obnox@samba.org>
9 years agoWIP(incomplete) s3:messaging: read fds from recvmsg in unix_dgram_recv_handler()
Stefan Metzmacher [Mon, 23 Jun 2014 14:47:24 +0000 (16:47 +0200)]
WIP(incomplete) s3:messaging: read fds from recvmsg in unix_dgram_recv_handler()

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

TODO MSG_CMSG_CLOEXEC...

9 years agos3:messaging: add fds-array to messaging_send_iov()
Michael Adam [Sat, 17 May 2014 13:19:18 +0000 (15:19 +0200)]
s3:messaging: add fds-array to messaging_send_iov()

Signed-off-by: Michael Adam <obnox@samba.org>
9 years agoTODO/TEST s3:messaging: add fds-array to message-backend send function
Michael Adam [Sat, 17 May 2014 13:16:02 +0000 (15:16 +0200)]
TODO/TEST s3:messaging: add fds-array to message-backend send function

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

Signed-off-by: Michael Adam <obnox@samba.org>
9 years agosq TODO(check...)
Stefan Metzmacher [Tue, 24 Jun 2014 05:56:03 +0000 (07:56 +0200)]
sq TODO(check...)

9 years agos3:messaging: hand fds-array to unix_msg_send() for fd passing
Michael Adam [Sat, 17 May 2014 22:22:55 +0000 (00:22 +0200)]
s3:messaging: hand fds-array to unix_msg_send() for fd passing

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

9 years agoTODO(max-check?) s3:messaging: add fds-array to unix_dgram_send() for fd-passing
Michael Adam [Sat, 17 May 2014 22:22:19 +0000 (00:22 +0200)]
TODO(max-check?) s3:messaging: add fds-array to unix_dgram_send() for fd-passing

//TODO: dup() all fds... on queue

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>

9 years agosmbXsrv_client ...
Stefan Metzmacher [Tue, 24 Jun 2014 07:39:09 +0000 (09:39 +0200)]
smbXsrv_client ...

9 years agosmbXsrv_client
Stefan Metzmacher [Tue, 24 Jun 2014 06:13:43 +0000 (08:13 +0200)]
smbXsrv_client

9 years agos4:torture/smb2: add smb2.session.bind1
Stefan Metzmacher [Tue, 24 Jun 2014 04:40:29 +0000 (06:40 +0200)]
s4:torture/smb2: add smb2.session.bind1

This is a very simple multi-channel test

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos4:libcli/smb2: add smb2_session_channel()
Stefan Metzmacher [Mon, 23 Jun 2014 22:22:30 +0000 (00:22 +0200)]
s4:libcli/smb2: add smb2_session_channel()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agosource3/smbd/smbXsrv_client.c...
Stefan Metzmacher [Mon, 23 Jun 2014 15:17:06 +0000 (17:17 +0200)]
source3/smbd/smbXsrv_client.c...

9 years agosource3/smbd/smbXsrv_client.c
Stefan Metzmacher [Mon, 23 Jun 2014 10:29:15 +0000 (12:29 +0200)]
source3/smbd/smbXsrv_client.c

9 years agosmbXsrv_client_global...
Stefan Metzmacher [Mon, 23 Jun 2014 10:17:04 +0000 (12:17 +0200)]
smbXsrv_client_global...

9 years agoRevert "hacks..."
Stefan Metzmacher [Mon, 23 Jun 2014 09:40:53 +0000 (11:40 +0200)]
Revert "hacks..."

This reverts commit 967ec1409328c39450a6d3f54b287830cccca0f9.

9 years agohacks...
Stefan Metzmacher [Mon, 23 Jun 2014 09:35:29 +0000 (11:35 +0200)]
hacks...

9 years agouse cli_state_client_guid in run_smb2_multi_channel()
Stefan Metzmacher [Thu, 19 Jun 2014 23:03:38 +0000 (01:03 +0200)]
use cli_state_client_guid in run_smb2_multi_channel()

9 years agoHACK/TODO: add cli_state_client_guid
Stefan Metzmacher [Thu, 19 Jun 2014 23:03:08 +0000 (01:03 +0200)]
HACK/TODO: add cli_state_client_guid

9 years agouse smbd_add_connection()
Stefan Metzmacher [Thu, 19 Jun 2014 22:51:54 +0000 (00:51 +0200)]
use smbd_add_connection()

9 years agosmbd_add_connection()
Stefan Metzmacher [Thu, 19 Jun 2014 22:31:31 +0000 (00:31 +0200)]
smbd_add_connection()

9 years agoselftest/Samba4: also bind to ipv6
Stefan Metzmacher [Thu, 19 Jun 2014 15:21:16 +0000 (17:21 +0200)]
selftest/Samba4: also bind to ipv6

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agotorture: Add FSCTL_QUERY_NETWORK_INTERFACE_INFO torture test case to
Anubhav Rakshit [Wed, 18 Jun 2014 16:34:14 +0000 (22:04 +0530)]
torture: Add FSCTL_QUERY_NETWORK_INTERFACE_INFO torture test case to
source4/torture/smb2/ioctl.c

Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
9 years agolibrpc: Add NETWORK_INTERFACE_INFO IDL data structure --- fix fsctl_sockaddr_* alignm...
Stefan Metzmacher [Thu, 19 Jun 2014 15:42:08 +0000 (17:42 +0200)]
librpc: Add NETWORK_INTERFACE_INFO IDL data structure --- fix fsctl_sockaddr_* alignment and bigendian...

9 years agoTODO/HACK; SMB2_OP_NEGPROT allowed_flags ...
Stefan Metzmacher [Wed, 18 Jun 2014 14:34:01 +0000 (16:34 +0200)]
TODO/HACK; SMB2_OP_NEGPROT allowed_flags ...

9 years agoTODO: server fsctl_network_iface_info all interfaces...
Stefan Metzmacher [Fri, 13 Jun 2014 15:42:00 +0000 (17:42 +0200)]
TODO: server fsctl_network_iface_info all interfaces...

9 years agoTODO: server fsctl_network_iface_info
Stefan Metzmacher [Fri, 13 Jun 2014 15:42:00 +0000 (17:42 +0200)]
TODO: server fsctl_network_iface_info

9 years agolibrpc: Add NETWORK_INTERFACE_INFO IDL data structure
Anubhav Rakshit [Mon, 16 Jun 2014 10:00:18 +0000 (15:30 +0530)]
librpc: Add NETWORK_INTERFACE_INFO IDL data structure

This is in preparation for adding NETWORK_INTERFACE_INFO Ioctl smbtorture test
case. This data structure is described in MS-SMB2 Sec. 2.2.32.5

Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Anubhav Rakshit <anubhav.rakshit@gmail.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agoHACK fix...
Stefan Metzmacher [Fri, 13 Jun 2014 00:10:12 +0000 (02:10 +0200)]
HACK fix...

9 years agoTODO: s3:smb2_negprot: announce multi channel support (default: no)
Stefan Metzmacher [Thu, 12 Jun 2014 23:56:51 +0000 (01:56 +0200)]
TODO: s3:smb2_negprot: announce multi channel support (default: no)

add "smbd:announce multi channel" option (default: false)

9 years agos3:smb2_negprot: allow "smb max {read,write,trans}" up to 8MiB (as default)
Stefan Metzmacher [Thu, 12 Jun 2014 23:55:21 +0000 (01:55 +0200)]
s3:smb2_negprot: allow "smb max {read,write,trans}" up to 8MiB (as default)

This matches Windows 2012R2.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agoTODO smb2_tcon: add some share flags/capabilities options (Default:off)
Stefan Metzmacher [Tue, 31 Jul 2012 06:55:20 +0000 (08:55 +0200)]
TODO smb2_tcon: add some share flags/capabilities options (Default:off)

9 years agoTODO: s3:smb2_negprot: announce persistent handle support (default: no)
Stefan Metzmacher [Thu, 26 Jul 2012 00:49:16 +0000 (02:49 +0200)]
TODO: s3:smb2_negprot: announce persistent handle support (default: no)

add "smbd:announce persistent handles" option (default: false)

metze

9 years agoRevert "HACK debug replay/channel_sequence"
Stefan Metzmacher [Sat, 22 Sep 2012 19:52:13 +0000 (21:52 +0200)]
Revert "HACK debug replay/channel_sequence"

This reverts commit 46ce191a9bf9321251ea601a9b3ba7b48c5d5ccb.

9 years agoRevert "HACK disconnect after 2 writes"
Stefan Metzmacher [Thu, 26 Jul 2012 06:23:33 +0000 (08:23 +0200)]
Revert "HACK disconnect after 2 writes"

This reverts commit eaa7023f865be73483a99ff203d1dbfb3e180ef9.

9 years agoHACK disconnect after 2 writes
Stefan Metzmacher [Thu, 26 Jul 2012 06:23:10 +0000 (08:23 +0200)]
HACK disconnect after 2 writes

9 years agoHACK debug replay/channel_sequence
Stefan Metzmacher [Thu, 26 Jul 2012 06:22:01 +0000 (08:22 +0200)]
HACK debug replay/channel_sequence

9 years agoTODO implement REPLAY and channel_sequence checks
Stefan Metzmacher [Tue, 7 Aug 2012 08:11:29 +0000 (10:11 +0200)]
TODO implement REPLAY and channel_sequence checks

metze

9 years agoTODO s3:smb2_lock: implement lock_sequence replay detection
Stefan Metzmacher [Wed, 24 Oct 2012 13:55:20 +0000 (15:55 +0200)]
TODO s3:smb2_lock: implement lock_sequence replay detection

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
9 years agos3:smb2_lock: pass in_lock_sequence to smbd_smb2_lock_send()
Stefan Metzmacher [Wed, 24 Oct 2012 12:53:05 +0000 (14:53 +0200)]
s3:smb2_lock: pass in_lock_sequence to smbd_smb2_lock_send()

Take the value from the client if the dialect is SMB2_10 or higher,
otherwise default to 0.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agos3:smbXsrv_open: initialize smbXsrv_open_global->lock_sequence_array with 0xFF
Stefan Metzmacher [Wed, 24 Oct 2012 13:17:56 +0000 (15:17 +0200)]
s3:smbXsrv_open: initialize smbXsrv_open_global->lock_sequence_array with 0xFF

This does not match the current documentation, but is very likely the
right thing to do.

If we would match the documentation and initialize with 0x00,
we would return STATUS_SUCCESS without doing any locks.
If the client also follows the documentation and starts
with a lock_sequence of 0 for the first operation.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
9 years agos3:smbXsrv.idl: add lock_sequence_array to smbXsrv_open_global0
Stefan Metzmacher [Wed, 24 Oct 2012 13:06:54 +0000 (15:06 +0200)]
s3:smbXsrv.idl: add lock_sequence_array to smbXsrv_open_global0

This is needed for lock replay detection.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
9 years agomore ...TODO smb2srv_session_lookup_raw
Stefan Metzmacher [Thu, 12 Jun 2014 11:17:15 +0000 (13:17 +0200)]
more ...TODO smb2srv_session_lookup_raw

Conflicts:

source3/smbd/smbXsrv_session.c