Michael Adam [Thu, 21 Jan 2010 23:47:42 +0000 (00:47 +0100)]
s4:torture: refactor querying of domain info out into test_QueryDomainInfo2_level()
Used in several places.
(Note: The _level suffix in the function name is just because
test_QueryDomainInfo2() already exists as an overall test for all levels.)
Michael
Michael Adam [Thu, 21 Jan 2010 23:46:19 +0000 (00:46 +0100)]
s4:torture: create new test_SetDomainInfo_ntstatus()
for checking for SetDomainInfo giving a desired return code.
Michael
Michael Adam [Thu, 21 Jan 2010 23:21:29 +0000 (00:21 +0100)]
s4:torture: refactor setting of domain inf out into test_SetDomainInfo()
and use it in several places.
Michael
Michael Adam [Thu, 21 Jan 2010 22:55:51 +0000 (23:55 +0100)]
s4:torture: refactor setting account flags out into test_SetUserInfo_acct_flags()
and use this in four places (enabling/disabling accounts).
Michael
Michael Adam [Wed, 20 Jan 2010 16:54:40 +0000 (17:54 +0100)]
s4:rpc-server:samr: fix setting of lockout duration < lockout window
This should return NT_STATUS_INVALID_PARAMETER.
This makes samba pass the first part of the samr-lockout test.
This constraint is documented here for the samr server:
http://msdn.microsoft.com/en-us/library/
cc245667%28PROT.10%29.aspx
MS-SAMR 3.1.1.6 Attribute Constraints for Originating Updates
and here for the ldap backend:
http://msdn.microsoft.com/en-us/library/
cc223462(PROT.10).aspx
MS-ADTS 3.1.1.5.3.2 Constraints
So the check should actually be moved down into the backend,
i.e. under dsdb/samdb/ldb_modules - TODO..
Michael
Volker Lendecke [Thu, 21 Jan 2010 11:57:07 +0000 (12:57 +0100)]
s3: Move "yesno" to the only place where it is used: client.c
Björn Jacke [Thu, 21 Jan 2010 08:25:43 +0000 (09:25 +0100)]
s3/doc: update vfs_shadow_copy2 man page according to new options
Ed Plese [Mon, 7 Dec 2009 03:03:06 +0000 (21:03 -0600)]
Add localtime parameter to shadow_copy2.
Ed Plese [Thu, 21 Jan 2010 07:30:01 +0000 (08:30 +0100)]
Add format parameter to shadow_copy2.
Ed Plese [Mon, 7 Dec 2009 03:00:00 +0000 (21:00 -0600)]
Add sort parameter to shadow_copy2.
Jelmer Vernooij [Thu, 21 Jan 2010 04:17:02 +0000 (17:17 +1300)]
pyxattr: Factor out helper functions.
Jelmer Vernooij [Thu, 21 Jan 2010 04:16:19 +0000 (17:16 +1300)]
selftest: Cope with 'multipart' support in subunit.
Jelmer Vernooij [Thu, 21 Jan 2010 03:56:23 +0000 (16:56 +1300)]
pyxattr: Simplify tests.
Jelmer Vernooij [Thu, 21 Jan 2010 03:45:06 +0000 (16:45 +1300)]
pyxattr: Fix tests by not opening tdb files multiple times.
Jelmer Vernooij [Thu, 21 Jan 2010 03:44:20 +0000 (16:44 +1300)]
pyxattr: Fix tests by avoiding opening tdb files multiple times.
Jelmer Vernooij [Thu, 21 Jan 2010 03:44:12 +0000 (16:44 +1300)]
pyxattr: Fix memory leaks.
Jelmer Vernooij [Thu, 21 Jan 2010 03:41:30 +0000 (16:41 +1300)]
pyxattr: Simplify tests.
Jelmer Vernooij [Thu, 21 Jan 2010 03:29:15 +0000 (16:29 +1300)]
pyxattr: Fix return value, raise exception, fix memory leak.
Jelmer Vernooij [Thu, 21 Jan 2010 03:28:24 +0000 (16:28 +1300)]
pyxattr: Use standard functions for error handling.
Jelmer Vernooij [Thu, 21 Jan 2010 03:18:19 +0000 (16:18 +1300)]
pyxattr: Remove unnecessary hacks.
Jelmer Vernooij [Wed, 20 Jan 2010 03:27:38 +0000 (16:27 +1300)]
s4: Fix a few warnings.
Jelmer Vernooij [Wed, 20 Jan 2010 03:27:15 +0000 (16:27 +1300)]
pidl: Include Python.h first, to avoid warnings.
Jelmer Vernooij [Wed, 20 Jan 2010 02:07:09 +0000 (15:07 +1300)]
s4: Include Python.h early to avoid double definition errors.
Björn Jacke [Thu, 21 Jan 2010 00:08:07 +0000 (01:08 +0100)]
s3: fix dnsupdate configure check
Andreas Schneider [Sun, 17 Jan 2010 09:21:21 +0000 (10:21 +0100)]
s4-winbind: Migrated winbind connection to tsocket.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Matthieu Patou [Fri, 15 Jan 2010 11:08:26 +0000 (14:08 +0300)]
selftest-s4: set the posix:eadb at the global level
Matthieu Patou [Tue, 12 Jan 2010 16:49:49 +0000 (19:49 +0300)]
s4-python: add some helper for converting ldb_flag to text
Matthieu Patou [Fri, 15 Jan 2010 11:09:06 +0000 (14:09 +0300)]
upgradeprovision: forbid running upgradeprovision when there is more than 1 DC
Matthieu Patou [Mon, 18 Jan 2010 22:53:01 +0000 (01:53 +0300)]
upgradeprovision: mark rIDAvailablePool never upgraded
handle properly the fact that missing object might depend on some other in order to be correctly created
debug change also if we are in debugall mode
Matthieu Patou [Tue, 12 Jan 2010 12:43:39 +0000 (15:43 +0300)]
upgradeprovision: reformat + add groupType as possibly overwritten
Matthieu Patou [Tue, 12 Jan 2010 16:53:38 +0000 (19:53 +0300)]
upgradeprovision: improve info messages
Matthieu Patou [Tue, 12 Jan 2010 17:13:33 +0000 (20:13 +0300)]
Revert "s4:upgradeprovision - fix up the script regarding linked attributes"
This reverts commit
2cedefabc93c8a1fcb49d65a3f78a344e814f826.
Matthieu Patou [Mon, 18 Jan 2010 22:56:30 +0000 (01:56 +0300)]
upgradeprovision: never use xattr it's pointless in this usecase
Matthieu Patou [Mon, 11 Jan 2010 23:23:13 +0000 (02:23 +0300)]
Add a comment to tdb_wrap to explain why it should be used instead of directly using tdb
Matthieu Patou [Sat, 24 Oct 2009 11:34:31 +0000 (15:34 +0400)]
s4: utils recreate in python setntacl and getntacl
setntacl is able to set NTACL attribute from command line
getntacl now use getopt for parsing command line option and is also able to
dump the acl in the SDDL format.
Matthieu Patou [Sun, 10 Jan 2010 23:19:22 +0000 (02:19 +0300)]
s4: allow python code to dump NTACL object as well
Matthieu Patou [Sun, 17 Jan 2010 19:50:31 +0000 (22:50 +0300)]
provision: use message and do not display warning if the user choosed delibarately posix:eadb
Matthieu Patou [Fri, 8 Jan 2010 14:00:54 +0000 (17:00 +0300)]
provision: introduce use-xattr parameter for defining where to store attributes
This option allow simple user (non root) to invoke provision without facing an error
while insuring that ACL on shared files will always be set
Matthieu Patou [Fri, 8 Jan 2010 10:13:02 +0000 (13:13 +0300)]
s4-tests: register new unit tests
make unit test emit a visible warning
Matthieu Patou [Fri, 8 Jan 2010 10:12:11 +0000 (13:12 +0300)]
s4-python: add unit test for ntacls manipulation in python
Matthieu Patou [Fri, 8 Jan 2010 10:10:30 +0000 (13:10 +0300)]
s4-python: add more unit tests for xattr manipulation in python
Matthieu Patou [Fri, 8 Jan 2010 10:06:47 +0000 (13:06 +0300)]
s4: update setntacl and getntacl to select the adaquate backend (fs/tdb) for storing xattr
Matthieu Patou [Fri, 8 Jan 2010 09:57:59 +0000 (12:57 +0300)]
s4: ntvfs, create push_xattr_blob_tdb_raw and pull_xattr_blob_tdb_raw that do not depend on pvfs objects
Following a talk with tridge on IRC, this patch allow (pull|push)_xattr_blob to be called without
having a pvfs object. It's handy for programs that wants to manipulate xattr directly.
Matthieu Patou [Sun, 22 Nov 2009 17:50:30 +0000 (20:50 +0300)]
s4: Set acls correctly on all sysvol and scripts shares
Matthieu Patou [Sun, 22 Nov 2009 16:50:31 +0000 (19:50 +0300)]
s4: Make unixid optional
Make unixid optional, if value not supplied next id from id pool will be used.
Create a function to get next id in id pool.
Matthieu Patou [Wed, 18 Nov 2009 18:07:25 +0000 (21:07 +0300)]
s4: regroup gpo modification in one function, set acl on files accordingly with ACL in LDAP
Matthieu Patou [Mon, 7 Dec 2009 16:13:00 +0000 (19:13 +0300)]
s4: Create unit tests for python "samba.xattr" module
Matthieu Patou [Mon, 9 Nov 2009 17:53:34 +0000 (20:53 +0300)]
s4: add python bindings for wrap_(s|g)etxattr
Michael Adam [Wed, 20 Jan 2010 15:38:00 +0000 (16:38 +0100)]
s4:selftest: add the samr-passwords-lockout test to knownfail
This is not implemented completely yet.
Needs fixing in the future.
Michael
Michael Adam [Fri, 15 Jan 2010 17:08:57 +0000 (18:08 +0100)]
torture: add new test RPC-SAMR-PASSWORDS-LOCKOUT
This tests account lockout features.
Windows 2003r2 and Windows 2008r2 survice this test.
Note: Windows does not set the ACB_AUTOLOCK account flag when it
locks out an account.
One thing that could/should be added to this test is a check of
the lockout time property.
Michael
Karolin Seeger [Wed, 20 Jan 2010 12:34:50 +0000 (13:34 +0100)]
s3-docs: Fix typos.
Thanks to the Debian samba package maintainers
<pkg-samba-maint@lists.alioth.debian.org> for providing the patch!
Fix bug #7017 (Typos and spelling errors in manpages).
Karolin
Lars Müller [Wed, 20 Jan 2010 11:41:43 +0000 (12:41 +0100)]
Add cross option to samba_cv_linux_getgrouplist_ok
"cross" as an option got removed accidentl with commit
e5a95132 while
moving in direction of 3.2.
Patch proposed by Richard Sharpe <realrichardsharpe@gmail.com>.
Björn Jacke [Tue, 19 Jan 2010 23:09:38 +0000 (00:09 +0100)]
s3: build with dnsupdate support when possible
Jelmer Vernooij [Tue, 19 Jan 2010 22:05:04 +0000 (11:05 +1300)]
selftest: Use SUBUNIT_FORMATTER command, if set in the environment.
Wilco Baan Hofman [Tue, 19 Jan 2010 11:06:01 +0000 (12:06 +0100)]
Fix unintentional free of the last value when adding a new value to a key.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Günther Deschner [Tue, 19 Jan 2010 16:15:05 +0000 (17:15 +0100)]
s4-smbtorture: remove unneeded ncaclrpc dir setup from RPC-SPOOLSS-NOTIFY.
Guenther
Volker Lendecke [Tue, 19 Jan 2010 15:51:33 +0000 (16:51 +0100)]
s3: Fix a typo
Günther Deschner [Tue, 19 Jan 2010 15:22:45 +0000 (16:22 +0100)]
s4-smbtorture: also configure check smbc_setOptionCaseSensitive for LIBSMBCLIENT testsuite.
Guenther
Kai Blin [Tue, 19 Jan 2010 13:48:12 +0000 (14:48 +0100)]
s3 net/i18n: Update .po files
Kai Blin [Tue, 19 Jan 2010 10:43:54 +0000 (11:43 +0100)]
s3 net: Fix compile warnings
Volker Lendecke [Tue, 19 Jan 2010 13:18:53 +0000 (14:18 +0100)]
s3: Remove a comment from ancient times that no longer applies
Günther Deschner [Mon, 18 Jan 2010 23:31:54 +0000 (00:31 +0100)]
s3-selftest: finally enable RPC-SPOOLSS-NOTIFY against s3.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:33:57 +0000 (00:33 +0100)]
s3-spoolss: stricter name checks when opening back-channel notify connection.
Make sure to always check if the name the client passed in
spoolss_RemoteFindFirstPrinterChangeNotifyEx is not one of our names.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:55:48 +0000 (00:55 +0100)]
s3-selftest: use absolute path when setting SOCKET_WRAPPER_DIR.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:27:50 +0000 (00:27 +0100)]
s4-smbtorture: support spoolss_ReplyClosePrinter server call in RPC-SPOOLSS-NOTIFY.
A handle obtained with spoolss_ReplyOpenPrinter will be closed with
spoolss_ReplyClosePrinter when we call spoolss_ClosePrinter on the remote side.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:22:57 +0000 (00:22 +0100)]
s4-smbtorture: restructure spoolss server implementations in RPC-SPOOLSS-NOTIFY.
Guenther
Günther Deschner [Mon, 18 Jan 2010 23:19:47 +0000 (00:19 +0100)]
s4-smbtorture: skip ReplyOpenPrinter test in RPC-SPOOLSS-NOTIFY while testing s3.
Guenther
Günther Deschner [Tue, 19 Jan 2010 13:10:47 +0000 (14:10 +0100)]
s4-smbtorture: strip trailing whitespace.
Guenther
Kai Blin [Tue, 19 Jan 2010 09:06:26 +0000 (10:06 +0100)]
s3 net/i18n: update .po files
Kai Blin [Tue, 19 Jan 2010 08:23:42 +0000 (09:23 +0100)]
s3 net/i18n: Use only one spelling for "Usage:"
Kai Blin [Tue, 19 Jan 2010 08:36:55 +0000 (09:36 +0100)]
s3 net: Fix compile error with WITH_DNS_UPDATES
bd3c922e2bc1a163efc1d8c9cb59578bebb79616 introduced a compile-time error
when building with WITH_DNS_UPDATES.
Björn Jacke [Mon, 18 Jan 2010 22:39:19 +0000 (23:39 +0100)]
s3/net: split up some printable stings to ease i18n
If we put strings like "Usage:" into separate _() macros and not the whole
"Usage:..." string we can cover much more messages by only one single
translation. The drawback is that the message in the sources looks less pretty.
Björn Jacke [Mon, 18 Jan 2010 22:25:41 +0000 (23:25 +0100)]
s3/i18n/de: improve some German translations
Björn Jacke [Mon, 18 Jan 2010 21:07:55 +0000 (22:07 +0100)]
ѕ3/i18n/de: fix typo
Günther Deschner [Fri, 15 Jan 2010 15:36:25 +0000 (16:36 +0100)]
testprogs: add tests for GetPrinterData{Ex} and EnumPrinterDataEx.
Guenther
Günther Deschner [Fri, 15 Jan 2010 15:25:20 +0000 (16:25 +0100)]
testprogs: add tests for GetForm.
Guenther
Günther Deschner [Fri, 15 Jan 2010 15:24:40 +0000 (16:24 +0100)]
testprogs: pass down LPPRINTER_DEFAULTS in spoolss test.
Guenther
Lars Müller [Mon, 18 Jan 2010 10:52:33 +0000 (11:52 +0100)]
Merge branch 'master' of git://git.samba.org/samba
Lars Müller [Mon, 18 Jan 2010 10:49:01 +0000 (11:49 +0100)]
Work around bad use of autoconf interna
Merge fix made by Andreas Schwab <schwab@linux-m68k.org>. This change
had been in use by SUSE since 2008-07-03.
André Hentschel [Thu, 14 Jan 2010 18:49:18 +0000 (19:49 +0100)]
net: Add German translation, specially for the command listing
Signed-off-by: Kai Blin <kai@samba.org>
Olivier Sessink [Mon, 18 Jan 2010 10:40:33 +0000 (11:40 +0100)]
s3-docs: Add man page for vfs_scannedonly.
Fix bug #7028.
Günther Deschner [Mon, 18 Jan 2010 09:59:08 +0000 (10:59 +0100)]
s3-selftest: use testenv dc so that smbtorture4 actually uses the client configuration.
Found while trying to get RPC-SPOOLSS-NOTIFY working against s3.
Guenther
Marcin Gryszkalis [Mon, 18 Jan 2010 09:15:29 +0000 (10:15 +0100)]
s3: Show share path in swat statuspage
Volker Lendecke [Sun, 17 Jan 2010 22:07:39 +0000 (23:07 +0100)]
s3: Fix the format string for smbcontrol pool-usage
With the dot I have seen printf to not print anything
Andrew Tridgell [Sun, 17 Jan 2010 10:59:56 +0000 (21:59 +1100)]
idl: switched to using the WSPP names for the 'neighbour' DRS options
The documentation shows that all these functions in fact use the same
flags variable type. To be consistent between functions, and to allow
easy reference to the WSPP docs, it is better for us to also use this
generic DrsOptions bitfield rather than one per operations.
Volker Lendecke [Tue, 10 Nov 2009 22:14:58 +0000 (23:14 +0100)]
s3: Protect against an invalid bcc in SMBsendtxt
Volker Lendecke [Sun, 17 Jan 2010 13:57:54 +0000 (14:57 +0100)]
s3: For "smbcontrol <pid> pool-usage", print the first 50 bytes of a string
Volker Lendecke [Sun, 17 Jan 2010 12:52:53 +0000 (13:52 +0100)]
s3: Fix some nonempty blank lines
Jeremy Allison [Sun, 17 Jan 2010 01:03:06 +0000 (17:03 -0800)]
Modification of fix for bug 6876 - Delete of an object whose parent folder does not have delete rights fails even if the delete right is set on the object
Suggested by Volker. Reduce the surface area of the
become_root() unbecome_root() code to reduce the chance
of errors.
Jeremy.
Andrew Tridgell [Sat, 16 Jan 2010 19:52:14 +0000 (06:52 +1100)]
s4-drs: allow for security bypass for DsReplicaGetInfo
Use --option=drs:disable_sec_check=true until the group membership bug
with the PAC is fixed.
Andrew Tridgell [Sat, 16 Jan 2010 19:48:09 +0000 (06:48 +1100)]
s4-dsdb: isGlobalCatalogReady should be shown by default
This caused repadmin.exe to crash. Thanks to Hongwei for tracking this
down for us.
Jelmer Vernooij [Sat, 16 Jan 2010 23:35:26 +0000 (12:35 +1300)]
ldap: Fix test failure that seemed to go unreported previously.
Jelmer Vernooij [Sat, 16 Jan 2010 23:26:53 +0000 (12:26 +1300)]
ldap.py: Remove unused imports.
Volker Lendecke [Sat, 16 Jan 2010 12:31:44 +0000 (13:31 +0100)]
s3: Fix a crash in libsmbclient used against the OpenSolaris CIFS server
A user has sent me a sniff where the OpenSolaris CIFS server returns "32" in
totalentries, but the array in ctr only contains 15 entries. Look at the right
delimiter for walking the array.
Kai Blin [Sat, 16 Jan 2010 11:37:30 +0000 (12:37 +0100)]
s4 selftest: Fix and reenable WINBIND-STRUCT.NETBIOS_NAME test
Andrew Tridgell [Sat, 16 Jan 2010 06:57:17 +0000 (17:57 +1100)]
s4-kerberos: raise the general kerberos debug level to 3
level 2 for every krb request is a bit much
Jelmer Vernooij [Sat, 16 Jan 2010 06:56:21 +0000 (19:56 +1300)]
subunit/testtools: Include newer version.
Jelmer Vernooij [Fri, 8 Jan 2010 01:09:20 +0000 (02:09 +0100)]
Import testtools as well, required for subunit.
Jelmer Vernooij [Thu, 31 Dec 2009 17:48:41 +0000 (18:48 +0100)]
subunit: Import new version.
Jelmer Vernooij [Thu, 31 Dec 2009 17:32:17 +0000 (18:32 +0100)]
Add README about subunit.