Karolin Seeger [Wed, 1 Apr 2009 11:42:32 +0000 (13:42 +0200)]
WHATSNEW: Rewording.
Karolin
(cherry picked from commit
c572b19ffcff201f9b8ad0af3bf5434dfe5d06bf)
Karolin Seeger [Wed, 1 Apr 2009 11:32:07 +0000 (13:32 +0200)]
VERSION: Raise version number up to 3.2.10.
Karolin
(cherry picked from commit
887420a30dbb178f29ee9313f2c19dd1b3c3c5e9)
Karolin Seeger [Wed, 1 Apr 2009 11:31:23 +0000 (13:31 +0200)]
WHATSNEW: Prepare WHATSNEW for 3.2.10.
A release a day... ;-)
Karolin
(cherry picked from commit
c9bee29bed290777a4ab32ffe2ed88029a3a6348)
Jeremy Allison [Wed, 1 Apr 2009 01:29:30 +0000 (18:29 -0700)]
Tidy up some convert_string_internal error cases, found by Andrew Bartlett.
Jeremy.
(cherry picked from commit
3797ddb3acc713cc200114e9e27dfb3901e5cdf1)
Michael Adam [Wed, 1 Apr 2009 10:23:07 +0000 (12:23 +0200)]
s3: fix the fix for bug #6195 - dont let smbd child processes panic
This patch makes sure the original and temporary TDBs are closed
_before_ the rename. Originally, the open TDB was renamed, and so
the name passdb.tdb.tmp stayed around in the db context. Hence
upon client connect, the smbd children died because reinit_after_fork()
calling tdb_reopen_all() would try to reopen passdb.tdb.tmp which
existed no longer...
Michael
(cherry picked from commit
1ab40fbca806f1136dd1d65edd688beb5ec592c7)
Karolin Seeger [Tue, 31 Mar 2009 14:12:30 +0000 (16:12 +0200)]
WHATSNEW: Fix announcement.
Karolin
(cherry picked from commit
b3e838884350e4da19660f0c1078aabd8e55536b)
Karolin Seeger [Tue, 31 Mar 2009 08:44:20 +0000 (10:44 +0200)]
VERSION: Raise version number up to 3.2.9.
Karolin
(cherry picked from commit
d999a7e99804bf71f62c905452a720c20016f8e9)
Karolin Seeger [Tue, 31 Mar 2009 08:43:47 +0000 (10:43 +0200)]
WHATSNEW: Update changes.
Karolin
(cherry picked from commit
bee6e86c71278563d52f9bde19ffb4bda2a35d1b)
Jeremy Allison [Mon, 30 Mar 2009 22:09:10 +0000 (15:09 -0700)]
Ensure files starting with multiple dots are hidden
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
(cherry picked from commit
5bdc16a867b9c14682b327c79f79834edcd6842d)
Karolin Seeger [Mon, 30 Mar 2009 10:43:17 +0000 (12:43 +0200)]
WHATSNEW: Update changes.
Karolin
(cherry picked from commit
e7634cd0c17d0fa4dcca5952313b6af750477dec)
Jeremy Allison [Sat, 28 Mar 2009 04:26:56 +0000 (21:26 -0700)]
Fix the problem of 3.0.x passdb databases being version
3 but using a different hash calculation than 3.2.x passwd
databases (also version 3). Introduces a minor version
number.
Jeremy.
(cherry picked from commit
10b518592e616ecfaadd829ecd0674a04510b422)
Derrell Lipman [Fri, 27 Mar 2009 21:10:04 +0000 (17:10 -0400)]
[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno
Fixed.
It turns out there were a number of places where cli_resolve_path() was called
and the error path upon that function failing did not set errno. There were a
couple of places the failure handling code did set errno to ENOENT, so I made
them all consistent, although I think better errno choices for this condition
exist, e.g. EHOSTUNREACH.
Derrell
(cherry picked from commit
f4e68b09a6ba30d968bccfad8bf6b67b4456b111)
Jeremy Allison [Fri, 27 Mar 2009 19:09:51 +0000 (12:09 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly. For the clustering case.
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
(cherry picked from commit
52fe104996439db24a7e6b17baa7fec47ba230bb)
Karolin Seeger [Fri, 27 Mar 2009 13:04:38 +0000 (14:04 +0100)]
WHATSNEW: Update changes since 3.2.8.
Karolin
(cherry picked from commit
7fa853e490be446a6da2086e1749b59a8f741e09)
Jeremy Allison [Thu, 26 Mar 2009 22:33:39 +0000 (15:33 -0700)]
Try and fix the build farm RAW-STREAMS errors. Ordering of
modules shouldn't matter, so as vfs_streams_depot doesn't
implement get/setxattrs then call into the full VFS stack
at the top.
Jeremy
(cherry picked from commit
a1d9b31a0c8a38dbfa94f578830d5d35695aff3b)
Jeremy Allison [Thu, 26 Mar 2009 19:13:28 +0000 (12:13 -0700)]
Fix bug #6224 - nmbd waits 5 minutes at startup before checking if it needs to run elections
Fix logic bug that causes nmbd to wait 5 minutes before
looking for a master browser. This one is *old* :-). Thanks
for Simo for bugging me on this.
Jeremy.
(cherry picked from commit
857c2e4407a0f4fcee721372ffed5366bc3051f9)
Tim Prouty [Thu, 26 Mar 2009 18:28:37 +0000 (11:28 -0700)]
s3: parse_packet can return NULL which is then dereferenced in match_mailslot_name
(cherry picked from commit
d097e3f918853cf642c4a51f6ed3a4d8c85d283e)
Volker Lendecke [Thu, 26 Mar 2009 11:24:50 +0000 (12:24 +0100)]
Fix a scary "fill_share_mode_lock failed" message
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.
Change the corresponding debug message to level 10 and explain more.
(cherry picked from commit
f73d4cf1fcfd8f9e2543a222faed133472fd890c)
Günther Deschner [Thu, 26 Mar 2009 09:41:11 +0000 (10:41 +0100)]
s3-net: Fix Bug #6102. NetQueryDisplayInformation could return wrong information.
Guenther
(cherry picked from commit
490ed838f2626893bb623ea6ad8d79595c8c44c4)
Günther Deschner [Wed, 25 Mar 2009 16:06:57 +0000 (17:06 +0100)]
s3-net: Fix Bug #6193: avoid messing with sync_context in fetch_database_to_ldif().
We absolutely need to avoid messing with the sync_context as that breaks the
stream of replication data coming from the DC (only replicates ~350 instead of
~4000 groups).
Guenther
(cherry picked from commit
1a1823c357fb8e01ac0e8c8749e6f5004bf3cf3e)
Volker Lendecke [Tue, 24 Mar 2009 22:34:13 +0000 (15:34 -0700)]
winbind_pam: fix gcc 4.4 compile warning
(cherry picked from commit
4a99f2f006e6324cf38b68f0f390daf52f24b1b3)
Volker Lendecke [Tue, 24 Mar 2009 22:29:35 +0000 (15:29 -0700)]
Fix two memleaks in the encryption code
ntlmssp_seal_packet creates its own signature data blob, which we then
have to free.
Jeremy, please check and merge appropriately (Yes, I'm asking you to do the
janitor work, I want you to *look* at this :-))
Volker
(cherry picked from commit
525af716cd52500a4e3dccf9eeb9ea85f86be7ca)
Stefan Metzmacher [Tue, 24 Mar 2009 18:50:49 +0000 (11:50 -0700)]
s3:smbd: if we allow trans2 on the IPC$ share, then we have to allow transs2 too.
Otherwise we'll confuse the client signing engine, when we reply an error to each transs2.
metze
(cherry picked from commit
e217138a36b1ba1eff164aecfa52ba6fe8864747)
Volker Lendecke [Tue, 24 Mar 2009 10:07:16 +0000 (11:07 +0100)]
Fix bug 6097
A client sent a SID with authority 0 and 0 sub-authorities. W2k3 replies with
NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.
Thanks to Pavel <wylda@volny.cz> for the bug report!
(cherry picked from commit
bb76066e8797599e5ca75821a686e32dd0c97a74)
Björn Jacke [Mon, 23 Mar 2009 11:26:03 +0000 (12:26 +0100)]
s3:dsgetdcname: use parentheses in if condition to make negation clear
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
87b428e424e2e3cca975ecd0efed327e72950a1d)
(cherry picked from commit
ca58d12b6513beb40c14fcab2758cf21af0179f3)
Günther Deschner [Fri, 20 Mar 2009 10:11:04 +0000 (11:11 +0100)]
s3-krb5: Fix Coverity #762 (REVERSE_INULL).
Guenther
(cherry picked from commit
97190ae184dff6450b1390c854f7426e2ee3f980)
(cherry picked from commit
0f7757e94bfa35d22a7349d78578685c0dba22d7)
(cherry picked from commit
66faa809847ad60b8027ae86068f8d62c0d181ed)
Günther Deschner [Thu, 19 Mar 2009 15:42:54 +0000 (16:42 +0100)]
s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).
Guenther
(cherry picked from commit
1524abd8bf12d82e1fb0063585fc9a465fc7bf9c)
(cherry picked from commit
3517388b5d5439ffe3f9629aaf826fa1dfbb4ba7)
(cherry picked from commit
5ce5a9bea994d7db3d352d0800333d0fd0b833df)
Stefan Metzmacher [Wed, 18 Mar 2009 06:56:51 +0000 (07:56 +0100)]
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
(cherry picked from commit
880fbc4e8cd67de73c4bcda94489eb1e1422a04b)
(cherry picked from commit
70466990b4b7c68ae95dbbcf741cd3f41f2dd0b3)
(cherry picked from commit
d01cca5e3ddb925696d49a1ea728013ec1032372)
(cherry picked from commit
6c13360e195189f7afc70c5fda6ef27f46145b0b)
Björn Jacke [Mon, 16 Mar 2009 00:51:09 +0000 (01:51 +0100)]
fix build on old Heimdal based systems
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
011ad7245d53a716c4c766f5ef8d317bb3a53d0f)
(cherry picked from commit
5eaa2541f19277bc00c47b944739c6732f90809b)
Jeremy Allison [Thu, 19 Mar 2009 03:54:13 +0000 (20:54 -0700)]
Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.
(cherry picked from commit
0c11c2deee7ab9d281df6df91b793b7f1c1764a4)
Jeremy Allison [Thu, 19 Mar 2009 02:58:01 +0000 (19:58 -0700)]
Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
(cherry picked from commit
985ba585207e840caa17c3d87d93ef1ba5f15cbb)
Jeremy Allison [Wed, 18 Mar 2009 21:31:01 +0000 (14:31 -0700)]
Fix bug 6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.
(cherry picked from commit
b5d794d5de872bcf757c8021c103b6b3d320b8db)
Volker Lendecke [Tue, 17 Mar 2009 10:22:41 +0000 (11:22 +0100)]
Fix a valgrind error
Found in "make test" -- if we can't connect at all, "cli" is uninitialized
(cherry picked from commit
8ffe7b07df753568d960155c27d57de2bd99993f)
Volker Lendecke [Mon, 16 Mar 2009 12:17:04 +0000 (13:17 +0100)]
Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
Thanks to François Legal <devel@thom.fr.eu.org> for reporting this bug
(cherry picked from commit
e6a23d498bfd4bbe19cecf24ba3f94af83c9bf8b)
Volker Lendecke [Sun, 15 Mar 2009 10:58:07 +0000 (11:58 +0100)]
Fix a malloc/talloc mismatch when cli_initialise() fails
(cherry picked from commit
20d378eebfcaca53f456f0fbae39d46031729de7)
Volker Lendecke [Sat, 14 Feb 2009 12:18:28 +0000 (13:18 +0100)]
Don't log NDR_PRINT_DEBUG at level 0, this always ends up in syslog
I think we eventually need to pass down the debuglevel here.
(cherry picked from commit
b2f6110d3ac5d60054a7e5a1d365f0a1f67a2f42)
Andrew Tridgell [Tue, 10 Mar 2009 05:45:45 +0000 (16:45 +1100)]
fixed a bug in message handling for code the change notify code
The change notify code registered a separate message handler for each
tree connect. This registration uses the global messaging context.
The messaging code would consider a 2nd registration for the same
messaging type as being an 'update' of the handler, rather than a new
handler. It also would only call the first handler in the linked list
for a given message type when dispatching messages.
This patch changes the messaging code to allow for multiple
registrations of the same message type, and allow for multiple calls
to different messaging handler for one incoming message.
This fixes the problem with the test_notify_tcon() test that I
recently committed to the S4 smbtorture
(cherry picked from commit
89e340e09fbdc375c0aa85506add525b8ba5dcd0)
(cherry picked from commit
733881d22f9864ea371b29d7d1817fb4af6b865c)
Volker Lendecke [Tue, 10 Mar 2009 15:08:38 +0000 (16:08 +0100)]
Revert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""
This reverts commit
96c57d26ed790b3e94c935cc4faf5661ea43a80c.
(cherry picked from commit
045933cf5bf27fbb704e446cf8686f2f761a1ced)
Volker Lendecke [Tue, 10 Mar 2009 14:46:16 +0000 (15:46 +0100)]
Revert "Fix a valgrind error / segfault in dns_register_smbd()"
This reverts commit
e47d2091136c4d870bb91b8a84eb9f6fd78eb971.
No idea why, but this causes timeouts in the build farm all over the place
(cherry picked from commit
0cf74151286238890ae0da0863e3a5807f4f3d81)
Volker Lendecke [Tue, 10 Mar 2009 13:06:05 +0000 (14:06 +0100)]
Fix a valgrind error / segfault in dns_register_smbd()
(cherry picked from commit
4624451b7b78695b3f84e7fff91018ee9df0e589)
(cherry picked from commit
e47d2091136c4d870bb91b8a84eb9f6fd78eb971)
Stefan Metzmacher [Mon, 9 Mar 2009 11:35:21 +0000 (12:35 +0100)]
s3:lib: interfaces.c isn't used in the configure tests anymore
libreplace always provides the getifaddr() function.
This fixes the build on sles8.
metze
(cherry picked from commit
1410490fe769bc79f98b4ab364685c7aed253e09)
(cherry picked from commit
bac96af2053996f28894458fce87e84c5c2356ff)
(cherry picked from commit
8c50d89743a8e9024d238c6613ceea35cf160aa0)
Jeremy Allison [Fri, 6 Mar 2009 05:46:38 +0000 (21:46 -0800)]
Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
(cherry picked from commit
b4d9e92dfaa84b1361cdd6e49ad88e252c8fed4d)
Jeremy Allison [Fri, 6 Mar 2009 05:02:22 +0000 (21:02 -0800)]
Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.
(cherry picked from commit
f58a6c9e08b2b44399e0333b1358522aec70bbee)
Jeremy Allison [Fri, 6 Mar 2009 01:16:54 +0000 (17:16 -0800)]
Fix bug #6161 - smbclient corrupts source path in tar mode
This was my fault. I broke the smbclient tar argument processing
in creating the string for chdir when removing pstrings.
Jeremy.
(cherry picked from commit
750f9d94b0a1208d45cc117df68042e1d83044bf)
Volker Lendecke [Thu, 5 Mar 2009 23:12:55 +0000 (15:12 -0800)]
Complete the fix for bug 6100
According to [MS-RPCE].pdf, section 2.2.2.11:
----
A client or a server that (during composing of a PDU) has allocated more space
for the authentication token than the security provider fills in SHOULD fill in
the rest of the allocated space with zero octets. These zero octets are still
considered to belong to the authentication token part of the PDU.<36>
----
RPC implementations are allowed to send padding bytes at the end of an auth
footer. Windows 7 makes use of this.
Thanks to Nick Meier <nmeier@microsoft.com>
Volker
(cherry picked from commit
91e2cd86e24cead352f07cc1a6b4a8e3a364adb5)
Volker Lendecke [Wed, 4 Mar 2009 13:00:03 +0000 (14:00 +0100)]
Fix an uninitialized variable warning
(cherry picked from commit
43ea27319933f3b49b61decde8321d9162cfd9ef)
Karolin Seeger [Fri, 27 Feb 2009 10:09:59 +0000 (11:09 +0100)]
s3/docs: Add missing full stop.
Karolin
(cherry picked from commit
2ab9d365cfceb28c1280566b6fe8ec3767e18149)
(cherry picked from commit
aff67e24f3675ace3c69c210aa387bc008f1cbbc)
(cherry picked from commit
0a9aff0bca4c49de0f87e496f62053787777f61d)
Bo Yang [Fri, 27 Feb 2009 19:37:19 +0000 (11:37 -0800)]
Initialize the id_map status in idmap_ldap to avoid surprise
(cherry picked from commit
c23dffc930cb9852bb98c2a92f0215cf73f4572d)
Steven Danneman [Fri, 27 Feb 2009 16:35:18 +0000 (08:35 -0800)]
s3: fix guest auth when winbindd is running
This fix is very subtle. If a server is configured with "security = share"
and "guest ok = yes" and winbindd is running authorization will fail during
tree connect.
This is due to our inability to map the guest sid S-1-5-21-X-501 to a uid
through sid_to_uid(). Winbindd is unaware of the hard coded mapping
between this sid and whatever uid the name in lp_guestaccount() is assigned.
So sid_to_uid() fails and we exit create_token_from_username() without
ever calling pdb_getsampwsid() which IS aware of the hard coded mapping.
This patch just reorganizes the code, moving sid_to_uid() down to the
block of code in which it is needed, avoiding this early failure.
(cherry picked from commit
671812696217fe1337562b661d5131be79797f1c)
Jeremy Allison [Wed, 25 Feb 2009 22:55:19 +0000 (14:55 -0800)]
Fix more POSIX path lstat calls. Fix bug where close can return
failure if we have a pending modtime and the containing directory
of the file has been renamed (there is no POSIX "update time by
fd" call). This can't happen on Windows as the rename will fail
if there are open files beneath it. Will add a torture test
for this.
Jeremy.
(cherry picked from commit
5fb3b5e903c08013074ba473399ddee30f6c328f)
Jeremy Allison [Wed, 25 Feb 2009 21:48:30 +0000 (13:48 -0800)]
Fix use of streams modules with CIFSFS client.
Jeremy.
(cherry picked from commit
161dc96c1147f637b5ef78bb3f543f6d5e0618c6)
Jeremy Allison [Wed, 25 Feb 2009 01:59:19 +0000 (17:59 -0800)]
Allow set attributes on a stream fnum to be redirected to the base filename.
Fixes the new RAW-STREAMS torture test.
Jeremy.
(cherry picked from commit
73d0c3143eedb5a9fd4d154aaf42d20ba6a19a1f)
Steve French [Tue, 24 Feb 2009 23:10:19 +0000 (17:10 -0600)]
Fix guest mounts
guest session setup, login (user id) as anonymous.
This patch is for samba bugzilla bug 4640.
Signed-off-by: Shirish Pargaonkar <shirishp@us.ibm.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
(cherry picked from commit
5e6b019d70fef2ad082fc414053c131294bdeb49)
Steve French [Tue, 24 Feb 2009 18:52:08 +0000 (12:52 -0600)]
cifs mount fix for handling -V parameter
also syncs with 3-3 mount.cifs
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@samba.org>
(cherry picked from commit
e831cd78ee3cf89abee058a475540955fad423ce)
Björn Jacke [Sun, 22 Feb 2009 18:46:40 +0000 (19:46 +0100)]
prefer gssapi header files from subdirectory
this fixes some compile time noise on FreeBSD 7
(cherry picked from commit
1bfdbb093f7c5e434ea3e653d389e1ccec578af6)
(cherry picked from commit
de96e1a82d6e92c00a0ab3020db8d7c0284aadb1)
Björn Jacke [Sat, 21 Feb 2009 23:43:38 +0000 (00:43 +0100)]
all BSDs use this evironment variable
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
cd6ae0de52164dd6f50b3614f2511acb3eb15993)
(cherry picked from commit
1ad5f50bdab761c7d3894e94f8fe3b171ec1b219)
(cherry picked from commit
bc53054616d442b1b28086181d81776f1c33834f)
Karolin Seeger [Mon, 23 Feb 2009 08:24:50 +0000 (09:24 +0100)]
s3/docs: Fix typo in man mount.cifs.
Thanks to Tobias Stoeckmann for reporting!
Karolin
(cherry picked from commit
09a7f93f6be66a8f2a124e49b4effe2b5863f01d)
(cherry picked from commit
fdb5c65fc51784b6a159748ec4df3953b7d2c1cb)
(cherry picked from commit
b19f58ccd088a10e487a1261cadb4f3f41987391)
Jeremy Allison [Fri, 20 Feb 2009 16:25:29 +0000 (08:25 -0800)]
Fix bug #6133 - Cannot delete non-ACL files on Solaris/ZFS/NFSv4 ACL filesystem.
As the NFSv4 ACL mapping code doesn't map write directory into the DELETE_CHILD
permission bit (which we require before allowing a delete) no one can delete
files without an explicit DELETE_CHILD bit set on the directory. Add this mapping.
Jeremy.
(cherry picked from commit
44e0e830c4c413054bdb30a62629993c4391c492)
Karolin Seeger [Fri, 20 Feb 2009 08:20:16 +0000 (09:20 +0100)]
s3/docs: Fix several typos.
This fixes bug #6127.
Thanks to Justin T Pryzby <justinpryzby [at] users.sourceforge.net>
for the review!
Karolin
(cherry picked from commit
54dbb030e2c6fed0abd0a3a89d08dad9b8a201a1)
(cherry picked from commit
a4548e41c6f12e4703249c53ad3dc727d2839931)
(cherry picked from commit
0d68e3d54b8f0bf2861edc7ac3b26c2f48f242eb)
Jeremy Allison [Thu, 19 Feb 2009 19:55:56 +0000 (11:55 -0800)]
Backport the semantics of when to delete alternate data streams on a file truncate.
Needed to fully support stream semantics.
Jeremy.
(cherry picked from commit
cdcb9bbf47396a7213edafeabb009920bb4e16b7)
Volker Lendecke [Thu, 19 Feb 2009 19:03:06 +0000 (20:03 +0100)]
Fix a O(n^2) algorithm in regdb_fetch_keys()
(cherry picked from commit
4bb5df5831f54686fe719f0cddef1af048009e9b)
Volker Lendecke [Thu, 19 Feb 2009 13:16:44 +0000 (14:16 +0100)]
Fix a buffer handling bug when adding lots of registry keys
This is *ancient*... From 2002, and nobody noticed until someone added lots of
shares using net conf... :-)
(cherry picked from commit
36ae846d15027df5e3a02ffabb08183dad9f6517)
Jeremy Allison [Thu, 19 Feb 2009 00:02:15 +0000 (16:02 -0800)]
Gah, typo :-(. Sorry.
(cherry picked from commit
301b23cf22ce1db04781b85954155fc93f4caee3)
Jeremy Allison [Wed, 18 Feb 2009 23:42:31 +0000 (15:42 -0800)]
Fix coverity CID-602. Possible use of uninitialized var.
Jeremy.
(cherry picked from commit
3b9874721ee8585e45b60246105fa380db132ac2)
Jeremy Allison [Tue, 17 Feb 2009 23:55:23 +0000 (15:55 -0800)]
Don't miss an absolute pathname as a kerberos keytab path. From Glenn Machin <gmachin@sandia.gov>.
Jeremy.
(cherry picked from commit
9974c09608d61244133eea8615c37184b0cac57b)
Stefan Metzmacher [Tue, 17 Feb 2009 09:28:37 +0000 (10:28 +0100)]
s3:make: use pidl/pidl for 'make idl'
metze
(cherry picked from commit
3dc256ad0f1d2b1c131d67e033533dd316eab252)
(cherry picked from commit
47bbea27c8972ca320e90c7c678fe6da28a269f1)
Stefan Metzmacher [Tue, 17 Feb 2009 08:04:58 +0000 (09:04 +0100)]
librpc: rerun 'PIDL=pidl/pidl make idl'
metze
(cherry picked from commit
eb1a2e4aea76462086a4303ba325c4da49e891cd)
(cherry picked from commit
e065eff98c9bd57155be824eef319f4c4d191e5e)
Stefan Metzmacher [Mon, 16 Feb 2009 09:20:55 +0000 (10:20 +0100)]
s3:netlogon: implement _netr_LogonGetCapabilities() with NT_STATUS_NOT_IMPLEMENTED
This hopefully fixes bug #6100.
metze
(cherry picked from commit
fe417b29bd23b7b935669993e0f01de4c7de2378)
(cherry picked from commit
2f858cb914842e9af1331477ec6eb9782dbd0cf5)
(cherry picked from commit
9edecdaa12fa42a356008b90710475ad9a1ae581)
Stefan Metzmacher [Mon, 16 Feb 2009 09:42:43 +0000 (10:42 +0100)]
netlogon.idl: add idl for netr_LogonGetCapabilities()
metze
(cherry picked from commit
8339969ed39e4cf3577971869ef2fd127f1c3ae3)
(cherry picked from commit
5410134c70e3302c05b73109610c28dfa1a0dc69)
(cherry picked from commit
4a353efc45480d3de91f91f618135faf8eb0429e)
Jelmer Vernooij [Mon, 21 Jul 2008 10:47:08 +0000 (12:47 +0200)]
Properly cast array length in print functions. (This used to be commit
f321240fa91fa19c1131f119c42f64897d220682)
(cherry picked from commit
37a29ad53eae02a29fbb0bf14731487328150d23)
Günther Deschner [Tue, 17 Feb 2009 02:32:16 +0000 (03:32 +0100)]
pidl: add pidl in order to be able to regenerate librpc functions.
This is pidl as of
0c6ce977ffb8f53f546596b76c1e0858cc6a88ba.
Guenther
(cherry picked from commit
bd53a095de3d221cab4a90a35cd018edd800f79a)
Yasuma Takeda [Mon, 16 Feb 2009 13:07:37 +0000 (14:07 +0100)]
Fix bug 5920
The length of the memcpy was calculated wrong, r->out.return_authenticator is
a pointer
(cherry picked from commit
cb9dd0f58d06a78b7724c3e0ec8f81512edc2d29)
Jeremy Allison [Mon, 16 Feb 2009 02:18:21 +0000 (18:18 -0800)]
Attempt to fix bug #6099. According to Microsoft
Windows 7 looks at the negotiate_flags
returned in this structure *even if the
call fails with access denied ! So in order
to allow Win7 to connect to a Samba NT style
PDC we set the flags before we know if it's
an error or not.
Jeremy.
(cherry picked from commit
eb82149dc7f6bbcca85e8ef97f3e23952b438770)
Tim Prouty [Sun, 15 Feb 2009 04:34:16 +0000 (20:34 -0800)]
s3 vfs: Fix SMB_VFS_RECVFILE/SENDFILE macros
(cherry picked from commit
0c4b1974a19d1ee78d3973808e9b854c19847a2b)
Jeremy Allison [Sat, 14 Feb 2009 01:33:24 +0000 (17:33 -0800)]
Oops. Fix the build (don't use 3.3 references in 3.2 :-).
Jeremy.
(cherry picked from commit
a7a3f335e3b867ca6c8d75a53262b15d7c75d7b1)
Holger Hetterich [Sat, 14 Feb 2009 01:30:22 +0000 (17:30 -0800)]
Enable total anonymization in vfs_smb_traffic_analyzer, by mapping
any user names to the one given by anonymize_prefix, without
generating a hash number. This setting is optional and is compatible
with the module configuration format of Samba 3.3.
(cherry picked from commit
4b17cca0557a086c5722c221a6e282bad4a2b40a)
Jeremy Allison [Sat, 14 Feb 2009 00:06:29 +0000 (16:06 -0800)]
Parameterize in local.h the MAX_RPC_DATA_SIZE, and ensure
that "offered" read from the rpc packet in spoolss is under
that size. Tidyup from analysis from Veracode.
Jeremy.
(cherry picked from commit
3ac4c42e1e5be2f25ef4602efa2ac360d8b603ce)
Jeremy Allison [Fri, 13 Feb 2009 23:06:13 +0000 (15:06 -0800)]
Noted by Vericode analysis. Correctly use chroot().
Jeremy.
(cherry picked from commit
c604236558b0be1b8a8539c7823e22f8e5eea55b)
Volker Lendecke [Fri, 13 Feb 2009 18:06:26 +0000 (10:06 -0800)]
Fix Coverity IDs 879 and 880 (RESOURCE_LEAK, REVERSE_INULL)
(cherry picked from commit
f7dc45f72145f0bba40c4a2e1a3ac7e4a85fd9cd)
Volker Lendecke [Fri, 13 Feb 2009 17:58:48 +0000 (09:58 -0800)]
Fix Coverity ID 742 (RESOURCE_LEAK)
(cherry picked from commit
eee6c3cd63c08f999c400d864dd7f7de68c03b85)
Volker Lendecke [Fri, 13 Feb 2009 17:53:56 +0000 (09:53 -0800)]
Fix Coverity ID 744
This was marked as a resource leak. This change makes the code a bit clearer
that we always free error_string.
(cherry picked from commit
b03d45e6783e2706bd5d9c98a88ac07933e3adeb)
Stefan Metzmacher [Fri, 13 Feb 2009 16:38:52 +0000 (17:38 +0100)]
s3:auth_util.c: fix the build
metze
(cherry picked from commit
6c52b5cb48d93934fe472eb57511dd05a89eb523)
Stefan Metzmacher [Wed, 11 Feb 2009 10:47:41 +0000 (11:47 +0100)]
s3:auth: only create_local_token() should add S-1-22-X-Y sids
metze
(cherry picked from commit
e7f7ed8bf6281ef01aca53ea44acdd4af4c51aa7)
(cherry picked from commit
cc1c764effd07bb124b5b5cf03fb5a4565c8ed36)
(cherry picked from commit
ebd7f45f9fe12b15dacc8ba52006ca25cb14fa0d)
Stefan Metzmacher [Wed, 11 Feb 2009 10:46:18 +0000 (11:46 +0100)]
s3:auth: add S-1-22-X-Y sids to the local token
metze
(cherry picked from commit
f14e4d4e54f424c05147cb0e635c9b8930270262)
(cherry picked from commit
490f7214f0d26e7466f0fdfb978e4b09f2433146)
(cherry picked from commit
2ac198ed8e219ce57d811d199cbdb1ae10770b15)
Volker Lendecke [Fri, 13 Feb 2009 10:18:31 +0000 (11:18 +0100)]
Fix Coverity ID 745 (RESOURCE_LEAK)
(cherry picked from commit
566f4e92390312feddedf16f2175139ef62ac45e)
Dan Sledz [Thu, 12 Feb 2009 20:01:16 +0000 (12:01 -0800)]
Fix double free caused by incorrect talloc_steal usage.
(cherry picked from commit
9aeca67cbeb1a04082b02d54150d042a7b5a241d)
Yasuma Takeda [Wed, 11 Feb 2009 22:23:29 +0000 (14:23 -0800)]
Fix bug #6098 - When the DNS server is invalid, the ads_find_dc() does not work correctly with "security = domain"
1. If DNS server is invalid, the get_sorted_dc_list() is called with
realm(FQDN) and it fails.
2. On the next step, the get_sorted_dc_list() is called with realm(FQDN) again.
I think "again" is wrong place.
On the 2nd step, get_sorted_dc_list() should be called with realm(WORKGROUP).
(cherry picked from commit
2f3eafae83d036c5b35e5d7d11be6e29aaab7533)
Michael Adam [Wed, 11 Feb 2009 21:27:48 +0000 (22:27 +0100)]
s3:packaging: fix parsing of include.h in fill-templates
The content has changed slightly in master for the merged build,
and we must be more exact when parsing the lines.
Michael
(cherry picked from commit
9cb2dfb1acc958c73f195ddc2480f267262e7d74)
Michael Adam [Wed, 11 Feb 2009 21:25:41 +0000 (22:25 +0100)]
s3:packaging: fix path to calling update-pkginfo after pushd in fill-templates
Michael
(cherry picked from commit
3884700f8b9d442352f301b306a9a0efc04f6153)
Michael Adam [Wed, 11 Feb 2009 21:24:52 +0000 (22:24 +0100)]
s3:packaging: paths cosmetics in fill-templates
Michael
(cherry picked from commit
c49b6775dd37eaa9f0cb6957d62a7578f5e3af54)
Björn Jacke [Wed, 11 Feb 2009 15:34:02 +0000 (16:34 +0100)]
enable IPv6 support for NetBSD, FreeBSD
most systems include netinet/in.h via netdb.h but *BSD don't.
(cherry picked from commit
808a9347faebd8349babe3704c2b83dd9b191140)
Michael Adam [Wed, 11 Feb 2009 10:03:30 +0000 (11:03 +0100)]
s3:build: some implementations of "ln" are picky about the order or arguments
Michael
(cherry picked from commit
fe30a4abe24f8aceb9966b250c55ad2e3b4ffc82)
Volker Lendecke [Wed, 11 Feb 2009 03:08:46 +0000 (19:08 -0800)]
Fix resume handle for _samr_EnumDomainGroups
(cherry picked from commit
4ac94e5f08c7454228e10711575e79fba34c5df9)
Michael Adam [Tue, 10 Feb 2009 22:52:40 +0000 (23:52 +0100)]
packaging: make update-pkginfo callable from any directory
Michael
(cherry picked from commit
7ea90835ebf6e2f2c6f325760800d8361d087ede)
(cherry picked from commit
0331720a321c849141349eb7982ee83298ec47c1)
Michael Adam [Fri, 12 Sep 2008 13:07:00 +0000 (15:07 +0200)]
packaging: use "find" instead of "du" to find files... :-)
Michael
(This used to be commit
768aa82361a2c4b0aab71433b7593723a2868f0a)
(cherry picked from commit
fd7635a1161e25d88a8252a5cf9de70ca2fe4232)
(cherry picked from commit
bfa086eef3db925ae32d554dbb7edb0f53df35e2)
Michael Adam [Tue, 10 Feb 2009 22:50:14 +0000 (23:50 +0100)]
packaging: remove commented out stuff from update-pkginfo
Michael
(cherry picked from commit
d714e58ec1f74897cd13e7cd9dd9003600052b45)
(cherry picked from commit
26e6ca1b3e7378d11ad4d6cb17b9f79244fa59b6)
Michael Adam [Tue, 10 Feb 2009 22:31:52 +0000 (23:31 +0100)]
packaging: don't clutter the output of fillup-templates with popd output
Michael
(cherry picked from commit
0c711935d30b500a15ef06fd658d382b2c1e2c84)
(cherry picked from commit
9e4db632387667b68cb7d7f44c20c67e6ebb9bf7)
Michael Adam [Tue, 10 Feb 2009 22:30:48 +0000 (23:30 +0100)]
packaging: fix fill-templates call to update-pkginfo to pushd appropriately first
Michael
(cherry picked from commit
c28d4ae537d9fc0b76eae758d32356eaf1113c89)
(cherry picked from commit
911424facd9227505eb72d11c480b685a130e720)
Michael Adam [Tue, 10 Feb 2009 17:54:16 +0000 (18:54 +0100)]
packaging: add script fill-templates
This is a standalone-wrapper for update-pkginfo, which is
usually called from create-tarball. It basically repeats
some functionality of create-tarball.
Michael
(cherry picked from commit
ca23469a906bab690162184e8d3949897f7b5a67)
(cherry picked from commit
84127f881bffebfa666d98636772307b35697270)
Günther Deschner [Tue, 10 Feb 2009 09:59:34 +0000 (10:59 +0100)]
s3-spoolss: fix memleak in get_remote_printer_publishing_data().
Guenther
(cherry picked from commit
97f1514ce95800f1296b1979f1b34dcc5d56a376)
(cherry picked from commit
b698559694d3f1799dec290433f75fbb73aceb32)