Karolin Seeger [Wed, 15 Oct 2014 07:46:44 +0000 (09:46 +0200)]
VERSION: Set version to 4.2.0rc2...
and disable git snapshots for the release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Wed, 15 Oct 2014 07:44:11 +0000 (09:44 +0200)]
WHATSNEW: Add release notes for Samba 4.2.0rc2.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Björn Baumbach [Thu, 9 Oct 2014 08:54:51 +0000 (10:54 +0200)]
build: do not install texpect binary anymore.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10862
Signed-off-by: Bjoern Baumbach <bb@sernet.de>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Thu Oct 9 17:10:12 CEST 2014 on sn-devel-104
(cherry picked from commit
c1f4b6c39beff7008a2746e65a9d8703b399f6a7)
Autobuild-User(v4-2-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-2-test): Tue Oct 14 23:27:47 CEST 2014 on sn-devel-104
Stefan Metzmacher [Mon, 6 Oct 2014 12:19:39 +0000 (14:19 +0200)]
libcli/smb: fix smb2cli_validate_negotiate_info with min=PROTOCOL_NT1 max=PROTOCOL_SMB2_02
If the connection starts with a SMB Negprot, the server only implies the
selected dialect, but not the clients security mode.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10866
(cherry picked from commit
3eef853f741d9349e45a1a87e453c52bf56c4774)
Autobuild-User(v4-2-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-2-test): Mon Oct 13 23:45:08 CEST 2014 on sn-devel-104
Marc Muehlfeld [Mon, 13 Oct 2014 18:50:02 +0000 (20:50 +0200)]
[PATCH] WHATSNEW: Added information about the VFS WORM module that is
new in 4.2.
Karolin Seeger [Mon, 13 Oct 2014 18:48:00 +0000 (20:48 +0200)]
WHATSNEW: Fix typo.
Thanks to Rowland Penny <repenny241155@gmail.com> for reporting.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Mon, 13 Oct 2014 18:44:33 +0000 (20:44 +0200)]
WHATSNEW: Fix typos.
Thanks to Michael Wood <esiotrot@gmail.com> for reporting.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Andrew Bartlett [Mon, 13 Oct 2014 18:36:21 +0000 (20:36 +0200)]
[PATCH] WHATSNEW: Add more features for Samba 4.2
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Andreas Schneider [Fri, 10 Oct 2014 07:43:04 +0000 (09:43 +0200)]
WHATSNEW: Add samba-regedit.
Signed-off-by: Andreas Schneider <asn@samba.org>
Christof Schmitt [Wed, 17 Sep 2014 20:23:11 +0000 (13:23 -0700)]
idmap_rfc2307: Fix a crash after connection problem to DC
When the connection to the DC has a problem, the code behind
ads_do_search_retry closes the current connection and opens a new one.
The new connection has a new struct LDAP to represent the connection. In
this case, the LDAP pointer in the idmap_rfc2307_context becomes
invalid.
Fix this problem by updating the local pointer after calling
ads_do_search_retry.
Signed-off-by: Christof Schmitt <cs@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10837
winbind crash in idmap_rfc2307 module
Jakub Hrozek [Thu, 2 Oct 2014 05:04:15 +0000 (07:04 +0200)]
SO_PROTOCOL is platform-dependent
SO_PROTOCOL is not defined on all platforms. In particular, OSX doesn't
include it and so far I haven't found any compatible declaration.
Signed-off-by: Jakub Hrozek <jakub.hrozek@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
5e70d80e7d7752a1df16b871d57fbcd8334a44e6)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10861
socket_wrapper does not build on systems without SO_PROTOCOL (< Linux 2.6.32)
Autobuild-User(v4-2-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-2-test): Thu Oct 9 23:38:36 CEST 2014 on sn-devel-104
Michael Adam [Wed, 1 Oct 2014 09:36:36 +0000 (11:36 +0200)]
regedit: remove an old comment
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Oct 1 16:55:05 CEST 2014 on sn-devel-104
(cherry picked from commit
fa9630e368df2446c5893b2fe51bada7a38760aa)
The last 45 patches address bug #10859 (Improve samba-regedit).
Chris Davis [Thu, 7 Aug 2014 13:17:28 +0000 (06:17 -0700)]
regedit: print error msg if opening registry fails
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
61cc5185e5ccf1bb6d1201063ac3a62e3b7fcfbb)
Chris Davis [Mon, 11 Aug 2014 01:26:14 +0000 (18:26 -0700)]
regedit: handle pgup/pgdn/home/end keys on lists
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
3b80f256bac0842f4470f9d5361426d7cff88ea9)
Chris Davis [Sun, 10 Aug 2014 00:11:00 +0000 (17:11 -0700)]
regedit: handle del and backspace in hexeditor
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
b96c43219480c442d0264834101e5bee675e3b04)
Chris Davis [Sat, 9 Aug 2014 20:39:59 +0000 (13:39 -0700)]
regedit: grow hexedit buffer as the user types
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
3c6541c44e2bfca2d1dfb7a971064d2c7143106f)
Chris Davis [Sat, 9 Aug 2014 06:55:25 +0000 (23:55 -0700)]
regedit: add a button to resize hexedit buffer
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
4badab3a6062a473b9651564ce43bb51c63457c1)
Chris Davis [Sat, 9 Aug 2014 06:36:48 +0000 (23:36 -0700)]
regedit: add a number input box
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
8acb87e42e8004c6a2f04085825fadad3cfbc5b2)
Chris Davis [Sat, 9 Aug 2014 05:25:50 +0000 (22:25 -0700)]
regedit: don't expand single line text field buffer with cursor movement
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
5bbed3d93dfddb0386401a032dc3321bc7f67e33)
Chris Davis [Sat, 9 Aug 2014 02:58:03 +0000 (19:58 -0700)]
regedit: handle DEL key in text fields
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
00765544af53cdfcc6f602b1825f14b97b96beb1)
Chris Davis [Thu, 7 Aug 2014 03:15:38 +0000 (20:15 -0700)]
regedit: adjust some variable names to make them more distinct
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
58db858619339084c86a02fd226eaff0854c730f)
Chris Davis [Sun, 3 Aug 2014 00:29:31 +0000 (17:29 -0700)]
regedit: find previous items
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
fd95b0aa96067d4c9ce60b73168bf9fe5c95ffac)
Chris Davis [Fri, 1 Aug 2014 06:24:19 +0000 (23:24 -0700)]
regedit: search values and repeat search from cursor positions
Recovering the search position from the cursors is safer than retaining
a pointer to the last node, as the pointer will become invalid if the
user deletes the item or refreshes the cache.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
bcab659516382d5dc51b1558a895a9a26d81c6b8)
Chris Davis [Thu, 31 Jul 2014 05:04:50 +0000 (22:04 -0700)]
regedit: flesh out search dialog and simplify search opts
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
09245177a4031fb1a1319071e745f0df10b1ee53)
Chris Davis [Tue, 29 Jul 2014 06:23:32 +0000 (23:23 -0700)]
regedit: don't use subwindows in hexedit
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
982c06f55a0ef8a80a0f87c9e77200ce952f85b3)
Chris Davis [Tue, 29 Jul 2014 06:04:10 +0000 (23:04 -0700)]
regedit: use pad as a canvas for dialogs
Drawing in a pad allows the dialog to maintain the same size even when
the terminal window is shrunk to some awkwardly small size. It also
helps avoid hacks needed to update positions of subwindows when the
panel is moved.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
c272178ccc6bb2f3b4a6621ef463489741c7e040)
Chris Davis [Mon, 28 Jul 2014 00:48:05 +0000 (17:48 -0700)]
regedit: clear value list after creating new key
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
cc22cb5cd44fdcc078211d2b82502ca219b1e928)
Chris Davis [Mon, 28 Jul 2014 00:39:06 +0000 (17:39 -0700)]
regedit: use the right function to reopen a hive
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
1b6445ae03521d788bf247eb550d1b51113fc8df)
Chris Davis [Sun, 27 Jul 2014 02:49:33 +0000 (19:49 -0700)]
regedit: move cursor to edited value in list and report edit errors
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
061d3e9a66f7f71cc6532fa6b0bcf47bf0fe3e35)
Chris Davis [Sat, 26 Jul 2014 06:26:27 +0000 (23:26 -0700)]
regedit: Introduce a new API to build the dialogs.
This helps make new dialogs easier to create, because it provides some
common building blocks and a consistent way to deal with user input.
Dialogs are divided into sections that stack vertically, and common
sections for typical UI things like text boxes, option lists, and
buttons are provided.
The old dialogs are rewritten to use this API.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
a728c391d7d4f6474e37f7118ba6df14dc9da6fd)
Chris Davis [Sat, 26 Jul 2014 06:16:52 +0000 (23:16 -0700)]
regedit: improvements for hexedit
This mainly enables setting the hexedit buffer after the editor is
allocated.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
30ae8f1014122258ff3b9415370fc679675929de)
Chris Davis [Fri, 18 Jul 2014 20:35:14 +0000 (13:35 -0700)]
regedit: add padding to fit REG_MULTI_SZ to the text field
This fixes a bug loading REG_MULTI_SZ values into the editor dialog,
since ncurses fields don't handle newline characters.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
42df2e643f68f5ec19e6a41eade29199a3266035)
Chris Davis [Tue, 8 Jul 2014 04:30:49 +0000 (21:30 -0700)]
regedit: simplify cleanup after loading children
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
c94c765f01dc145ee7f1abfe1379ed9c923f3d43)
Chris Davis [Tue, 1 Jul 2014 23:00:16 +0000 (16:00 -0700)]
regedit: add a panic handler to restore terminal
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
fec275a4a8e9ecd77fb30c4a242a2fe832d9f41c)
Chris Davis [Tue, 1 Jul 2014 06:19:53 +0000 (23:19 -0700)]
regedit: make all hives descend from a root node
This helps simplify cleanup, since each node's talloc context is the
parent node, and freeing the root node will destroy the entire tree
without any extra utility functions.
It also wouldn't be hard to extend this later on to support browsing
multiple registries at the same time.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
f9a2f2eb7cc3c69f20ab615dd98b750414672fe3)
Chris Davis [Tue, 1 Jul 2014 06:14:20 +0000 (23:14 -0700)]
regedit: add a refresh command to clear cache and reload current path
This is needed to view changes made externally
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit
41d5112407d7426d75671ac6967e62b080f63857)
Chris Davis [Sat, 28 Jun 2014 02:33:03 +0000 (19:33 -0700)]
regedit: reopen key after editing or removing values
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
5732d3f01284a0080740f1cb69c91cf4893fb401)
Chris Davis [Sat, 28 Jun 2014 01:01:36 +0000 (18:01 -0700)]
regedit: reopen parent keys when adding or removing subkeys
This clears any cache associated with the parent key,
and ensures the changes will be noticed by the UI.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
75045f052a5bc00fc8ffe35514c60e2f1611c9e9)
Chris Davis [Thu, 26 Jun 2014 14:51:22 +0000 (07:51 -0700)]
regedit: set cursor after creating a new key
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
2a8beb99a49829adfbad1c887448e3a2caa32255)
Chris Davis [Thu, 26 Jun 2014 05:51:27 +0000 (22:51 -0700)]
regedit: set cursor to the parent node when ascending
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
baf491ff0bdb40520d8a093e5c08c8608ed3075a)
Chris Davis [Thu, 26 Jun 2014 05:29:06 +0000 (22:29 -0700)]
regedit: don't fail loading keys if just a few are unavailable
Sometimes a key might fail to open due to access restrictions.
Only report failure if all keys failed to be opened.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
aba2b04b6c5584db63d03adab57fe1fd12ee71b4)
Chris Davis [Thu, 26 Jun 2014 04:55:27 +0000 (21:55 -0700)]
regedit: include error description in popups
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
df36fe7998fee3fc22976aeb42c25e2a2f0d73c5)
Chris Davis [Thu, 26 Jun 2014 04:48:52 +0000 (21:48 -0700)]
regedit: notify user if there's a failure loading subkeys
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
0b334dd1911206bac633421e1667052200574d29)
Chris Davis [Tue, 17 Jun 2014 00:36:16 +0000 (17:36 -0700)]
regedit: handle awkward window sizes better
This fixes some assertion failures and an infinte loop that occurs
when the terminal window is shrunk down far enough to the point
regedit can't fit everything on screen.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
55662513e14c026eb4cfa044ed772b31be5d6ab9)
Chris Davis [Sat, 14 Jun 2014 21:13:10 +0000 (14:13 -0700)]
regedit: use talloc typesafety features
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
c85cc6b8360284c64d60ff4d09ca8d5e03188f7b)
Chris Davis [Wed, 11 Jun 2014 17:40:38 +0000 (10:40 -0700)]
regedit: restore list cursor when window is resized
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
d38eba5244d0615994249070adee1f3df4c0d4aa)
Chris Davis [Tue, 10 Jun 2014 17:35:19 +0000 (10:35 -0700)]
regedit: make value list display data in multiple columns
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
ec6a7a7335f5b9e3a54b9967563ba198fc67b120)
Chris Davis [Tue, 10 Jun 2014 01:29:56 +0000 (18:29 -0700)]
regedit: add multicolumn list widget
Widget works for lists with one or more column(s).
Column headers are optional.
As a test, the patch also modifies regedit to use the
new widget for viewing registry keys. Valuelist still
needs to be upgraded to use this.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
7ad75367b2a42225a9f3539172e0b0e320d3a517)
Chris Davis [Tue, 3 Jun 2014 04:50:01 +0000 (21:50 -0700)]
regedit: add search feature.
Open up a search input with '/'. 'x' key gets the next
result.
This patch also ensures that keys are always sorted, so
that the search order matches the order the keys appear
on screen.
TODO:
+ flesh out search interface
+ find previous
+ search values
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
0ab07cb8069ae59e45fb0f6016096d30de9b4142)
Chris Davis [Thu, 22 May 2014 22:23:52 +0000 (15:23 -0700)]
regedit: add a color scheme for path and context help sections
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
b8b83509ca080d48530fbde9b012b9c3eb1c42fe)
Chris Davis [Thu, 22 May 2014 00:08:06 +0000 (17:08 -0700)]
regedit: sort keys
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
bd8abef327e68cf1c1fc9c2cf6e0b11738971521)
Chris Davis [Wed, 21 May 2014 22:03:50 +0000 (15:03 -0700)]
regedit: free value list subwindow
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
b5d0eb8ee06908ad8171f71b648c43de6303047b)
Chris Davis [Tue, 20 May 2014 23:17:42 +0000 (16:17 -0700)]
regedit: add borders around key and value lists, and change headings
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
c79837c215de59fa07b665bb79149058f36828d7)
Chris Davis [Tue, 20 May 2014 00:34:01 +0000 (17:34 -0700)]
regedit: add padding for key labels when there's not a prefix.
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
b48f081dc681a0a769165da43668b356c71fdb35)
Chris Davis [Mon, 19 May 2014 18:08:09 +0000 (11:08 -0700)]
regedit: add white on blue color scheme
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
994f1ed301e2023f0e4c8afa7429388ea90362e1)
Chris Davis [Tue, 5 Aug 2014 04:48:04 +0000 (21:48 -0700)]
regedit: silence some warnings
Signed-off-by: Chris Davis <cd.rattan@gmail.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
(cherry picked from commit
7e7c649376bd17c7ac9908bbd0ffc235e7cd18f7)
Jeremy Allison [Wed, 1 Oct 2014 21:20:10 +0000 (14:20 -0700)]
s3: smb2cli: query info return length check was reversed.
Make it identical to the check in libcli/smb/smb2cli_ioctl.c
https://bugzilla.samba.org/show_bug.cgi?id=10848
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: "Stefan (metze) Metzmacher" <metze@samba.org>
Reviewed-by: David Disseldorp <ddiss@suse.de>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct 2 04:42:26 CEST 2014 on sn-devel-104
(cherry picked from commit
6c05cd3e895831be7d9a68a51de2048d04c188a0)
Volker Lendecke [Wed, 8 Oct 2014 13:39:28 +0000 (15:39 +0200)]
registry: Don't leave dangling transactions
When a createkey fails due to access denied, we need to do a
transaction_cancel. Otherwise the lock on the db will stay around.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10860
Karolin Seeger [Wed, 8 Oct 2014 18:42:35 +0000 (20:42 +0200)]
WHATSNEW: Fix typo.
Thanks to David Keegel <djk@cyber.com.au> for reporting!
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Wed, 1 Oct 2014 07:47:33 +0000 (09:47 +0200)]
VERSION: Re-enable git snapshots.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Karolin Seeger [Wed, 1 Oct 2014 07:46:03 +0000 (09:46 +0200)]
VERSION: Bump version up to 4.2.0rc1...
...and disable git snapshots for the 4.2.0rc1 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Ralph Boehme [Sat, 27 Sep 2014 06:54:57 +0000 (08:54 +0200)]
vfs_fruit: deal with vfs_catia not being loaded
Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Oct 1 01:59:25 CEST 2014 on sn-devel-104
Ralph Boehme [Sat, 27 Sep 2014 06:04:11 +0000 (08:04 +0200)]
vfs_fruit: remove redundant assignment
Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Ralph Boehme [Sat, 27 Sep 2014 06:03:12 +0000 (08:03 +0200)]
vfs_fruit: fix possible uninitialized use
Signed-off-by: Ralph Boehme <rb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Fri, 26 Sep 2014 19:17:10 +0000 (21:17 +0200)]
libcli/smb: call smb2cli_validate_negotiate_info*() after each authenticated tcon
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Fri, 26 Sep 2014 19:15:00 +0000 (21:15 +0200)]
libcli/smb: add smb2cli_validate_negotiate_info*()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 30 Sep 2014 08:02:01 +0000 (10:02 +0200)]
libcli/smb: list NT_STATUS_FILE_CLOSED as expected ioctl response.
Some IOCTL requests change the behavior with new protocol versions.
E.g. FSCTL_VALIDATE_NEGOTIATE_INFO resulted in NT_STATUS_FILE_CLOSED
for old servers.
As SMB2 signing might be skipped for responses with NT_STATUS_FILE_CLOSED
we need to list it explicitly in the expected return values.
This way we'll get NT_STATUS_ACCESS_DENIED, if the server doesn't
sign the response to a signed requests.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 29 Sep 2014 09:19:14 +0000 (11:19 +0200)]
s4:libcli/tcon: remove unused smb2_tree_connect*()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 29 Sep 2014 09:17:03 +0000 (11:17 +0200)]
s4:torture/smb2: remove unused variable in torture_smb2_con_sopt()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 29 Sep 2014 09:01:32 +0000 (11:01 +0200)]
s4:torture/smb2: use smb2cli_tcon*() in torture_smb2_tree_connect()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 29 Sep 2014 09:01:32 +0000 (11:01 +0200)]
s4:torture/smb2: use torture_smb2_tree_connect() in notify.c
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 30 Sep 2014 10:28:13 +0000 (12:28 +0200)]
s4:torture/smb2: torture_smb2_tree_connect() creates a secondary tree connect
So don't mark smb2_tree_init() as primary.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Mon, 29 Sep 2014 08:50:18 +0000 (10:50 +0200)]
s4:libcli/smb2: make use of smb2cli_tcon*() in connect.c
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Thu, 25 Sep 2014 01:31:55 +0000 (03:31 +0200)]
s3:libsmb: remove unused smb2cli.h
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Thu, 25 Sep 2014 01:28:37 +0000 (03:28 +0200)]
libcli/smb: move smb2cli_tcon.c to the toplevel
removing use of cli_state from the code.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 24 Sep 2014 23:47:44 +0000 (01:47 +0200)]
s3:smb2cli_tcon: use smb2 signing if possible
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Fri, 26 Sep 2014 04:29:02 +0000 (06:29 +0200)]
libcli/smb: add smb2cli_tcon_{should_sign,is_signing_on}()
This can be used to force signing for individual requests.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Fri, 26 Sep 2014 04:25:53 +0000 (06:25 +0200)]
libcli/smb: add smb2cli_tcon_should_encrypt()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 24 Sep 2014 23:46:15 +0000 (01:46 +0200)]
libcli/smb: add smbXcli_session_is_authenticated()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 24 Sep 2014 23:22:29 +0000 (01:22 +0200)]
libcli/smb: support additional_flags = SMB2_HDR_FLAG_SIGNED
With SMB2_HDR_FLAG_SIGNED we make sure that we either use smb2 signing
or smb2 encryption for the request.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 24 Sep 2014 23:47:02 +0000 (01:47 +0200)]
s3:libsmb: remove unused ';'
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Fri, 28 Mar 2014 12:05:49 +0000 (13:05 +0100)]
s4:libcli/smb_composite: don't try anonymous smb signing
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Fri, 26 Sep 2014 04:13:10 +0000 (06:13 +0200)]
s3:smb2_negprot: allow really large io sizes up to allmost 16MB
The default is still 8MB (as on Windows 2012 *).
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 29 Sep 2014 09:22:09 +0000 (09:22 +0000)]
tdb: Fix a comment
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Sep 30 23:08:07 CEST 2014 on sn-devel-104
Jeremy Allison [Tue, 23 Sep 2014 21:51:18 +0000 (14:51 -0700)]
s3: lib: Signal handling - ensure smbrun and change password code save and restore existing SIGCHLD handlers.
Bug #10831 - SIGCLD Signal handler not correctly reinstalled on old library code use - smbrun etc.
https://bugzilla.samba.org/show_bug.cgi?id=10831
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Jeremy Allison [Tue, 23 Sep 2014 21:48:35 +0000 (14:48 -0700)]
lib: util [ctdb]: Signal handling - change CatchChild() and CatchChildLeaveStatus() to return the previous handler.
Bug #10831 - SIGCLD Signal handler not correctly reinstalled on old library code use - smbrun etc.
https://bugzilla.samba.org/show_bug.cgi?id=10831
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Jeremy Allison [Tue, 23 Sep 2014 20:32:37 +0000 (13:32 -0700)]
s3: nmbd: Ensure the main nmbd process doesn't create zombies.
Use the same mechanism as setup for smbd and winbindd.
Fixes bug #10830 - nmbd can leave unreaped zombies.
https://bugzilla.samba.org/show_bug.cgi?id=10830
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Michael Adam [Tue, 30 Sep 2014 08:16:23 +0000 (10:16 +0200)]
s3:torture: transfer 1M message with fds in LOCAL-MESSAGING-FDPASS2 test
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Sep 30 19:01:30 CEST 2014 on sn-devel-104
Michael Adam [Tue, 30 Sep 2014 08:15:33 +0000 (10:15 +0200)]
s3:torture: wait in tevent-loop for child to confirm receive in FDPASS2 msg test
This is the only way to correctly transfer bigger messages.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Tue, 30 Sep 2014 08:13:17 +0000 (10:13 +0200)]
s3:torture: fix a message in LOCAL-MESSAGING-FDPASS2 test
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Mon, 29 Sep 2014 22:30:58 +0000 (00:30 +0200)]
selftest: run LOCAL-MESSAGING-READ4
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Wed, 24 Sep 2014 22:28:14 +0000 (00:28 +0200)]
s3:torture: add LOCAL-MESSAGING-READ4 - send 1MB message
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Tue, 30 Sep 2014 08:01:51 +0000 (10:01 +0200)]
s3:messaging: explain why the messaging_send*() functions need a tevent-loop.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Tue, 30 Sep 2014 11:06:18 +0000 (13:06 +0200)]
s3:unix_msg: document closing of fds in the receive handler
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Michael Adam [Wed, 24 Sep 2014 22:28:48 +0000 (00:28 +0200)]
s3:unix_msg: close the fds in unix_dgram_recv_handler() after the callback has run
If the caller wants to use passed fds, he should copy them away
and set them to -1.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Tue, 30 Sep 2014 07:48:18 +0000 (09:48 +0200)]
s3:messaging: upon receiving fds, dup them so the caller can safely close them.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Tue, 30 Sep 2014 09:29:22 +0000 (11:29 +0200)]
s3:messaging: allow the messaging receive callback to change the fds
This allows the callback to consume the fds and e.g. set
them to -1 so that the caller can then treat (close) only those
fds that have not been consumed.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Mon, 29 Sep 2014 09:08:53 +0000 (11:08 +0200)]
s3:unix_msg: don't fill cmsg buffer in unix_dgram_send_job()
Do this in queue_msg, instead.
This renders unix_dgram_send_job() as simple as it was before
we introduced fd-passing -- as it is intended.
This also changes struct unix_dgram_msg to not contain
the fd-array, but the correspondingly filled msghdr and cmsg buf.
Pair-Programmed-With: Volker Lendecke <vl@samba.org>
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Michael Adam [Mon, 29 Sep 2014 11:31:27 +0000 (13:31 +0200)]
s3:unix_msg: add close_fd_array_cmsg()
Variant of close_fd_array() operating on fd_array inside msghdr.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Michael Adam [Mon, 29 Sep 2014 10:54:00 +0000 (12:54 +0200)]
s3:unix_msg: factor extract_fd_array_from_msghdr() out of unix_dgram_recv_handler()
For re-use.
Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>