git.samba.org / rusty / samba-autobuild / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3438398) | patch
CVE-2019-3824 ldb: wildcard_match end of data check
authorGary Lockyer <gary@catalyst.net.nz>
Mon, 18 Feb 2019 21:26:56 +0000 (10:26 +1300)
committerGary Lockyer <gary@samba.org>
Mon, 25 Feb 2019 20:26:12 +0000 (21:26 +0100)
commit42f0f57eb819ce6b68a8c5b3b53123b83ec917e3
treed31626bcd8ee9c04764018c8ee9494e657b7bbf2tree
parent34383981a0c40860f71a4451ff8fd752e1b67666commit | diff
CVE-2019-3824 ldb: wildcard_match end of data check

ldb_handler_copy and ldb_val_dup over allocate by one and add a trailing '\0'
to the data, to make them safe to use the C string functions on.

However testing for the trailing '\0' is not the correct way to test for
the end of a value, the length should be checked instead.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13773

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb/common/ldb_match.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.