s3: smbd: Ensure srvstr_pull_req_talloc() always NULLs out *dest.
authorJeremy Allison <jra@samba.org>
Fri, 11 Aug 2023 17:42:41 +0000 (10:42 -0700)
committerVolker Lendecke <vl@samba.org>
Mon, 14 Aug 2023 14:57:32 +0000 (14:57 +0000)
commit9220c45cc191b34e293190f6a923ba463edd5db9
treefb01ae0c4537f78ee7bfdcb6d207b87eab12aa34
parent963fd8aa9b76361ab9aeb63307773f2498b17879
s3: smbd: Ensure srvstr_pull_req_talloc() always NULLs out *dest.

Robert Morris <rtm@lcs.mit.edu> noticed that in the case
where srvstr_pull_req_talloc() is being called with
buffer remaining == 0, we don't NULL out the destination
pointed which is *always* done in the codepaths inside
pull_string_talloc(). This prevents a crash in the caller.

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15420

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
selftest/knownfail.d/smb1_truncated_sessetup [deleted file]
source3/smbd/smb2_reply.c