From 76babda4ef13111e402fcfac10d6f9c3d7bb75e9 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 30 Mar 2018 12:19:24 -0500 Subject: [PATCH 1/1] groupdb: Fix CID 1167984 Ignoring number of bytes read Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison Reviewed-by: Stefan Metzmacher --- source3/groupdb/mapping.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source3/groupdb/mapping.c b/source3/groupdb/mapping.c index ac70fe68c482..1a8670e66b0c 100644 --- a/source3/groupdb/mapping.c +++ b/source3/groupdb/mapping.c @@ -237,9 +237,13 @@ int smb_create_group(const char *unix_group, gid_t *new_gid) if (fd != 0) { fstring output; + ssize_t nread; *new_gid = 0; - if (read(fd, output, sizeof(output)) > 0) { + + nread = read(fd, output, sizeof(output)-1); + if (nread > 0) { + output[nread] = '\0'; *new_gid = (gid_t)strtoul(output, NULL, 10); } -- 2.34.1