From 9ce1f28b8ab31d6bb9f2468dd3cdd57bf34f7af7 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Wed, 20 Apr 2016 10:07:21 +0100 Subject: [PATCH] s4:torture:smb2 fix 'Use of uninitialised value of size 8' valgrind error. smbtorture test smb2.oplock.brl2.brl2 generates the following valgrind trace ==16443== Use of uninitialised value of size 8 ==16443== at 0x8F005DE: _samba_rijndaelEncrypt (rijndael-alg-fst.c:958) ==16443== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16443== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16443== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16443== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16443== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16443== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16443== by 0x5B07AAE: smb2_lock (lock.c:80) ==16443== by 0x4B5971: test_smb2_oplock_brl2 (oplock.c:3464) ==16443== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16443== by 0x955368F: internal_torture_run_test (torture.c:442) ==16443== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16443== by 0x26013F: run_matching (smbtorture.c:110) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16443== by 0x261EDF: main (smbtorture.c:665) ==16443== ==16443== Use of uninitialised value of size 8 ==16443== at 0x8F00649: _samba_rijndaelEncrypt (rijndael-alg-fst.c:963) ==16443== by 0x8EFF24C: samba_AES_encrypt (aes.c:60) ==16443== by 0x8F01BB2: aes_cmac_128_final (aes_cmac_128.c:179) ==16443== by 0xB0D11E5: smb2_signing_sign_pdu (smb2_signing.c:78) ==16443== by 0xB0D984A: smb2cli_req_compound_submit (smbXcli_base.c:3062) ==16443== by 0x5AFD5F5: smb2_transport_send (transport.c:237) ==16443== by 0x5B078DF: smb2_lock_send (lock.c:52) ==16443== by 0x5B07AAE: smb2_lock (lock.c:80) ==16443== by 0x4B5971: test_smb2_oplock_brl2 (oplock.c:3464) ==16443== by 0x48B452: wrap_simple_1smb2_test (smb2.c:52) ==16443== by 0x955368F: internal_torture_run_test (torture.c:442) ==16443== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==16443== by 0x26013F: run_matching (smbtorture.c:110) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260001: run_matching (smbtorture.c:95) ==16443== by 0x260260: torture_run_named_tests (smbtorture.c:143) ==16443== by 0x261EDF: main (smbtorture.c:665) ==16443== Signed-off-by: Noel Power Reviewed-by: Volker Lendecke Reviewed-by: Andreas Schneider --- source4/torture/smb2/oplock.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source4/torture/smb2/oplock.c b/source4/torture/smb2/oplock.c index 165c4d7687dc..e156dc680374 100644 --- a/source4/torture/smb2/oplock.c +++ b/source4/torture/smb2/oplock.c @@ -3451,6 +3451,8 @@ static bool test_smb2_oplock_brl2(struct torture_context *tctx, struct smb2_tree torture_comment(tctx, "a self BRL acquisition should not break to " "none\n"); + ZERO_STRUCT(lock); + lock[0].offset = 0; lock[0].length = 4; lock[0].flags = SMB2_LOCK_FLAG_EXCLUSIVE | -- 2.34.1