From b53968656eee6c57e281ee32bff1d4643b4292f0 Mon Sep 17 00:00:00 2001 From: Ralph Boehme Date: Fri, 4 Jun 2021 15:54:20 +0200 Subject: [PATCH] smbd: handle fake file handles in fdos_mode() This ensures SMB requests on the quote fake file "$Extend/$Quota" don't hit the VFS, where specifically in vfs_gpfs we log an error message if we fail to read the DOS attributes for a file with vfs_gpfs_get_dos_attributes: Getting winattrs failed for $Extend/$Quota BUG: https://bugzilla.samba.org/show_bug.cgi?id=14731 Signed-off-by: Ralph Boehme Reviewed-by: Jeremy Allison (cherry picked from commit e093eaed1046638193d973c39fa9df74e41148d3) --- source3/smbd/dosmode.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c index 844f5efe389..79158007654 100644 --- a/source3/smbd/dosmode.c +++ b/source3/smbd/dosmode.c @@ -28,6 +28,7 @@ #include "lib/param/loadparm.h" #include "lib/util/tevent_ntstatus.h" #include "lib/util/string_wrappers.h" +#include "fake_file.h" static NTSTATUS get_file_handle_for_metadata(connection_struct *conn, const struct smb_filename *smb_fname, @@ -751,6 +752,10 @@ uint32_t fdos_mode(struct files_struct *fsp) DBG_DEBUG("%s\n", fsp_str_dbg(fsp)); + if (fsp->fake_file_handle != NULL) { + return dosmode_from_fake_filehandle(fsp->fake_file_handle); + } + if (!VALID_STAT(fsp->fsp_name->st)) { return 0; } -- 2.34.1