From bc9a70d23ca7e95806e7634f78e4dc155768315b Mon Sep 17 00:00:00 2001 From: Samuel Cabrero Date: Wed, 29 Nov 2023 12:55:13 +0100 Subject: [PATCH] idmap_nss: Increase debug on failures Signed-off-by: Samuel Cabrero Reviewed-by: Alexander Bokovoy --- source3/winbindd/idmap_nss.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/source3/winbindd/idmap_nss.c b/source3/winbindd/idmap_nss.c index 642d5141784..8d2b23b4165 100644 --- a/source3/winbindd/idmap_nss.c +++ b/source3/winbindd/idmap_nss.c @@ -62,24 +62,36 @@ static NTSTATUS idmap_nss_unixids_to_sids(struct idmap_domain *dom, struct id_ma switch (ids[i]->xid.type) { case ID_TYPE_UID: + errno = 0; pw = getpwuid((uid_t)ids[i]->xid.id); - if (!pw) { + DBG_DEBUG("getpwuid(%lu) failed: %s\n", + (unsigned long)ids[i]->xid.id, + errno != 0 + ? strerror(errno) + : "not found"); ids[i]->status = ID_UNMAPPED; continue; } name = pw->pw_name; break; case ID_TYPE_GID: + errno = 0; gr = getgrgid((gid_t)ids[i]->xid.id); - if (!gr) { + DBG_DEBUG("getgrgid(%lu) failed: %s\n", + (unsigned long)ids[i]->xid.id, + errno != 0 + ? strerror(errno) + : "not found"); ids[i]->status = ID_UNMAPPED; continue; } name = gr->gr_name; break; default: /* ?? */ + DBG_WARNING("Unexpected xid type %d\n", + ids[i]->xid.type); ids[i]->status = ID_UNKNOWN; continue; } -- 2.34.1