s3: smbd: Fix SMB1 reply_unlink() to handle wildcards.
authorJeremy Allison <jra@samba.org>
Mon, 5 Oct 2020 18:40:41 +0000 (11:40 -0700)
committerRalph Boehme <slow@samba.org>
Thu, 8 Oct 2020 15:07:30 +0000 (15:07 +0000)
commit90bce2c0920d0f2dc2e3aebef0f563eda99fdaac
treeaafc3c6747243f99f8819778839f8f7e9e059a4b
parent4ba1428334cfaa33c72c68947ed1afb1b985cb9e
s3: smbd: Fix SMB1 reply_unlink() to handle wildcards.

Add a 'bool have_wcard' to unlink_internals().
Move the wildcard detection out of unlink_internals() as it
was looking at the wrong thing.

This is now correctly set only from the unmangled last component
of the path sent to reply_unlink().

We now pass:

Samba3.smbtorture_s3.crypt_client.SMB1-WILD-MANGLE-UNLINK(nt4_dc_smb1)
samba3.smbtorture_s3.plain.SMB1-WILD-MANGLE-UNLINK(fileserver_smb1)

so remove the knownfail.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
selftest/knownfail.d/smb1-wild-mangle-unlink [deleted file]
source3/printing/nt_printing.c
source3/smbd/proto.h
source3/smbd/reply.c
source3/smbd/trans2.c