git.samba.org / cs / samba-autobuild / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a6d76d6) | patch
s4:dsdb:mod:operational: use NUMERIC_CMP in pso_compare
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Tue, 2 Apr 2024 23:55:27 +0000 (12:55 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 10 Apr 2024 22:56:33 +0000 (22:56 +0000)
commit623adcf4aae00ac06e82d98a75ce4644890501e6
treebbf08ba3e88232dbedad3cf17a69d80524af50actree
parenta6d76d6ee9f7cfcabe2c20b872b8b1cb598928a6commit | diff
s4:dsdb:mod:operational: use NUMERIC_CMP in pso_compare

prec_{1,2} are uint32_t, and if one is not set we are defaulting to
0xffffffff (a.k.a UINT32_MAX), so an overflow when cast to int seems
extremely likely.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15625

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/dsdb/samdb/ldb_modules/operational.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.