Karolin Seeger [Wed, 25 Jan 2012 18:23:06 +0000 (19:23 +0100)]
WHATSNEW: Add another change.
Jeremy, thanks a lot for the fix!
(cherry picked from commit
a3dcfb66bb3763ee95f2bfe8b7a615ffee859985)
Jeremy Allison [Wed, 25 Jan 2012 18:19:14 +0000 (19:19 +0100)]
s3-spoolss: Pass the right pointer type.
Follow-up fix for an issue introduced by a fix for bug #4942.
(cherry picked from commit
69fafa216ee45829d330e9564858f6702b4b268d)
Karolin Seeger [Mon, 23 Jan 2012 20:39:58 +0000 (21:39 +0100)]
WHATSNEW: Add another change.
Karolin
(cherry picked from commit
788c8af4453bcb711da2712d8526c22689b49d38)
Jeremy Allison [Mon, 23 Jan 2012 19:20:52 +0000 (11:20 -0800)]
Second part of fix for 8636 - When returning an ACL without SECINFO_DACL requested, we still set SEC_DESC_DACL_PRESENT in the type field.
Ensure we always ask for the set:
OWNER_SECURITY_INFORMATION |
GROUP_SECURITY_INFORMATION |
DACL_SECURITY_INFORMATION |
SACL_SECURITY_INFORMATION
when getting an ACL inside the module.
(cherry picked from commit
4eb17aff84dc0dccec23e066db7a88581cf7668c)
Jeremy Allison [Wed, 30 Nov 2011 00:31:18 +0000 (16:31 -0800)]
Fix bug 8636 - When returning an ACL without SECINFO_DACL requested, we still set SEC_DESC_DACL_PRESENT in the type field.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Nov 30 04:59:07 CET 2011 on sn-devel-104
(cherry picked from commit
da992be64f39364fbb8bca26e9421c7a36c49ac6)
(cherry picked from commit
c0ad67c1888e44be77d8f34681f12fc8b4f19f86)
Karolin Seeger [Mon, 23 Jan 2012 20:22:40 +0000 (21:22 +0100)]
WHATSNEW: Add major changes.
Please feel free to add more entries.
Karolin
(cherry picked from commit
0b19c19ec6057b03fe0cbee91bbf974ca6bf3221)
Karolin Seeger [Mon, 23 Jan 2012 19:52:37 +0000 (20:52 +0100)]
WHATSNEW: Add more changes.
Karolin
(cherry picked from commit
db645b334e591133d664a7d1f88e82925ad52c40)
David Disseldorp [Tue, 17 Jan 2012 16:07:01 +0000 (17:07 +0100)]
torture: add spoolss overlapping driver deletion tests
The last 7 patches address bug #8697 (DeletePrinterDriverEx never removes
printer driver files) and bug #4942 (DeletePrinterDriverEx deletes files
in use).
(cherry picked from commit
c4a3d988a64723a51be4b3ddaddd83708d90ed13)
David Disseldorp [Tue, 17 Jan 2012 14:20:51 +0000 (15:20 +0100)]
torture: confirm printer driver file removal
(cherry picked from commit
31f491c98c07e468e1f0e840f6accb6da3281498)
David Disseldorp [Mon, 16 Jan 2012 15:30:17 +0000 (16:30 +0100)]
torture: add spoolss del printer driver test
Test handling of DeletePrinterDriverEx when the DPD_DELETE_ALL_FILES
flag is set.
(cherry picked from commit
b894e6297f36b05259fc6932a7ee1c500bc806e9)
David Disseldorp [Tue, 17 Jan 2012 16:06:38 +0000 (17:06 +0100)]
s3-spoolss: fix printer_driver_files_in_use() call ordering
printer_driver_files_in_use() performs two tasks: it returns whether any
of the files in the to-be-deleted driver overlap with other drivers, it
also trims such files from the info structure passed in.
In processing a DeletePrinterDataEx request with DPD_DELETE_UNUSED_FILES
set, printer_driver_files_in_use() must be called to ensure files in
use by other drivers are not removed.
https://bugzilla.samba.org/show_bug.cgi?id=4942
(cherry picked from commit
8e3c0ac2815bc25360bf408c50449d154b841f8a)
David Disseldorp [Thu, 12 Jan 2012 15:27:37 +0000 (16:27 +0100)]
s3-spoolss: fix printer driver version deletion
Spoolss delete printer driver code currently makes invalid version
assumptions based on the architecture requested by the client.
Ugly hacks are in place to cover removal of other versions (2 and 3).
This change wraps multi version deletion in a simple for loop.
(cherry picked from commit
54bc662adb24be9950c827446130b91504965c8c)
David Disseldorp [Wed, 11 Jan 2012 18:50:36 +0000 (19:50 +0100)]
s3-spoolss: prefix print$ path on driver file deletion
Driver file paths stored in the registry do not include the server path
prefix. delete_driver_files() incorrectly assumes such a prefix.
https://bugzilla.samba.org/show_bug.cgi?id=8697
(cherry picked from commit
c14586647451a878fdc911ee4be699b3e6485b83)
David Disseldorp [Tue, 10 Jan 2012 17:21:42 +0000 (18:21 +0100)]
spoolss: fix DPD_DELETE_ALL_FILES error return
If DeletePrinterDriverEx is called with DPD_DELETE_ALL_FILES and files
assigned to the to-be-deleted driver overlap with other drivers then an
error is returned. Change the error code here to match Windows 2k8r2.
Signed-off-by: David Disseldorp <ddiss@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit
29c97b7132ac316327123f200a71e70317b2dbb9)
Karolin Seeger [Sun, 22 Jan 2012 20:22:24 +0000 (21:22 +0100)]
WHATSNEW: Add more changes since 3.6.1.
Karolin
(cherry picked from commit
f71b7a83c4cc3d10085ed1b7db29e222a4a9f743)
Karolin Seeger [Sat, 21 Jan 2012 21:17:42 +0000 (22:17 +0100)]
WHATSNEW: Start release notes for 3.6.2.
To be continued...
Karolin
(cherry picked from commit
3ea8d8acaefaadd2d3888bec1ef148b7242aaccf)
Matthieu Patou [Sat, 21 Jan 2012 20:34:06 +0000 (21:34 +0100)]
[PATCH] s3: improve the code in the AES encryption.
Remove looping replace them by memcpy.
Fix bug #8674 (Buffer overflow in vfs_smb_traffic_analyzer).
.
(cherry picked from commit
0971582873f90bb592355fb53171d09a8ff3012e)
Jeremy Allison [Sat, 21 Jan 2012 20:16:19 +0000 (21:16 +0100)]
s3: Fix bug #8674.
Buffer overflow issue with AES encryption in samba traffic analyzer.
(cherry picked from commit
bb38a79656b6ddee01327c328435043a7d0a112b)
Jeremy Allison [Tue, 10 Jan 2012 21:49:03 +0000 (13:49 -0800)]
Third part of fix for bug #8673 - NT ACL issue.
(Not needed in master as this code has changed). Ensure we set a temp
access mask before calling open(O_RDONLY|O_DIRECTORY) on the directory.
(cherry picked from commit
6b72809b7488cc530f47ad08dfde215627681cf6)
Jeremy Allison [Tue, 10 Jan 2012 21:48:18 +0000 (13:48 -0800)]
Second part of fix for bug #8673 - NT ACL issue.
Ensure we process the entire ACE list instead of returning ACCESS_DENIED
and terminating the walk - ensure we only return the exact bits that cause
the access to be denied. Some of the S3 fileserver needs to know if we
are only denied DELETE access before overriding it by looking at the
containing directory ACL.
(cherry picked from commit
28834ee4fcfc204fa9a88459700fed212a1e9fce)
Jeremy Allison [Tue, 10 Jan 2012 21:41:55 +0000 (13:41 -0800)]
First part of fix for bug #8673 - NT ACL issue.
Simplify the logic in the unlink/rmdir calls - makes it readable
(and correct). Add some debug.
(cherry picked from commit
d40006aa7f8a594273a9d0ad1fa1a87ae7b1ebb0)
Jeremy Allison [Fri, 16 Dec 2011 23:50:58 +0000 (15:50 -0800)]
Third part of fix for bug #8663 - deleting a symlink fails if the symlink target is outside of the share.
can_access_file_acl() - we can always delete a symlink.
can_delete_file_in_directory() - We don't need to do another STAT call
here, we know smb_fname->st is in a valid state.
smbd_check_open_rights() - we can always delete a symlink.
(cherry picked from commit
c6bd2aa768ebf4308c53d057bc1db7adc2b67705)
Jeremy Allison [Fri, 16 Dec 2011 23:37:07 +0000 (15:37 -0800)]
Second part of fix for bug #8663 - deleting a symlink fails if the symlink target is outside of the share.
Ensure we use UCF_UNIX_NAME_LOOKUP flags on filename_convert()
when doing a restricted set of infolevels in trans2setfilepathinfo().
(cherry picked from commit
cb5f2b3f9d5710ba66182e45bf8380c2f37b4190)
Jeremy Allison [Fri, 16 Dec 2011 23:35:55 +0000 (15:35 -0800)]
First part of fix for bug #8663 - deleting a symlink fails if the symlink target is outside of the share.
Remove two unneeded check_name() calls. They have already been done
in order to get here.
(cherry picked from commit
8799e63b3859502e724cb870c954a0c03ce860e2)
Jeremy Allison [Wed, 18 Jan 2012 20:38:14 +0000 (12:38 -0800)]
Fix bug 8710 - connections.tdb - major leak with SMB2.
Ensure the cnum used to claim the connection for SMB2 is the
id that will be used for the SMB2 tcon. Based on code from
Ira Cooper <ira@wakeful.net>.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Jan 18 23:14:32 CET 2012 on sn-devel-104
(cherry picked from commit
39c627b60754bd89c419b2d7e32d32c7a9af5a11)
(cherry picked from commit
a455a63eaf84024f79922e95a740bf3443f37954)
Jeremy Allison [Fri, 16 Dec 2011 23:53:46 +0000 (15:53 -0800)]
Fix bug #8664 - Renaming a symlink fails if the symlink target is outside of the share.
(cherry picked from commit
6e77eac8f21925460e3b1946c2c22f6eff296322)
David Disseldorp [Fri, 13 Jan 2012 21:51:22 +0000 (13:51 -0800)]
idl: add to_null property
to_null specifies that character conversion should only occur until the
null pointer in an array based string.
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Jan 14 00:51:54 CET 2012 on sn-devel-104
The last 5 patches address bug #8606 (Intermittent print job failures caused by
character conversion errors).
(cherry picked from commit
c92513e218432ba3fb4afe6e93c8c1fc8f684368)
David Disseldorp [Wed, 23 Nov 2011 01:03:48 +0000 (02:03 +0100)]
idl: add to_null attribute to the spoolss devicename array
OpenPrinterEx requests have also been observed in the wild carrying
non-utf16 garbage after the device mode devicename field null
terminator.
Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
90f3708135ef6573997417bd8e53191df78519c2)
David Disseldorp [Sun, 13 Nov 2011 19:40:56 +0000 (20:40 +0100)]
idl: add to_null attribute to the spoolss formname array
OpenPrinterEx requests have been observed in the wild carrying a device
mode formname "A4" followed by non-utf16 garbage after the null
terminator. Such requests currently fail during unmarshalling in the
ndr_pull_charset() codepath, causing intermittent print job failures.
This change ensures that garbage after the device mode formname null
terminator is not processed in unmarshalling.
https://bugzilla.samba.org/show_bug.cgi?id=8606
Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
219d8c916fd890ca4b4eae77abd5a651aa37e4ff)
David Disseldorp [Sat, 14 Jan 2012 00:32:59 +0000 (16:32 -0800)]
ndr: add ndr_pull_charset_to_null()
The same as ndr_pull_charset(), however only perform character
conversion on bytes prior to and including the null terminator.
Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
aa8fbd5005c06dfd0b5ee2865c49eab285f57e62)
David Disseldorp [Sun, 13 Nov 2011 19:39:58 +0000 (20:39 +0100)]
idl: add parser for the to_null property
Compile into a ndr_pull_charset_to_null call.
Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
ec05a11c362f0aa4875c8dd3cfb853d0fae84c4c)
Günther Deschner [Fri, 6 Jan 2012 15:10:55 +0000 (16:10 +0100)]
s3-libads: fix malloc/talloc mismatch in ads_keytab_verify_ticket().
Guenther
Fix big #8692 (ads_keytab_verify_ticket mixes talloc allocation with malloc
free).
(cherry picked from commit
6da7abe87db15d260db807643a25a96fc05e5ad9)
Stefan Metzmacher [Thu, 10 Nov 2011 13:43:55 +0000 (14:43 +0100)]
libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)
After a calling any wrapper of tevent_req_notify_callback(),
e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(),
a function has to return immediately otherwise it is very likely to
crash.
metze
(similar to commit
17f1a97a614db4ed8292544988cb6a6cf56621d8)
(cherry picked from commit
740a001971bab647c1ab129b3dd2fbccaddc4e7b)
Stefan Metzmacher [Fri, 23 Dec 2011 13:45:45 +0000 (14:45 +0100)]
s3:lib/ctdbd_conn: try ctdbd_init_connection() as root (bug #8684)
ctdbd_traverse is only called if the main db_context is already
open. So if we could get to information via dbwrap_fetch,
we should also be able to traverse.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Dec 23 18:19:14 CET 2011 on sn-devel-104
(cherry picked from commit
4a1895eb9921ad533910d08823c2814c470875fd)
(cherry picked from commit
ff4e1df575a3d7eb484b31d6afe46825ba418981)
Björn Baumbach [Fri, 18 Nov 2011 17:54:56 +0000 (18:54 +0100)]
s3-printing: fix migrate printer code (bug 8618)
Removed path from driver files.
We only need the basenames.
(cherry picked from commit
d61993043fcb7676a58658476421f5f4ff1a3fea)
Volker Lendecke [Wed, 4 Jan 2012 19:09:54 +0000 (11:09 -0800)]
Fix bug #8686 - Packet validation checks can be done before length validation causing uninitialized memory read.
(cherry picked from commit
24ac26ddfd9ee8841d1984e710a4dfe535b9abcf)
Jeremy Allison [Thu, 5 Jan 2012 21:54:29 +0000 (13:54 -0800)]
Fix bug #8687 - net memberships usage info is wrong
Typo in usage.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Jan 6 00:30:20 CET 2012 on sn-devel-104
(cherry picked from commit
0453544900ef2ebff7a3c677d4048ef530713b64)
Andreas Schneider [Mon, 21 Nov 2011 17:19:43 +0000 (18:19 +0100)]
s3-libsmb: Don't duplicate kerberos service tickets.
This fixes bug #8628.
Each time we do a client connection. Each time we call to function to
get the service ticket from the cache we duplicate it. So with each
connection we end up with one or three duplicated tickets.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Dec 15 19:30:42 CET 2011 on sn-devel-104
(cherry picked from commit
d0330c7dd64b320cd86e2341b31da6be81ba829b)
(cherry picked from commit
60cb113d98d98200b1d8b279591c930e6b0d1857)
Jeremy Allison [Sat, 31 Dec 2011 05:19:08 +0000 (21:19 -0800)]
Final part of fix for bug #8679 - recvfile code path using splice() on Linux leaves data in the pipe on short write.
The code to set a DOS error on short writeX return is amazingly
legacy code, and also breaks the reply as fixup_chain_error_packet()
enforces a 2-byte wct on any reply where smb_rcls != 0.
Found in testing by Andrew Bartlett. Thanks Andrew !
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Dec 31 08:05:35 CET 2011 on sn-devel-104
(cherry picked from commit
e39df67669f61056692736db9c8dc16fbf2c3624)
(cherry picked from commit
627f57f0714f257c6082b21447d122935c6e92e2)
Jeremy Allison [Sat, 31 Dec 2011 04:45:10 +0000 (20:45 -0800)]
Third part of fix for bug #8679 - recvfile code path using splice() on Linux leaves data in the pipe on short write.
Fix default_sys_recvfile() to correctly cope with
short writes. Return the amount written. Return
-1 and set errno if no data could be written.
(cherry picked from commit
5e6263960aaf1a5f9993cb7bb5646d36ff92b9cc)
(cherry picked from commit
ec9b07e84e806705e22f0cf2eb527fed14efac55)
Jeremy Allison [Sat, 31 Dec 2011 04:23:00 +0000 (20:23 -0800)]
Second part of fix for bug #8679 - recvfile code path using splice() on Linux leaves data in the pipe on short write.
Split out the functionality of drain_socket() into a separate
function from default_sys_recvfile().
(cherry picked from commit
a5715420e37b98038fe8f2c3028e4c6938400eed)
(cherry picked from commit
7924e459b6677ba3500afff4b78f797e1e0ad83d)
Jeremy Allison [Sun, 25 Dec 2011 05:12:09 +0000 (21:12 -0800)]
Fix bug #8679 - recvfile code path using splice() on Linux leaves data in the pipe on short write
Bug found and fix suggested by Andrew Bartlett.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sun Dec 25 07:46:38 CET 2011 on sn-devel-104
(cherry picked from commit
eb617374a673bb1189dd9b6bccbf3f1d9fb91010)
(cherry picked from commit
b3f344b5b52096715eb5670b146f477a67af8245)
Masafumi Nakayama [Wed, 2 Nov 2011 09:35:19 +0000 (10:35 +0100)]
s3-cli: fix bug 563, >8GB tar on BE machines
Borrows on existing patches proposed by Craig Barratt and Brad Ellis.
Signed-off-by: David Disseldorp <ddiss@suse.de>
Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Tue Jan 3 18:31:28 CET 2012 on sn-devel-104
(cherry picked from commit
909056a2daacd961b40158b86bc117650a897054)
(cherry picked from commit
ab62ee622358362d4d2b16c7fec9a1f2cf7b8d8d)
Andreas Schneider [Tue, 3 Jan 2012 15:55:25 +0000 (16:55 +0100)]
s3-winbind: Fix segfault if we can't map the last user.
This fixes bug #8678.
The issue is caused by bug #8608.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Jan 4 18:30:53 CET 2012 on sn-devel-104
(cherry picked from commit
b9d208bdaa9da2a5ae534481865efc881b851b01)
(cherry picked from commit
23db6e7cf65bdd3974a4857dda0be6ad7d758b9a)
Andreas Schneider [Tue, 3 Jan 2012 15:54:39 +0000 (16:54 +0100)]
s3-winbind: Move finding the domain to it's own function.
This the first part to fix bug #8678.
(cherry picked from commit
5075e565684627dfbd23f715da344b4365351ccb)
(cherry picked from commit
2fca06a63d47619f2b6902b1c8601021843c4b95)
Jeremy Allison [Fri, 2 Dec 2011 18:55:40 +0000 (10:55 -0800)]
Fix bug #8644 - vfs_acl_xattr and vfs_acl_tdb modules can fail to add inheritable entries on a directory with no stored ACL.
If referring to an fsp sbuf can be left as an uninitialized variable,
causing the 'is_directory' variable to be false when it should be true.
(cherry picked from commit
16c0d52842386fc2ebf975166b57b888d36796c5)
Björn Jacke [Sat, 10 Dec 2011 12:53:42 +0000 (13:53 +0100)]
s3/doc: document the ignore system acls option of vfs_acl_xattr and vfs_acl_tdb
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Sat Dec 10 15:30:46 CET 2011 on sn-devel-104
(cherry picked from commit
f452add2231906742c9fd119371cd4fd81a1bdd6)
Fix bug #8652 (vfs_acl man pages miss "ignore system acls" option).
Fix bug #8652 (vfs_acl man pages miss "ignore system acls" option).
(cherry picked from commit
ceeab5c66cef2c5aa7931329a9976c8173f44467)
Volker Lendecke [Thu, 17 Nov 2011 21:24:24 +0000 (22:24 +0100)]
s3: Fix bug 8371
ndr_set_flag or's in the given flag (ALIGN4). At this point, ndr->flags
contains NOALIGN, which will persist. In ndr_push_DATA_BLOB NOALIGN overrides
everything else, so that the ALIGN4 is not respected.
(cherry picked from commit
6cb605364e83fe0c5562c9b0920408c697e4fc3e)
Andreas Schneider [Mon, 5 Dec 2011 20:33:25 +0000 (12:33 -0800)]
s3-winbind: Add an update function for winbind cache.
With
57b3d32 we changed the format for the winbind cache database and
the code deleted the database for the upgrade. As this database holds
also cached credentials, removing it is not an option. We need to update
from version 1 to version 2.
Fix bug #8643 (A Samba update to 3.6 deletes the winbind cache with cached
credentials).
(cherry picked from commit
df616e928e08646bbc234af673a496117535c6d8)
Volker Lendecke [Wed, 30 Nov 2011 17:51:27 +0000 (18:51 +0100)]
s3: Attempt to fix the vfs_commit module
This bug went in in 2007. I wonder how much this module is actually used....
Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Nov 30 21:46:09 CET 2011 on sn-devel-104
(cherry picked from commit
b638abf70a3c9b2815344454946c0931295551be)
(cherry picked from commit
33a8e161401b889feca19b2bb9222509cf77c37d)
Jeremy Allison [Tue, 29 Nov 2011 19:55:39 +0000 (11:55 -0800)]
Fix bug 8631 - POSIX ACE x permission becomes rx following mapping to and from a DACL Reported by David Disseldorp. Fix based on a patch by David.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Tue Nov 29 22:32:27 CET 2011 on sn-devel-104
(cherry picked from commit
6bf97ea3bc70745f64f82251cbce443f2637c703)
(cherry picked from commit
28fa8d8d777f3da40fde2fb57cd06659f76cf658)
Richard Sharpe [Mon, 14 Nov 2011 15:47:38 +0000 (07:47 -0800)]
Improve configure.in so it can be used outside the Samba source tree.
Autobuild-User: Richard Sharpe <sharpe@samba.org>
Autobuild-Date: Thu Nov 17 07:00:38 CET 2011 on sn-devel-104
(cherry picked from commit
f50aa988c201c2fe78e467f1a419bedc741e1d31)
Fix bug #8607 (The configure.in in examples/VFS does not easily allow building
modules outside the Samba source tree).
(cherry picked from commit
7db7ea684a17b70ecae31c70c1b2e647ea0fafa1)
Stefan Metzmacher [Fri, 18 Nov 2011 07:40:18 +0000 (08:40 +0100)]
s3:libsmb: only align unicode pipe_name (bug #8586)
metze
(cherry picked from commit
48bcb8c846532ccd5489ef705182fb81c5278b04)
(cherry picked from commit
10f45157037edc528926ae7dc4a40909566c6480)
Andreas Schneider [Mon, 14 Nov 2011 09:01:31 +0000 (10:01 +0100)]
s3-winbind: Don't fail on users without a uid.
This fixes bug #8608.
If you join samba with idmap_ad backend to an AD. When you try to
enumerate users with 'getent passwd' and the user doesn't have a uid
set, then getent is aborted cause of NT_STATUS_NONE_MAPPED. If we can't
map a user we should not stop but continue enumerating users.
This normally happens with the default user 'krbtgt' with idmap_ad but
could also happen with other backends.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Tue Nov 15 16:52:04 CET 2011 on sn-devel-104
(backported from commit
10b285ccc29b106f164a6c18116e237634867717)
Signed-off-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit
a64f88f4e97f0f9c006fe6f0cefc0a61efc1ca98)
Andrew Bartlett [Mon, 9 May 2011 15:43:45 +0000 (17:43 +0200)]
lib/util/ Fix crash bug caused by gfree_debug()
The issue is that we should reset the debug_num_classes to 0 when we
un-initialise the debug system.
Andrew Bartlett
(cherry picked from commit
5db0cd55d4db9cc71f32dc0097e2f014c22967bc)
Fix bug #8623 (Crash when trying to browse samba printers).
(cherry picked from commit
3651471288ebd05108c9cd7f1bdbb844829244fb)
Björn Jacke [Fri, 18 Nov 2011 12:40:17 +0000 (13:40 +0100)]
s3: allow to set TCP_NODELAYACK socket option on AIX (#8616)
this is the AIX way to disable delayed ACKs, the same like TCP_QUICKACK on
Linux
this is a backport of
383a918322c1edd1977fdbce19e52e8c8e6ffac1
(cherry picked from commit
d8091581f7e55a8147c9ec5e8a30481596093d27)
Karolin Seeger [Thu, 17 Nov 2011 20:23:09 +0000 (21:23 +0100)]
s3/packaging: Fix rpm build issues on RHEL4.
Second part of a fix for bug #7705 (RHEL samba.spec broken - and fix).
Based on patches of Jason Haar and Daniël van Eeden. Thanks a lot!
Karolin
Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Fri Nov 18 22:13:06 CET 2011 on sn-devel-104
(cherry picked from commit
1d471ee393b0a0c1f9cc4256217acabcd98a5dbf)
(cherry picked from commit
b0e5fb69df8b66544afc29d0b3dac5454d04fe3e)
Karolin Seeger [Thu, 17 Nov 2011 20:02:30 +0000 (21:02 +0100)]
s3/packaging: Fix rpm build issues on RHEL.
Fix bug #7705 (RHEL samba.spec broken - and fix).
Based on patches of Jason Haar and Daniël van Eeden. Thanks a lot!
Karolin
Autobuild-User: Karolin Seeger <kseeger@samba.org>
Autobuild-Date: Thu Nov 17 23:05:28 CET 2011 on sn-devel-104
(cherry picked from commit
32e825d60df26fa1d4cf5c8c7cb37ca0523847ca)
(cherry picked from commit
f89cdef51633402006dcad17b49e596a41905a40)
Jeremy Allison [Thu, 3 Nov 2011 21:30:11 +0000 (14:30 -0700)]
Fix bug #8562 - talloc: double free error.
Ensure we don't access an undefined pointer.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov 4 00:09:46 CET 2011 on sn-devel-104
(cherry picked from commit
767c54d8dd9596718579699398392ae234b40aa2)
(cherry picked from commit
5935630fcd15e2618b854fa3c78f3e500690cf35)
Matthieu Patou [Fri, 21 Oct 2011 14:11:41 +0000 (16:11 +0200)]
libcli-cldap: avoid the case local == remote == NULL (cherry picked from commit
4d2d33ee09941ddb211e21788c01d886730224c2)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
The last 2 patches address bug #8600 (cldap doesn't work over ipv6).
(cherry picked from commit
d8bc1584df47673ba7f6933af178f8669a61262b)
Stefan Metzmacher [Fri, 21 Oct 2011 07:49:30 +0000 (09:49 +0200)]
libcli/cldap: make sure the local and remote address family matches
metze
Signed-off-by: Matthieu Patou <mat@matws.net>
(cherry picked from commit
66530e91498cfa77a9d2e3a031f8a2e1c5ee6804)
(cherry picked from commit
b301e0e199ec91bdf07a5022e37181d8e570ef3d)
Stefan Metzmacher [Fri, 11 Nov 2011 01:10:00 +0000 (02:10 +0100)]
s3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)
Otherwise we may get unexpected results.
This is a fix that was missing in commit
95595dd93fd04999fcf56ecaab7c29b064d021f8
(s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326))
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov 9 10:13:32 CET 2011 on sn-devel-104
(cherry picked from commit
4b31c4273c45faa639445614061f3da548eb8505)
(cherry picked from commit
b5e1b792366dc769389353cdbb63466f6867efb0)
Stefan Metzmacher [Tue, 8 Nov 2011 07:25:16 +0000 (08:25 +0100)]
s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326)
Print shares doesn't support CAP_LARGE_WRITEX, while it's negotiated
by the file server part.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Nov 8 17:01:36 CET 2011 on sn-devel-104
(cherry picked from commit
95595dd93fd04999fcf56ecaab7c29b064d021f8)
(cherry picked from commit
2ce6d51713bb47059814c720307f337fd380fc1c)
Jeremy Allison [Tue, 15 Nov 2011 19:27:56 +0000 (11:27 -0800)]
Ensure we correctly calculate reply credits over all returned
SMB2 replies, and do as Windows does and return the total in the
last SMB2 reply. Fixes an issue found by Christian M Ambach <christian.ambach@de.ibm.com>
(and thanks to Christian for the initial patch this was based on).
(cherry picked from commit
65566dfa8629136eaf0dc1491502dc651d1a4858)
Fix bug #8614 (SMB2: not granting credits for all requests in a compound
request).
(cherry picked from commit
35564365f49fda6505d6e350fa8b0e5ef1a4e33c)
Stefan Metzmacher [Thu, 10 Nov 2011 11:20:20 +0000 (12:20 +0100)]
s3:smb2_flush: outbody only needs 4 bytes
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 14 10:01:30 CET 2011 on sn-devel-104
(cherry picked from commit
72cabbbe50a36986dde823f0ba60abf9052c535a)
Fix bug #8579 (smb2_flush sends uninitialized memory).
(cherry picked from commit
5336e301db8f34325338d2b3bcef2cb614e6dddd)
Jeremy Allison [Tue, 15 Nov 2011 23:42:50 +0000 (15:42 -0800)]
Fix bug #8561 - Password change settings not fully observed.
Based on commit
3ede4ffe969f806ba2363b62c09673c32a4ec296 in master
(with a change to set the header prototype in the correct file).
(cherry picked from commit
fc394c33e3c201b0db620d9c46afedf852cec9a8)
Stefan Metzmacher [Tue, 8 Nov 2011 16:50:43 +0000 (17:50 +0100)]
s3:smb2_server: grant credits in async interim responses (bug #8357)
The first fix for bug #8357 intruduced a regression, so that we no
longer grant credits for real async interim responses with
STATUS_PENDING.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov 9 11:56:29 CET 2011 on sn-devel-104
(cherry picked from commit
ffbd1ed2797616226a7987efd4b4dd4275c8c9d0)
(cherry picked from commit
ec72b6366701952e7d7574f22997b59858f887b0)
Stefan Metzmacher [Wed, 9 Nov 2011 15:04:09 +0000 (16:04 +0100)]
s3:smbd: don't limit the number of open dptrs for smb2 (bug #8592)
This fixes a crash bug that is triggered, when a client has more than
256 directory handles with searches.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 14:08:14 CET 2011 on sn-devel-104
(cherry picked from commit
22ddbb50534aa73240a171732d4ac1fa884fa412)
(cherry picked from commit
b3f98fc0366cd27c9e043591c70e283423fcd77e)
Stefan Metzmacher [Wed, 9 Nov 2011 14:59:22 +0000 (15:59 +0100)]
s3:smbd: fully construct the dptr before allocating a dnum in the bitmap
metze
(cherry picked from commit
39bb5a62977261d0926f56b792aacaa5e772ff6f)
(cherry picked from commit
798b63addf6aaecbe5b6241975f78103a56b1442)
Stefan Metzmacher [Thu, 10 Nov 2011 09:39:34 +0000 (10:39 +0100)]
s3:smbd: avoid string_set() in dir.c
And do some more error checks.
metze
(cherry picked from commit
7644547a5523b77bd49d9a5d979d5e4939153401)
(cherry picked from commit
785c0741af53cb142fc3ec7e55d999477d44d9bc)
Günther Deschner [Tue, 8 Nov 2011 15:00:10 +0000 (16:00 +0100)]
samr: filterModuleName is a lsa_String in userPwdChangeFailureInformation.
The entire marshalling of samr_ChangePasswordUser3 broke with
c2685cdedb430ae75a94e86f34484292b4269363.
Matthias, the bad effect of this change was that actually all failed password
change attempts will always return NT_STATUS_OK because the last 4 bytes (the
resulting status code) were not marshalled anymore.
Guenther
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov 9 00:41:13 CET 2011 on sn-devel-104
(cherry picked from commit
8a18edf1c2d553105cfcadec4d892e4e5a0fdba1)
The last 2 patches address bug #8591 (samr_ChangePasswordUser3 IDL incorrect).
(cherry picked from commit
4d52675716997057941390c5711850c36786ef15)
Günther Deschner [Tue, 8 Nov 2011 14:58:34 +0000 (15:58 +0100)]
s4-smbtorture: demonstrate how broken our samr_ChangePasswordUser3 marshalling is...
Guenther
(cherry picked from commit
bfe084bd8bbdfa0a0fa31521584f3bc142785fb8)
(cherry picked from commit
9c7925120a06a3511f88d768fd9c459023d3c0fe)
Christian Ambach [Thu, 20 Oct 2011 16:53:02 +0000 (18:53 +0200)]
s3:idmap_autorid: document allocation pool
document the need that excessive use of local users/group might
require increasing the rangesize
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Fri Oct 21 18:04:50 CEST 2011 on sn-devel-104
The last 4 patches address bug #8444 (idmap_autorid does not have allocation
pool).
(cherry picked from commit
a0cfd1983fae8b0090bcae36a11dad4531e48f49)
Christian Ambach [Thu, 20 Oct 2011 16:44:48 +0000 (18:44 +0200)]
s3:idmap_autorid: add an allocation range to autorid
this is needed to allocate gids for BUILTIN\Users and
BUILTIN\Administrators and for local users/group that
admins might want to create
autorid will now allocate one range for this purpose
and can so give out as many uids and gids as the
configured rangesize allows
(cherry picked from commit
a98095601dc585a6c49813399466a455c43fc0fc)
Christian Ambach [Thu, 20 Oct 2011 16:39:30 +0000 (18:39 +0200)]
s3:idmap_autorid: move HWM initialization into a function
we will need some more HWM soon, so move out initialization and
optimize the logic using the new interface of dbwrap_fetch_uint32
(cherry picked from commit
31593bcd74f4063217190012a83e1003e29fdba7)
Christian Ambach [Thu, 20 Oct 2011 16:22:19 +0000 (18:22 +0200)]
s3:idmap_autorid: use strings as parameter for range allocator
this prepares for allocation of non-domain ranges that cannot be
expressed by a SID (e.g. an allocation pool)
(cherry picked from commit
188a12e1df2a5a3ae39cb2e25c87ae2093a62853)
Andreas Schneider [Wed, 2 Nov 2011 15:53:27 +0000 (16:53 +0100)]
systemd: Fix dependencies.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Nov 4 12:36:04 CET 2011 on sn-devel-104
(cherry picked from commit
4f3e86f62398218c454b979aaad75c7d7d3d8546)
The last 3 patches address bug #8575 (Add systemd files to 3.6).
(cherry picked from commit
81823a0e9d6cadd21e14c9f9ce16cc7ebf849e90)
David Disseldorp [Thu, 3 Nov 2011 11:54:00 +0000 (12:54 +0100)]
pkg: add comments to the systemd sysconfig file
Autobuild-User: David Disseldorp <ddiss@samba.org>
Autobuild-Date: Thu Nov 3 15:11:27 CET 2011 on sn-devel-104
(cherry picked from commit
0f61eb5e299abfa0ffe5e0dd92a40e582021a5b2)
(cherry picked from commit
a29a1be90608541c1f9f0142bb5b05965a2c4a34)
Andreas Schneider [Thu, 27 Oct 2011 15:11:19 +0000 (17:11 +0200)]
Add systemd service files.
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Oct 28 11:34:27 CEST 2011 on sn-devel-104
(cherry picked from commit
7d7ba3ba40895090d9bd791f210f89c5d5d2582e)
(cherry picked from commit
7c2ec923a1b904ceec7d5c18abb58d498ae201f4)
Stefan Metzmacher [Fri, 4 Nov 2011 11:52:44 +0000 (12:52 +0100)]
s3:libsmb: the workgroup in the non-extended-security negprot is not aligned (#8573)
I've tested the fix against NT4 sp6a, W2K sp4, W2K8R2 and Win8pre0.
metze
(similar to commit
aea76a3aaa7ea52f563e7bc8a8ed60d9651f9e34)
(cherry picked from commit
d0272d6ff1e2e33d710d5bee25a2781c67edc3a5)
Björn Baumbach [Mon, 7 Nov 2011 13:24:40 +0000 (14:24 +0100)]
s3-wafbuild: Fix inotify detection (bug 8580)
Enable inotify if sys or kernel inotify is available.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov 7 16:28:38 CET 2011 on sn-devel-104
(cherry picked from commit
b9e6c48678624ba5335d00906c558ea9e0086699)
(cherry picked from commit
8929b72433aea584f76519b0eabdab8b6423f5cf)
Björn Baumbach [Mon, 7 Nov 2011 11:42:28 +0000 (12:42 +0100)]
s3-build: Fix inotify detection (bug 8580)
Enable inotify if sys or kernel inotify is available.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
846809853acd53a733fa6057436c6e51843d8fab)
(cherry picked from commit
5efb2cecf80bf7911755e583de59f4a015b864e8)
Stefan Metzmacher [Tue, 1 Nov 2011 17:55:17 +0000 (10:55 -0700)]
s3:smb2_server: FLAG_CHAINED means we always use the last session_id and tid
Based on master commit
91648aeb6409787c7766943225f5c7a9c695aa0b.
metze
The last 4 patches address bug #8560 (SMB2 doesn't handle compound request
headers in the same way as Windows).
(cherry picked from commit
2971e74fd522998d30b2923a2a308d8e28c04aa9)
Stefan Metzmacher [Tue, 30 Aug 2011 09:48:16 +0000 (11:48 +0200)]
smb2_constants: add SMB2_HDR_CREDIT_CHARGE
SMB2_HDR_EPOCH was never used and SMB 2.10 uses it as
SMB2_HDR_CREDIT_CHARGE.
We keep SMB2_HDR_EPOCH as alias for now, until all callers
are fixed.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Aug 30 23:49:56 CEST 2011 on sn-devel-104
(cherry picked from commit
480a031c5b9a2ffe1e03e3fcb197e526e6d69e72)
(cherry picked from commit
7d297fa7ab21d265bdb9610068f4b6169ea0a5f9)
Stefan Metzmacher [Mon, 31 Oct 2011 22:15:09 +0000 (15:15 -0700)]
s3:smb2_server: don't reset the tid and session id in the out hdr of compound requests
Windows also leaves tid (0xFFFFFFFF) and session id (0xFFFFFFFFFFFFFFFF)
as the client requested them.
Based on commit
8d07d7148bf47ea14e62d39ed8a8cc4f1366810e from master.
metze
(cherry picked from commit
ab81a8df620a2d7fcb3852834353a0300dcb9f45)
Stefan Metzmacher [Thu, 27 Oct 2011 14:42:44 +0000 (16:42 +0200)]
s3:smb2_server: echo the SMB2_HDR_CREDIT_CHARGE and SMB2_HDR_SIGNATURE fields
Windows just echos back the given values by default.
metze
(cherry picked from commit
c7d3b6b2c38711943910aebff72b0188b0c346db)
(cherry picked from commit
3a9154c67647d209ad5300acfcf9d675d0a2e8e0)
Christian Ambach [Fri, 4 Nov 2011 16:34:48 +0000 (17:34 +0100)]
s3:smbd increase a debug level
logging disconnected clients with level 1 swamps the logs
(This fixes Bug #8585 Disconnecting clients swamp the logs)
(cherry picked from commit
0f836e532abcd7e24fd65d885a5b5c1d94ebefa1)
Henry Wong [Fri, 4 Nov 2011 18:20:10 +0000 (11:20 -0700)]
Properly fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.
Ensure we correctly null out the referenced pointer when we decrease the ref. count.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Nov 4 21:12:13 CET 2011 on sn-devel-104
(cherry picked from commit
51c86c8e67c3b026f49136f5b6743c279cc206d2)
(cherry picked from commit
cb6795bea659e884e23173960e68a2f970fc5dd3)
Günther Deschner [Thu, 3 Nov 2011 19:55:08 +0000 (20:55 +0100)]
examples: Fix perl path.
Fix bug #8176 (wall.perl example uses /usr/loca/bin for pat to perl binary).
(cherry picked from commit
2bec3bd80fc16699dfe8cc6aa3afd97881b8bfe9)
(cherry picked from commit
b01b1faafe32fbb88739ae8aaaf9f2fe5e1dcdcf)
Andreas Schneider [Thu, 27 Oct 2011 09:21:08 +0000 (11:21 +0200)]
s3-netlogon: Fix setting the machinge account password.
This bug has been found with uid wrapper.
(cherry picked from commit
bda9752b1036c4d4db76a526a79a091419bf757c)
Fix bug #8550 (Calls inside netr_set_machine_account_password() to set the
machine account password must be done as root).
(cherry picked from commit
3b4268ff0929740a2845a02a5b6f2596ff31f7f9)
Jeremy Allison [Fri, 28 Oct 2011 19:29:54 +0000 (12:29 -0700)]
Fix bug #8548 - winbind_samlogon_retry_loop ignores logon_parameters flags.
Fix confirmed by reporter.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Oct 28 23:04:47 CEST 2011 on sn-devel-104
(cherry picked from commit
f30f71c14a0b89dea296910ac9b92d3ae4016613)
(cherry picked from commit
110ee604f5d632a38af4a61295f7100fcfbd1d0a)
Jeremy Allison [Sat, 22 Oct 2011 01:08:46 +0000 (18:08 -0700)]
Fix bug #8542 - smbclient posix_open command fails to return correct info on open file.
(cherry picked from commit
d27f5a277ef47c5ff94e402930680b37e8f4d592)
Jeremy Allison [Sat, 22 Oct 2011 01:35:15 +0000 (18:35 -0700)]
Third part of fix for bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
Missed passing ucf_flags instead of hard coded flags in findfirst call.
(cherry picked from commit
49d2a796bed0273327d8919755023c4dbd6d8232)
(cherry picked from commit
074b9462e4b7b2b6e474566016e93a87c77e1599)
Jeremy Allison [Sat, 22 Oct 2011 00:46:12 +0000 (17:46 -0700)]
Second part of fix for bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
The statcache has to do lstat instead of stat when returning cached
posix pathnames.
(cherry picked from commit
305d7d7f7d76e37d82ce6ac257f178ce654b26db)
(cherry picked from commit
6529ac5424f75943b612daddaefb765b44aecdf7)
Jeremy Allison [Fri, 21 Oct 2011 21:12:41 +0000 (14:12 -0700)]
Fix bug #8541 - readlink() on Linux clients fails if the symlink target is outside of the share.
The key is to only allow the lookup to succeed if it's a UNIX level lookup or readlink,
but disallow all other operations.
(cherry picked from commit
d2ec9d20858b8e5256bf8339395c6f47793e0975)
(cherry picked from commit
a7d2815e97218c2b7eccbac25f78f2c2fae45a79)
Jeremy Allison [Mon, 25 Jul 2011 23:12:45 +0000 (16:12 -0700)]
Use existing ISDOT and ISDOTDOT macros.
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu Jul 28 02:09:20 CEST 2011 on sn-devel-104
(cherry picked from commit
d82256ca119eb8315cc69ba725ba71c386caa901)
(cherry picked from commit
99b4d6912570cc210035b2222ad57f4279792a2d)
Günther Deschner [Wed, 26 Oct 2011 13:03:23 +0000 (15:03 +0200)]
s3-netapi: remove pointless use_memory_krb5_ccache.
This breaks the ABI.
Guenther
See bug #7465 for more details.
(cherry picked from commit
2970d44442c2e6e80fb18f5c669d347e5f5be62e)
Björn Jacke [Thu, 20 Oct 2011 19:39:38 +0000 (21:39 +0200)]
s3:Makefile: make DSO_EXPORTS_CMD more portable (#8531)
It sems like every not completely trivial sed expression should be tested with
Solaris' sed. Its regexp engine is way more limited than the one of GNU
sed. Thanks to Michael Pelletier for finding this! This fixes bug #8531
Autobuild-User: Björn Jacke <bj@sernet.de>
Autobuild-Date: Thu Oct 20 23:15:05 CEST 2011 on sn-devel-104
(cherry picked from commit
37be1df3d7534c2cc8e1e25614164c2178372b94)
(cherry picked from commit
763ad499aa4423c5e68a75f20f2ba8ee967e5984)
Jeremy Allison [Wed, 12 Oct 2011 00:00:08 +0000 (17:00 -0700)]
Add new contributing FAQ announcing acceptance of corporate (C).
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 12 03:46:41 CEST 2011 on sn-devel-104
(cherry picked from commit
bd01ae227bc567fd7953e446236364fc4d110a48)
(cherry picked from commit
f165b54828f451943b172b8d2d1bfd15f37b7fdf)
Brad Smith [Wed, 12 Oct 2011 08:23:58 +0000 (04:23 -0400)]
Fix sys_fseek wrapper
Signed-off-by: Günther Deschner <gd@samba.org>
Fix bug #8525 (Bug with sys_fseek() wrapper on *BSD / OS X).
(cherry picked from commit
0f6b4b68db334028a5fa60c8615879a033286a4b)