mptcp: don't account accept() of non-MPC client as fallback to TCP
authorDavide Caratti <dcaratti@redhat.com>
Fri, 29 Mar 2024 12:08:52 +0000 (13:08 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 2 Apr 2024 04:25:00 +0000 (21:25 -0700)
commit7a1b3490f47e88ec4cbde65f1a77a0f4bc972282
treed5a69f1b42d3d3d0165e6445d0e5a6777a4d9963
parentfcf4692fa39e86a590c14a4af2de704e1d20a3b5
mptcp: don't account accept() of non-MPC client as fallback to TCP

Current MPTCP servers increment MPTcpExtMPCapableFallbackACK when they
accept non-MPC connections. As reported by Christoph, this is "surprising"
because the counter might become greater than MPTcpExtMPCapableSYNRX.

MPTcpExtMPCapableFallbackACK counter's name suggests it should only be
incremented when a connection was seen using MPTCP options, then a
fallback to TCP has been done. Let's do that by incrementing it when
the subflow context of an inbound MPC connection attempt is dropped.
Also, update mptcp_connect.sh kselftest, to ensure that the
above MIB does not increment in case a pure TCP client connects to a
MPTCP server.

Fixes: fc518953bc9c ("mptcp: add and use MIB counter infrastructure")
Cc: stable@vger.kernel.org
Reported-by: Christoph Paasch <cpaasch@apple.com>
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/449
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://lore.kernel.org/r/20240329-upstream-net-20240329-fallback-mib-v1-1-324a8981da48@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/protocol.c
net/mptcp/subflow.c
tools/testing/selftests/net/mptcp/mptcp_connect.sh