Karolin Seeger [Thu, 8 Aug 2013 10:00:04 +0000 (12:00 +0200)]
VERSION: Disable git snapshots for the 4.1.0rc2 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Thu, 8 Aug 2013 09:54:19 +0000 (11:54 +0200)]
WHATSNEW: Add release notes for Samba 4.1.0rc2.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Thu Aug 8 13:45:41 CEST 2013 on sn-devel-104
Ralph Wuerthner [Wed, 31 Jul 2013 23:33:48 +0000 (16:33 -0700)]
Ensure gpfs kernel leases are wrapped in a become_root()/unbecome_root() pair.
Ensures correct lease owner for signal delivery.
Signed-off-by: Ralph Wuerthner <ralphw@de.ibm.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Aug 1 03:57:11 CEST 2013 on sn-devel-104
The last 2 patches address bug #10064 - Linux kernel oplock breaks can miss
signals.
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Wed Aug 7 14:56:04 CEST 2013 on sn-devel-104
Jeremy Allison [Wed, 31 Jul 2013 23:32:20 +0000 (16:32 -0700)]
Wrap setting leases in become_root()/unbecome_root() to ensure correct delivery of signals.
Remove workaround for Linux kernel bug https://bugzilla.kernel.org/show_bug.cgi?id=43336
as we don't need to set capabilities when we're already root.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
Jeremy Allison [Tue, 9 Jul 2013 23:37:48 +0000 (16:37 -0700)]
Add torture tests to raw.eas to check sending Windows invalid names in the middle of an EA list.
Add torture tests to probe the set of invalid
Windows EA names.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 16 Jul 2013 16:14:12 +0000 (09:14 -0700)]
Reply with correct trans2 message on a setpathinfo with a bad EA name.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 16 Jul 2013 18:05:10 +0000 (11:05 -0700)]
Ensure we do pathname processing before SD and EA processing in NTTRANS_CREATE.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 9 Jul 2013 22:54:39 +0000 (15:54 -0700)]
Ensure we can't create a file using NTTRANS with an invalid EA list.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 9 Jul 2013 22:59:53 +0000 (15:59 -0700)]
Ensure we can't create a file using TRANS2_OPEN with an invalid EA list.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Wed, 10 Jul 2013 19:18:36 +0000 (12:18 -0700)]
Add error map of STATUS_INVALID_EA_NAME -> ERRDOS, ERRbadfile
(from Windows2012 tests).
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Wed, 10 Jul 2013 19:38:41 +0000 (12:38 -0700)]
Add the ability to send an NTSTATUS result back with a trans2 reply so we can return a parameter block with an error code.
This is needed when returning a STATUS_INVALID_NAME result (tested
from Windows 2012).
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 9 Jul 2013 23:02:50 +0000 (16:02 -0700)]
Ensure we can't create a file using SMB2_CREATE with an invalid EA list.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 9 Jul 2013 23:21:18 +0000 (16:21 -0700)]
Ensure we never return an EA name to a Windows client it can't handle.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 9 Jul 2013 22:52:47 +0000 (15:52 -0700)]
Ensure set_ea cannot set invalid Windows EA names.
Bug 9992 - Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Jeremy Allison [Tue, 9 Jul 2013 22:50:47 +0000 (15:50 -0700)]
Add ea_list_has_invalid_name() function.
Invalid character list probed from Windows Server 2012.
Bug 9992: Windows error 0x800700FE when copying files with xattr names containing ":"
Signed-off-by: Jeremy Allison <jra@samba.org>
Andreas Schneider [Fri, 26 Jul 2013 13:36:02 +0000 (15:36 +0200)]
nsswitch: Add OPT_KRB5CCNAME to avoid an error message.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10048
Reviewed-by: Günther Deschner <gd@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Jul 26 17:40:26 CEST 2013 on sn-devel-104
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Mon Aug 5 22:14:36 CEST 2013 on sn-devel-104
Alexander Werth [Tue, 9 Jul 2013 15:14:08 +0000 (17:14 +0200)]
s3: Remove old mode special substitution.
The mode special substitution now happens in a separate function.
The substitution at this point is unnecessary.
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Christian Ambach <ambi@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Tue Jul 16 00:52:26 CEST 2013 on sn-devel-104
(cherry picked from commit
9b2aa351ceb756d6ea63f3158f0e983ae7262da8)
Fix bug #10045 - Remove a redundant inlined substitution of ACLs.
Stefan Metzmacher [Wed, 10 Jul 2013 12:48:18 +0000 (14:48 +0200)]
s4:server: avoid calling into nss_winbind from within 'samba'
The most important part is that the 'winbind_server' doesn't
recurse into itself. This could happen if the krb5 libraries
call getlogin().
As we may run in single process mode, we need to set
_NO_WINBINDD=1 everywhere, the only exception is the forked
'smbd'.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jul 10 23:18:06 CEST 2013 on sn-devel-104
(cherry picked from commit
596b51c666e549fb518d92931d8837922154a2fe)
The last 4 patches address bug #9820 - crash of winbind after "ls -l
/usr/local/samba/var/locks/sysvol".
Stefan Metzmacher [Tue, 9 Jul 2013 14:38:59 +0000 (16:38 +0200)]
s4:rpc_server: make sure we don't terminate a connection with pending requests (bug #9820)
Sadly we may have nested event loops, which won't work correctly with
broken connections, that's why we have to do this...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Jul 10 08:47:38 CEST 2013 on sn-devel-104
(cherry picked from commit
e6a58d370403e818bc2cfb8389751b78adcc14fd)
Andrew Bartlett [Thu, 27 Jun 2013 01:28:03 +0000 (11:28 +1000)]
s4-winbindd: Do not terminate a connection that is still pending (bug #9820)
Instead, wait until the call attempts to reply, and let it terminate then
(often this happens in the attempt to then write to the broken pipe).
Andrew Bartlett
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
2505d48e4fbcd8a805a88ad0b05fb1a16a588197)
Andrew Bartlett [Thu, 27 Jun 2013 01:27:03 +0000 (11:27 +1000)]
service_stream: Log if the connection termination is deferred or not (bug #9820)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
df929d6feb857668ad9da277213e9fae1480ff63)
Gregor Beck [Thu, 1 Aug 2013 12:16:24 +0000 (14:16 +0200)]
Fix bug 9678 - Windows 8 Roaming profiles fail
Windows 8 tries to set 'ATTRIBUTE_SECURITY_INFORMATION' on some
dirs. Ignoring it makes roaming profiles work again.
Just like w2k3 gracefully ignore all the other bits.
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Gregor Beck [Wed, 31 Jul 2013 13:28:51 +0000 (15:28 +0200)]
security.idl: add new security_secinfo bits
[MS-DTYP].pdf 2.4.7
Signed-off-by: Gregor Beck <gbeck@sernet.de>
Andrew Bartlett [Sun, 14 Apr 2013 03:32:49 +0000 (13:32 +1000)]
samba-tool dbcheck: Correctly remove deleted DNs in dbcheck
The previous pattern never matched, as it was a typo.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Tue Jul 30 12:55:00 CEST 2013 on sn-devel-104
(cherry picked from commit
7615b2549d9549683978cb3e85b926e2ba63e294)
The last 4 patches address bug #9029 - Replication with --domain-crictical-only
fails to fill in backlinks.
Andrew Bartlett [Tue, 4 Jun 2013 10:22:31 +0000 (20:22 +1000)]
dsdb: Include MS-ADTS doc references on deleted object contstraints
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
f2afdb61698c37389be286f9443471d4aeba49b8)
Andrew Bartlett [Mon, 3 Jun 2013 07:51:41 +0000 (17:51 +1000)]
dsdb tests: Add member/memberOf checking to delete_objects testing
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
a9e565a5a4478f7b923f35311e170de2044ff848)
Andrew Bartlett [Tue, 4 Jun 2013 09:57:06 +0000 (19:57 +1000)]
dsdb: Improve DRS deleted link source/target handing in repl_meta_data
We now correctly ignore the link updates if the source or target is
deleted locally.
This fixes the long-standing failure in the vampire_dc dbcheck test.
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
0162be32ab4f9716a4300d1f1a0caae8b0133f7c)
Andrew Bartlett [Mon, 17 Jun 2013 12:37:20 +0000 (22:37 +1000)]
dsdb: Ensure we always force deleted objects back under the deleted objects DN
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
32955a1dec3a97ab4550869dbeb5034247f3b1bc)
The last 12 patches address bug #10056 - dsdb improvements from 4.1.
Stefan Metzmacher [Wed, 5 Jun 2013 07:35:42 +0000 (09:35 +0200)]
dsdb/repl_meta_data: split out replmd_deletion_state()
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
(cherry picked from commit
a796cad90f1028ccc54a3539e34dc0728b990a96)
Andrew Bartlett [Fri, 31 May 2013 10:01:17 +0000 (20:01 +1000)]
dsdb: Prune deleted objects of links and extra attributes of replicated deletes
When an object is deleted, the links to be removed are not propogated,
you have to watch out for them manually!
We do this by calling back into the originating update delete code (ie
what is called if you ldb_delete() locally) so that any extra
attribute found locally and not on the remote server becomes removed
remotely too.
We currently do the same with links, but that isn't strictly correct,
but for now our getNCChanges server code filters these out, so only
the usn is bumped.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
d3aad891c5759f66bd891cb47866d908a0562a8a)
Andrew Bartlett [Mon, 17 Jun 2013 12:37:54 +0000 (22:37 +1000)]
torture/drs: Expand an error message to aid debugging
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jul 25 13:51:44 CEST 2013 on sn-devel-104
(cherry picked from commit
a74c7d780cb6a1e8a5a63ebbbcf36fd7cf717ea1)
Stefan Metzmacher [Mon, 10 Jun 2013 12:00:01 +0000 (14:00 +0200)]
dsdb/samdb: use RECYCLED it implies DELETED...
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
63c05e820f1449b2dfa6e4f096d8270284a60bbb)
Andrew Bartlett [Sat, 13 Jul 2013 09:34:45 +0000 (19:34 +1000)]
selftest: ensure samba4.rpc.samr.large-dc.two.samr.many is always tested
This test should now be more reliable with the over-allocation of
RID values now fixed.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
93b83151c9563f4c1f47b925fed079d275f8ec43)
Andrew Bartlett [Thu, 27 Jun 2013 23:19:48 +0000 (09:19 +1000)]
rpc_server-drsuapi: Improve comments and DEBUG lines
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
5e1f2795f28b0a213b4529e046edec68caa3bd41)
Andrew Bartlett [Thu, 27 Jun 2013 23:15:16 +0000 (09:15 +1000)]
dsdb: Add assert in drepl_take_FSMO_role
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
e9faf50ee123a8d1d647ebffa39107ca0dce756c)
Andrew Bartlett [Wed, 19 Jun 2013 01:33:36 +0000 (11:33 +1000)]
selftest: Ensure the DC has started and and got a RID set before we proceed
This avoids errors when a busy DC has not yet fetched a RID set, showing up
as flapping tests when users are created, such as the samr.large-dc test.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
ae0ba6bd833f71c4337ae3b6621bf797cb3c48c2)
Andrew Bartlett [Wed, 19 Jun 2013 00:30:48 +0000 (10:30 +1000)]
dsdb-ridalloc: Rework ridalloc to return error strings where RID allocation fails
We now also only poke the RID manager once per request.
This may help track down why RID allocation can fail, as while we
never wait for the RID set to be created/updated, it may be the only
clue the admin gets as to why the async allocations were failing.
Andrew Bartlett
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
db9c3c62c89e1328872e3fdedde22b78770728a9)
Andrew Bartlett [Sun, 23 Jun 2013 11:38:40 +0000 (21:38 +1000)]
dsdb: Rework subtree_rename module to use recursive LDB_SCOPE_ONELEVEL searches
This should be more efficient, particularly in the leaf node case when renaming and
deleting entries on large databases.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
31fb7f9c1b93b0f2114dec5096e43616ed317720)
Andrew Bartlett [Sun, 23 Jun 2013 09:47:35 +0000 (19:47 +1000)]
dsdb-descriptor: Do not do a subtree search unless we have child entries
This avoids a subtree search here in most cases where an object is deleted.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit
03b44d26fd17761675fe33ab29e8f325f59d8a5c)
Jeremy Allison [Thu, 11 Jul 2013 16:36:01 +0000 (09:36 -0700)]
Fix bug #10010 - Missing integer wrap protection in EA list reading can cause server to loop with DOS.
Fix client-side parsing also. Found by David Disseldorp <ddiss@suse.de>
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Aug 5 14:39:04 CEST 2013 on sn-devel-104
(cherry picked from commit
c4cba824d9e4bb31e1b6a901e994ffdfd3ad522e)
Jeremy Allison [Thu, 11 Jul 2013 00:10:17 +0000 (17:10 -0700)]
Fix bug #10010 - Missing integer wrap protection in EA list reading can cause server to loop with DOS.
Ensure we never wrap whilst adding client provided input.
Signed-off-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
c8d8bb257ac390c89c4238ed86dfef02750b6049)
Stefan Metzmacher [Tue, 23 Jul 2013 22:19:26 +0000 (10:19 +1200)]
s4-lib/socket: Allocate a the larger sockaddr_un and not just a sockaddr_in in unixdom_get_my_addr()
This caused crashes in _tsocket_address_bsd_from_sockaddr() when we
read past the end of the allocation.
(similar to commit
e9ae36e9683372b86f1efbd29904722a33fea083)
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10042
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Jul 24 14:37:43 CEST 2013 on sn-devel-104
(cherry picked from commit
077dfd0a89a854c21b91b0f871d034fd9fe82a9a)
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Mon Jul 29 23:44:45 CEST 2013 on sn-devel-104
Andrew Bartlett [Tue, 23 Jul 2013 22:19:26 +0000 (10:19 +1200)]
s4-lib/socket: Allocate a the larger sockaddr_un and not just a sockaddr_in in unixdom_get_peer_addr()
This caused crashes in _tsocket_address_bsd_from_sockaddr() when we
read past the end of the allocation.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
e9ae36e9683372b86f1efbd29904722a33fea083)
Andreas Schneider [Wed, 24 Jul 2013 08:12:19 +0000 (10:12 +0200)]
docs-xml: Remove obsolete swat manpage and references.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10041
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Wed Jul 24 12:42:29 CEST 2013 on sn-devel-104
(cherry picked from commit
a7801db32afb25cc88f171d9b8896b2f663ba351)
Signed-off-by: Andreas Schneider <asn@samba.org>
Günther Deschner [Thu, 18 Jul 2013 17:09:14 +0000 (19:09 +0200)]
pam_winbind: update documentation for "DIR" krb5ccname pragma.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 24 02:43:10 CEST 2013 on sn-devel-104
(cherry picked from commit
9adfe82a1785aa6a7baefb435072a0a81dfb13cb)
The last 3 patches address bug #10043 - Allow to change the default location for
Kerberos credential caches.
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Wed Jul 24 22:37:49 CEST 2013 on sn-devel-104
Günther Deschner [Thu, 18 Jul 2013 17:05:51 +0000 (19:05 +0200)]
s3-winbindd: support the DIR pragma for raw kerberos user pam authentication.
It is currently only available in MIT. In addition, allow to define custom
filepaths for FILE, WRFILE and DIR pragmas and substitute one occurence of the
%u pattern.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
7ad3a367d52b1f123c318946d654e95639202130)
Günther Deschner [Thu, 18 Jul 2013 17:04:29 +0000 (19:04 +0200)]
wbinfo: allow to define a custom krb5ccname for kerberized pam auth.
Guenther
Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
73e6feff9b3f30e70d84fe256aff239fafdfdb95)
Andreas Schneider [Fri, 19 Jul 2013 14:08:39 +0000 (16:08 +0200)]
s3-waf: Rename regedit to samba-regedit.
This is needed cause wine already provides a binary with the name
regedit.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10040
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Kai Blin <kai@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jul 22 14:12:38 CEST 2013 on sn-devel-104
(cherry picked from commit
b5051111d2fd3a9ae3b3aa028ccf013a98c20b38)
Stefan Metzmacher [Thu, 4 Jul 2013 16:11:02 +0000 (18:11 +0200)]
lib/param: sync debug related options with source3/param
The most important change is "debug hires timestamp = Yes"
and "syslog = 1".
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Tue Jul 9 17:15:15 CEST 2013 on sn-devel-104
(cherry picked from commit
cd36a3e902813c065e14059d325f7628b06595aa)
The last 4 patches fix bug #10015 - Fix/Improve debug options.
Stefan Metzmacher [Tue, 9 Jul 2013 11:56:35 +0000 (13:56 +0200)]
lib/ldb-samba: only debug LDB_DEBUG_TRACE at level 10
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
(cherry picked from commit
5f93822ede7ec3dc79a8057174342b2c6bb94a3b)
Stefan Metzmacher [Tue, 9 Jul 2013 11:56:08 +0000 (13:56 +0200)]
lib/ldb-samba: make use of DBGC_LDB
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
(cherry picked from commit
8e0752f4d6feea35304377222d3dd487355e4120)
Stefan Metzmacher [Tue, 9 Jul 2013 11:55:44 +0000 (13:55 +0200)]
lib/util: add 'ldb' debug class
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Björn Jacke <bj@sernet.de>
(cherry picked from commit
baecc863de0ceb64187c6eb3545bf28706bd84fc)
Andreas Schneider [Thu, 11 Jul 2013 11:44:53 +0000 (13:44 +0200)]
s3-winbind: Do not delete an existing valid credential cache.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=9994
Thanks to David Woodhouse <dwmw2@infradead.org>.
Reviewed-by: Günther Deschner <gd@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Jul 15 12:48:46 CEST 2013 on sn-devel-104
(cherry picked from commit
0529b59fbe3f96509893fc4e93a75d6928b5a532)
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Thu Jul 18 21:56:40 CEST 2013 on sn-devel-104
Volker Lendecke [Thu, 11 Jul 2013 14:22:26 +0000 (16:22 +0200)]
smbd: Fix a 100% loop at shutdown time
In the destructor of fsp->aio_requests[0] we put another request into
fsp->aio_requests[0]. Don't overwrite that with TALLOC_FREE.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Jul 11 20:56:42 CEST 2013 on sn-devel-104
(cherry picked from commit
940395d38bcc348eb5f1be7ba03cd554d9d3bc93)
Fix bug #10013 -
940395d from master needs porting to 4.0 and 4.1.
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Mon Jul 15 23:04:19 CEST 2013 on sn-devel-104
Björn Baumbach [Tue, 9 Jul 2013 10:32:34 +0000 (12:32 +0200)]
s3-smbstatus: display [u|g]id of -1 as "-1" in connection list
In order to avoid displayed uid or gid of "
4294967295" instead of "-1", we
need to fetch the special case -1.
The id can be -1 if we are reading e.g. incomplete session information.
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 10 01:18:30 CEST 2013 on sn-devel-104
(cherry picked from commit
577cef82c776759c9f3cad7d33057ac865c40769)
The last 3 patches address bug #10003 - s3-lib:segmentation fault while
reading incomplete session info.
Stefan Metzmacher [Mon, 8 Jul 2013 14:31:13 +0000 (16:31 +0200)]
s3-lib: hide incomplete smbXsrv_tcon_global records
Part of fix for bug #10003
Pair-programmed-with: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
c52e61f7ba215da28cbb7b8e328aea110ad79b11)
Björn Baumbach [Fri, 5 Jul 2013 11:19:59 +0000 (13:19 +0200)]
s3-lib: fix segf while reading incomplete session info (bug #10003)
Pair-programmed-with: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
53aa069b97070c73b782e2868b9b9686abe353cc)
Karolin Seeger [Thu, 11 Jul 2013 08:20:15 +0000 (10:20 +0200)]
VERSION: Bump version number up to 4.1.0rc2...
and re-enable git snapshots.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Thu, 11 Jul 2013 08:19:14 +0000 (10:19 +0200)]
VERSION: Disable git snapshots for the 4.1.0rc1 release.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Thu, 11 Jul 2013 08:17:30 +0000 (10:17 +0200)]
WHATSNEW: Some updates.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Fri, 5 Jul 2013 08:04:37 +0000 (10:04 +0200)]
WHATSNEW: Start release notes for Samba 4.1.0rc1.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
(cherry picked from commit
0025e9782d6a2d9df56556871566a3354996a999)
Karolin Seeger [Fri, 5 Jul 2013 08:05:19 +0000 (10:05 +0200)]
VERSION: Set version to 4.1.0rc1-GITSNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Fri Jul 5 11:56:40 CEST 2013 on sn-devel-104
(cherry picked from commit
e56343f1bba603852afcb816f7b5ebdf680c182e)
Stefan Metzmacher [Fri, 5 Jul 2013 10:07:53 +0000 (12:07 +0200)]
Merge remote-tracking branch 'origin/v4-1-test' into master
git merge -s ours origin/v4-1-test
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Karolin Seeger [Fri, 5 Jul 2013 08:05:19 +0000 (10:05 +0200)]
VERSION: Set version to 4.1.0rc1-GITSNAPSHOT.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Fri Jul 5 11:56:40 CEST 2013 on sn-devel-104
Volker Lendecke [Thu, 4 Jul 2013 09:24:33 +0000 (09:24 +0000)]
tevent: Fix a typo
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Karolin Seeger <kseeger@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Fri Jul 5 11:10:07 CEST 2013 on sn-devel-104
Karolin Seeger [Fri, 5 Jul 2013 08:04:37 +0000 (10:04 +0200)]
WHATSNEW: Start release notes for Samba 4.1.0rc1.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Karolin Seeger [Thu, 4 Jul 2013 08:36:33 +0000 (10:36 +0200)]
docs: Fix typos in "use ntdb" section.
Signed-off-by: Karolin Seeger <kseeger@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Jul 4 22:44:54 CEST 2013 on sn-devel-104
Andrew Bartlett [Sat, 22 Jun 2013 09:30:50 +0000 (19:30 +1000)]
dsdb-ridalloc: Fix RID pools - RID numbers increase too quickly
A patch by Cove Schneider <cove_s@yahoo.com> who reports:
I noticed that the RID numbers seem to increase incrementally, then
will suddenly jump by 124501. Unless I'm misunderstanding, shouldn't
RID pool allocations just be 500 at a time?
e.g. Adding accounts one after another on a single test instance here's how they're incrementing (from 4.0.6):
1596
1597
1598
1599
126100
126101
126102
...
126599
251100
...
251599
376100
...
The problem is that this complicates using sssd's AD integration, as
that it doesn't expect the RIDs to increase in a single domain so
quickly.
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Thu Jul 4 20:13:05 CEST 2013 on sn-devel-104
Matthieu Patou [Sun, 30 Jun 2013 08:59:53 +0000 (01:59 -0700)]
Make the output of the crackname script more readable
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 3 23:17:57 CEST 2013 on sn-devel-104
(cherry picked from commit
2536ee8b640c1257dbe28a977ae0b48a62093d0c)
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Thu Jul 4 11:47:53 CEST 2013 on sn-devel-104
Andreas Schneider [Mon, 1 Jul 2013 11:02:48 +0000 (13:02 +0200)]
s3-winbind: Allow sec_initial_uid() to store creds.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 2 23:26:24 CEST 2013 on sn-devel-104
(cherry picked from commit
caf3af33deeea9bee61a741fcc991285006cc6f5)
Andreas Schneider [Mon, 1 Jul 2013 11:02:47 +0000 (13:02 +0200)]
selftest: Use higher ip numbers.
127.0.0.2 is used by some distributions to resolve the own hostname.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
a4af4fa9db768dce2e009ba132cf88525a9b8314)
Andreas Schneider [Mon, 1 Jul 2013 11:02:46 +0000 (13:02 +0200)]
selftest: Add a newline to root entries in the nss files.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
d5511b125ccfd9c46cad63796aa49258bcc0ae38)
Andreas Schneider [Mon, 1 Jul 2013 11:02:45 +0000 (13:02 +0200)]
selftest: Fix domain name of plugindc.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
7392985b2981cb82be5f99255faae1605972be53)
Andreas Schneider [Mon, 1 Jul 2013 11:02:44 +0000 (13:02 +0200)]
torture: Don't segfault in smb2.session on error.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
bf5bc723da0605c7bc796f5e047e3f041db0b943)
Andreas Schneider [Mon, 1 Jul 2013 11:02:43 +0000 (13:02 +0200)]
torture: Don't segfault in raw.session on error.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit
d295e18409a2e18e52c5bb76fec0e0540b6199cf)
Andreas Schneider [Tue, 2 Jul 2013 13:24:40 +0000 (15:24 +0200)]
torture: Fix comparsion of uninitalized bytes.
As we compare string make sure we have the null terminator.
Found by valgrind.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
(cherry picked from commit
474eee0df7893a3a4546e1c6ea47220700c5b99f)
Matthieu Patou [Sun, 30 Jun 2013 08:59:53 +0000 (01:59 -0700)]
Make the output of the crackname script more readable
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Jul 3 23:17:57 CEST 2013 on sn-devel-104
Andreas Schneider [Mon, 1 Jul 2013 11:02:48 +0000 (13:02 +0200)]
s3-winbind: Allow sec_initial_uid() to store creds.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Jul 2 23:26:24 CEST 2013 on sn-devel-104
Andreas Schneider [Mon, 1 Jul 2013 11:02:47 +0000 (13:02 +0200)]
selftest: Use higher ip numbers.
127.0.0.2 is used by some distributions to resolve the own hostname.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Andreas Schneider [Mon, 1 Jul 2013 11:02:46 +0000 (13:02 +0200)]
selftest: Add a newline to root entries in the nss files.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Andreas Schneider [Mon, 1 Jul 2013 11:02:45 +0000 (13:02 +0200)]
selftest: Fix domain name of plugindc.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Andreas Schneider [Mon, 1 Jul 2013 11:02:44 +0000 (13:02 +0200)]
torture: Don't segfault in smb2.session on error.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Andreas Schneider [Mon, 1 Jul 2013 11:02:43 +0000 (13:02 +0200)]
torture: Don't segfault in raw.session on error.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Andreas Schneider [Tue, 2 Jul 2013 13:24:40 +0000 (15:24 +0200)]
torture: Fix comparsion of uninitalized bytes.
As we compare string make sure we have the null terminator.
Found by valgrind.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Andreas Schneider [Mon, 1 Jul 2013 15:05:33 +0000 (17:05 +0200)]
tsocket: Pass the full port number to getaddrinfo().
The code stripped port numbers above 9999 down to 4 digits.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jul 1 21:10:53 CEST 2013 on sn-devel-104
Autobuild-User(v4-1-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-1-test): Tue Jul 2 13:07:35 CEST 2013 on sn-devel-104
Andreas Schneider [Mon, 1 Jul 2013 15:05:33 +0000 (17:05 +0200)]
tsocket: Pass the full port number to getaddrinfo().
The code stripped port numbers above 9999 down to 4 digits.
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Jul 1 21:10:53 CEST 2013 on sn-devel-104
Matthieu Patou [Mon, 1 Jul 2013 03:40:07 +0000 (20:40 -0700)]
smbtorture: Make cracksname easier to debug by outputing the offered format
Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Signed-off-by: Matthieu Patou <mat@matws.net>
Autobuild-User(master): Matthieu Patou <mat@samba.org>
Autobuild-Date(master): Mon Jul 1 11:22:57 CEST 2013 on sn-devel-104
Matthieu Patou [Fri, 28 Jun 2013 00:59:39 +0000 (17:59 -0700)]
Fix a missing parenthesis in the LDAP search request
Signed-off-by: Matthieu Patou <mat@matws.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sun Jun 30 13:34:13 CEST 2013 on sn-devel-104
Aurélien Aptel [Fri, 28 Jun 2013 15:34:26 +0000 (17:34 +0200)]
docs-xml/manpages/smbclient.1.xml: fix case of -T flag in example.
Signed-off-by: Aurélien Aptel <aurelien.aptel@gmail.com>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Fri Jun 28 17:45:31 CEST 2013 on sn-devel-104
Jeremy Allison [Tue, 18 Jun 2013 00:25:41 +0000 (17:25 -0700)]
winbindd and nmbd don't set their umask to zero on startup like smbd does.
Fix this - we already control tightly what permissions are
on the files we create. Ensure we don't get surprised.
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Thu Jun 27 02:02:24 CEST 2013 on sn-devel-104
Volker Lendecke [Wed, 26 Jun 2013 15:35:37 +0000 (15:35 +0000)]
sharesec: Document --view-all
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Jun 26 18:43:45 CEST 2013 on sn-devel-104
Volker Lendecke [Wed, 26 Jun 2013 15:34:37 +0000 (15:34 +0000)]
sharesec: Document -v/--view
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Wed, 26 Jun 2013 13:21:39 +0000 (15:21 +0200)]
sharesec: Implement --view-all
Listing individual shares can be quite slow when you have a lot of shares. This
implements a --view-all option that prints something like
[share1]
REVISION:1
OWNER:(NULL SID)
GROUP:(NULL SID)
ACL:S-1-1-0:ALLOWED/0/FULL
[share2]
REVISION:1
OWNER:(NULL SID)
GROUP:(NULL SID)
ACL:S-1-1-0:ALLOWED/0/FULL
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Christian Ambach [Thu, 13 Jun 2013 13:23:07 +0000 (15:23 +0200)]
s3:smbd/close remove filesystem lock before removing sharemode
otherwise we are open for a race condition:
opener 1 opens file and closes it
- during the close, the share mode entry will be removed from
locking.tdb, but share mode in the file system will be dropped later
after delete_on_close and write time updates have been done
opener 2 requests open of same file with file overwrite
- locking.tdb does not list original entry, but file system share mode
is still around
- VFS_FTRUNCATE will fail and error was converted to STATUS_ACCESS_DENIED
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Christian Ambach <ambi@samba.org>
Autobuild-Date(master): Tue Jun 25 14:48:44 CEST 2013 on sn-devel-104
Christian Ambach [Fri, 21 Jun 2013 13:11:55 +0000 (15:11 +0200)]
s3:smbd/close use common exit path
do not return early here, but use the common exit path that will
remove the share mode from the record
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Christian Ambach [Tue, 11 Jun 2013 16:20:20 +0000 (18:20 +0200)]
s3:lib add mapping for ETXTBSY
add ETXTBSY to the errno->STATUS conversion table.
It will be mapped to STATUS_SHARING_VIOLATION
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Daniel Gan-Levi [Mon, 17 Jun 2013 16:39:09 +0000 (19:39 +0300)]
s3-ctdb: Fix auto-enabling of CTDB readonly support
This fixes Bug 9957
Bug: https://bugzilla.samba.org/show_bug.cgi?id=9957
Signed-off-by: Daniel Gan-Levi <danielg@il.ibm.com>
Reviewed-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Christian Ambach [Thu, 20 Jun 2013 16:27:39 +0000 (18:27 +0200)]
s3:smbd/aio mark file as modified in the SMB2 case
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Christian Ambach [Fri, 21 Jun 2013 11:26:18 +0000 (13:26 +0200)]
nsswitch: fix a comment
the beginning if is only ifdef LINUX now, not the long list this comment refers to
Signed-off-by: Christian Ambach <ambi@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Andrew Bartlett [Sun, 16 Jun 2013 04:02:57 +0000 (14:02 +1000)]
heimdal_build: Add missing dep on samba4kgetcred
This started to fail on current Debian Sid with system Heimdal after a binutils update.
Andrew Bartlett
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-By: Jelmer Vernooij <jelmer@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Jun 25 02:30:59 CEST 2013 on sn-devel-104
git.samba.org / martins / samba.git / log