s3:libads: change ads_add_service_principal_name implementation
authorNoel Power <noel.power@suse.com>
Fri, 16 Feb 2018 16:52:01 +0000 (16:52 +0000)
committerAndreas Schneider <asn@cryptomilk.org>
Fri, 2 Mar 2018 13:07:14 +0000 (14:07 +0100)
commit1400ab709e37e02f1d108f46779d49ba895ba8b1
treee547afb6ee06e82f22e69d6d8b440071c64f344b
parentcf0823fb9ee169efd6b268709c955db674e0cdbb
s3:libads: change ads_add_service_principal_name implementation

Previously the function 'ads_add_service_principal_name' created
the SPNs based on the machine_name and dns name passed to the function.
In order to prepare for a future patch that will also need to write
SPN(s) to the AD computer account, the function implementation will
need to be changed. Instead of the function creating the SPN(s) it
will now take the list SPN(s) to write to the AD 'machine_name' account
as an input param instead.
The name of the function has been changed to
'ads_add_service_principal_names' to reflect this. Additionally  client
code now needs to construct the SPNs to be passed into the function.

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source3/libads/ads_proto.h
source3/libads/kerberos_keytab.c
source3/libads/ldap.c