auth pycredentials: incorrect PyArg_ParseTupleAndKeywords call
authorGary Lockyer <gary@catalyst.net.nz>
Fri, 28 Apr 2017 01:14:16 +0000 (13:14 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 25 May 2017 00:25:13 +0000 (02:25 +0200)
commit610919e5e665dcb23241055e8ccb11f3d3f2ae2c
tree431cb81d96e1e973adeeb76e22415c1f20ffdd64
parentee0eb1daa349671386bae0121be6a4b8be06815d
auth pycredentials: incorrect PyArg_ParseTupleAndKeywords call

The challenge parameter was being treated as a string rather than as a
data blob.  This was causing intermittent seg faults. Removed the
server_timestamp parameter as it's not currently used.

Unable to produce a test case to reliably replicate the failure.
However auth_log_samlogon does flap

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
auth/credentials/pycredentials.c
selftest/flapping
selftest/knownfail