From: Noel Power <noel.power@suse.com>
Date: Tue, 21 May 2019 11:00:42 +0000 (+0000)
Subject: s3/lib/netapi: Fix 'Possible null pointer dereference' warning
X-Git-Url: http://git.samba.org/?p=metze%2Fsamba%2Fwip.git;a=commitdiff_plain;h=75afaeb749991925f17517ce50a96178d32d7922

s3/lib/netapi: Fix 'Possible null pointer dereference' warning

source3/lib/netapi/localgroup.c:1103: warning: nullPointer: Possible null pointer dereference: r <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
---

diff --git a/source3/lib/netapi/localgroup.c b/source3/lib/netapi/localgroup.c
index e0200a9ddd13..f3667987b1ae 100644
--- a/source3/lib/netapi/localgroup.c
+++ b/source3/lib/netapi/localgroup.c
@@ -1100,7 +1100,7 @@ static WERROR NetLocalGroupModifyMembers_r(struct libnetapi_ctx *ctx,
 		r = (struct NetLocalGroupAddMembers *)set;
 	}
 
-	if (!r->in.group_name) {
+	if (r==NULL || r->in.group_name == NULL) {
 		return WERR_INVALID_PARAMETER;
 	}