From: Michael Adam <obnox@samba.org>
Date: Tue, 4 Dec 2012 01:02:07 +0000 (+0100)
Subject: s3:smbd:vfs_acl: fix a PANIC when setting an ACL fails with ACCESS_DENIED
X-Git-Url: http://git.samba.org/?p=metze%2Fsamba%2Fwip.git;a=commitdiff_plain;h=7a0cf3b8edf2f77d77360dbca76c7200de10f393

s3:smbd:vfs_acl: fix a PANIC when setting an ACL fails with ACCESS_DENIED

Omission to free the talloc frame causes a panic (at least in developer mode)
in the next main event loop due to "Frame not freed in order."
(Freed frame ../source3/smbd/process.c:3617, expected ../source3/modules/vfs_acl_common.c:534.)

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
index 59ced2922f34..4e3aa72d3781 100644
--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -590,6 +590,7 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
 		if (get_current_uid(handle->conn) == 0 ||
 				chown_needed == false ||
 				!(fsp->access_mask & SEC_STD_WRITE_OWNER)) {
+			TALLOC_FREE(frame);
 			return NT_STATUS_ACCESS_DENIED;
 		}