metze/samba/wip.git
11 years agolibcli/auth/netlogon_creds_cli.c
Stefan Metzmacher [Thu, 18 Apr 2013 17:16:42 +0000 (19:16 +0200)]
libcli/auth/netlogon_creds_cli.c

11 years agounused cli_rpc_pipe_open_ntlmssp_auth_schannel
Stefan Metzmacher [Thu, 25 Apr 2013 17:33:28 +0000 (19:33 +0200)]
unused cli_rpc_pipe_open_ntlmssp_auth_schannel

11 years agoTODO check DEBUG libcli/auth: maintain the sequence number for the NETLOGON SSP as...
Stefan Metzmacher [Wed, 24 Apr 2013 10:33:28 +0000 (12:33 +0200)]
TODO check DEBUG libcli/auth: maintain the sequence number for the NETLOGON SSP as 64bit

11 years agos3:rpc_client: remove netr_LogonGetCapabilities check from rpc_pipe_bind*
Stefan Metzmacher [Thu, 25 Apr 2013 16:30:36 +0000 (18:30 +0200)]
s3:rpc_client: remove netr_LogonGetCapabilities check from rpc_pipe_bind*

It's done in the caller now.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:rpc_client: add netr_LogonGetCapabilities to cli_rpc_pipe_open_schannel_with_key()
Stefan Metzmacher [Thu, 25 Apr 2013 17:34:13 +0000 (19:34 +0200)]
s3:rpc_client: add netr_LogonGetCapabilities to cli_rpc_pipe_open_schannel_with_key()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:rpc_client: rpccli->dc can't be NULL in cli_rpc_pipe_open_schannel_with_key()
Stefan Metzmacher [Thu, 25 Apr 2013 17:45:52 +0000 (19:45 +0200)]
s3:rpc_client: rpccli->dc can't be NULL in cli_rpc_pipe_open_schannel_with_key()

It's just created above.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:rpc_client: rename same variables in cli_rpc_pipe_open_schannel_with_key()
Stefan Metzmacher [Thu, 25 Apr 2013 17:43:58 +0000 (19:43 +0200)]
s3:rpc_client: rename same variables in cli_rpc_pipe_open_schannel_with_key()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:rpc_client: use the correct context for netlogon_creds_copy() in rpccli_schannel_b...
Stefan Metzmacher [Thu, 25 Apr 2013 16:29:31 +0000 (18:29 +0200)]
s3:rpc_client: use the correct context for netlogon_creds_copy() in rpccli_schannel_bind_data()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:rpc_client: make rpccli_schannel_bind_data() static
Stefan Metzmacher [Thu, 25 Apr 2013 16:27:57 +0000 (18:27 +0200)]
s3:rpc_client: make rpccli_schannel_bind_data() static

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:rpc_client: fix/add AES downgrade detection to rpc_pipe_bind_step_two_done()
Stefan Metzmacher [Thu, 25 Apr 2013 17:57:09 +0000 (19:57 +0200)]
s3:rpc_client: fix/add AES downgrade detection to rpc_pipe_bind_step_two_done()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:netlogon: make use of netlogon_creds_decrypt_samlogon_logon()
Stefan Metzmacher [Wed, 24 Apr 2013 14:00:44 +0000 (16:00 +0200)]
s3:netlogon: make use of netlogon_creds_decrypt_samlogon_logon()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos4:netlogon: make use of netlogon_creds_decrypt_samlogon_logon()
Stefan Metzmacher [Wed, 24 Apr 2013 14:00:18 +0000 (16:00 +0200)]
s4:netlogon: make use of netlogon_creds_decrypt_samlogon_logon()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agolibcli/auth: add netlogon_creds_shallow_copy_logon()
Stefan Metzmacher [Wed, 24 Apr 2013 10:53:27 +0000 (12:53 +0200)]
libcli/auth: add netlogon_creds_shallow_copy_logon()

This can be used before netlogon_creds_encrypt_samlogon_logon()
in order to keep the provided buffers unchanged.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agolibcli/auth: add netlogon_creds_[de|en]crypt_samlogon_logon()
Stefan Metzmacher [Thu, 25 Apr 2013 15:01:00 +0000 (17:01 +0200)]
libcli/auth: add netlogon_creds_[de|en]crypt_samlogon_logon()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agolibcli/auth: make netlogon_creds_crypt_samlogon_validation more robust
Stefan Metzmacher [Wed, 24 Apr 2013 10:36:04 +0000 (12:36 +0200)]
libcli/auth: make netlogon_creds_crypt_samlogon_validation more robust

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:rpcclient: use talloc_stackframe() in do_cmd()
Stefan Metzmacher [Fri, 22 Mar 2013 14:07:10 +0000 (15:07 +0100)]
s3:rpcclient: use talloc_stackframe() in do_cmd()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoRevert "disable spnego"
Stefan Metzmacher [Mon, 8 Apr 2013 18:34:05 +0000 (20:34 +0200)]
Revert "disable spnego"

This reverts commit 692af548bdf38e97f0a5caeeff81b1df73fa2b7d.

11 years agodisable spnego
Stefan Metzmacher [Tue, 25 Aug 2009 12:06:39 +0000 (14:06 +0200)]
disable spnego

11 years agoRevert "regtree... sddl"
Stefan Metzmacher [Wed, 17 Apr 2013 12:45:50 +0000 (14:45 +0200)]
Revert "regtree... sddl"

This reverts commit e39b943330ffe4b1cac7a85d5afdc1d10535cda5.

11 years agoRevert "profiles..."
Stefan Metzmacher [Wed, 17 Apr 2013 12:25:49 +0000 (14:25 +0200)]
Revert "profiles..."

This reverts commit 68c5426a588e7b9e8f9d0e542b1d67ee228e41b3.

11 years agoprofiles...
Stefan Metzmacher [Wed, 6 Mar 2013 08:41:10 +0000 (09:41 +0100)]
profiles...

11 years agoregtree... sddl
Stefan Metzmacher [Wed, 6 Mar 2013 08:37:19 +0000 (09:37 +0100)]
regtree... sddl

11 years agoselftest: setup {NMBD,WINBINDD,SMBD}_VALGRIND
Stefan Metzmacher [Tue, 19 Mar 2013 14:44:02 +0000 (15:44 +0100)]
selftest: setup {NMBD,WINBINDD,SMBD}_VALGRIND

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoselftest/Samba3: export ENVNAME
Stefan Metzmacher [Tue, 19 Mar 2013 14:43:12 +0000 (15:43 +0100)]
selftest/Samba3: export ENVNAME

This is used by selftest/in_screen.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:utils/profiles: add --really-force option and warn about data corruption (bug...
Stefan Metzmacher [Wed, 17 Apr 2013 12:07:02 +0000 (14:07 +0200)]
s3:utils/profiles: add --really-force option and warn about data corruption (bug #9629)

While trying to fix the problem from bug #9629, I found that
the profiles tool completely corrupts the new NTUSER.dat file,
there're missing keys and values (regdiff show differences)
and the resulting file is much smaller than the original file.

Instead of trying to fix the security descriptors on registry level,
it's much easier and safer to just replace the binary SID values
within the NTUSER.dat file.

We keep the profiles binary, so that admins get pointed to
'samba-tool replace-binary-sids'.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agos3:utils/profiles: fix a compiler warning
Stefan Metzmacher [Wed, 6 Mar 2013 08:40:36 +0000 (09:40 +0100)]
s3:utils/profiles: fix a compiler warning

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agosamba-tool: add 'replace-binary-sid' command
Stefan Metzmacher [Wed, 17 Apr 2013 12:02:09 +0000 (14:02 +0200)]
samba-tool: add 'replace-binary-sid' command

This is a replacement for the broken 'profiles' utility.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agodoc-xml/smbdotconf: fix server [min|max] protocol documentation
Stefan Metzmacher [Tue, 30 Apr 2013 06:39:00 +0000 (08:39 +0200)]
doc-xml/smbdotconf: fix server [min|max] protocol documentation

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agolib/param: remove unused 'printer_admin'
Stefan Metzmacher [Mon, 29 Apr 2013 10:27:25 +0000 (12:27 +0200)]
lib/param: remove unused 'printer_admin'

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoregedit: Use color only when available.
Andreas Schneider [Fri, 26 Oct 2012 17:52:08 +0000 (19:52 +0200)]
regedit: Use color only when available.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Apr 29 15:02:19 CEST 2013 on sn-devel-104

11 years agoregedit: Improve the while loop.
Andreas Schneider [Fri, 26 Oct 2012 17:21:50 +0000 (19:21 +0200)]
regedit: Improve the while loop.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Remove talloc leak report.
Andreas Schneider [Fri, 26 Oct 2012 16:46:29 +0000 (18:46 +0200)]
regedit: Remove talloc leak report.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Mark string values if they contain unprintable chars.
C. Davis [Mon, 20 Aug 2012 03:09:53 +0000 (20:09 -0700)]
regedit: Mark string values if they contain unprintable chars.

Also, edit the values in bin mode to avoid screen glitches.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Add an edit binary command.
C. Davis [Mon, 20 Aug 2012 03:02:51 +0000 (20:02 -0700)]
regedit: Add an edit binary command.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Handle zero-length buffers better with hexedit.
C. Davis [Mon, 20 Aug 2012 02:11:16 +0000 (19:11 -0700)]
regedit: Handle zero-length buffers better with hexedit.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Load values on startup.
C. Davis [Mon, 20 Aug 2012 01:29:06 +0000 (18:29 -0700)]
regedit: Load values on startup.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Simplify the editor dialog input loop.
C. Davis [Sun, 19 Aug 2012 07:18:22 +0000 (00:18 -0700)]
regedit: Simplify the editor dialog input loop.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Fix white space and wrap long lines.
C. Davis [Sun, 19 Aug 2012 06:44:59 +0000 (23:44 -0700)]
regedit: Fix white space and wrap long lines.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Add missing copyright headers to hexedit code.
C. Davis [Sat, 18 Aug 2012 02:03:12 +0000 (19:03 -0700)]
regedit: Add missing copyright headers to hexedit code.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Enable using tab to cycle thru dialog buttons.
C. Davis [Fri, 17 Aug 2012 10:06:20 +0000 (03:06 -0700)]
regedit: Enable using tab to cycle thru dialog buttons.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Restore cursor position when user tabs to a field.
C. Davis [Fri, 17 Aug 2012 09:15:20 +0000 (02:15 -0700)]
regedit: Restore cursor position when user tabs to a field.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Add a general help section.
C. Davis [Thu, 16 Aug 2012 04:05:01 +0000 (21:05 -0700)]
regedit: Add a general help section.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Print help on left side of screen instead of the right.
C. Davis [Thu, 16 Aug 2012 03:50:00 +0000 (20:50 -0700)]
regedit: Print help on left side of screen instead of the right.

This is little bit easier to read to my eye.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Reduce magic numbers in edit dialog, clean up edit dialog creation.
C. Davis [Mon, 13 Aug 2012 05:39:21 +0000 (22:39 -0700)]
regedit: Reduce magic numbers in edit dialog, clean up edit dialog creation.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Add help msgs for key and value sections at bottom of screen.
C. Davis [Mon, 13 Aug 2012 05:38:06 +0000 (22:38 -0700)]
regedit: Add help msgs for key and value sections at bottom of screen.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Prefer copywin() over prefresh() for displaying path.
C. Davis [Sun, 12 Aug 2012 06:29:13 +0000 (23:29 -0700)]
regedit: Prefer copywin() over prefresh() for displaying path.

copywin() works better with panels, dialogs, etc.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Cut off the front of the path when screen width is too small.
C. Davis [Sun, 12 Aug 2012 06:22:06 +0000 (23:22 -0700)]
regedit: Cut off the front of the path when screen width is too small.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Uese a pad for path label.
C. Davis [Sun, 12 Aug 2012 05:10:51 +0000 (22:10 -0700)]
regedit: Uese a pad for path label.

This makes it easier scale the label on resize.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Improve padding for value summary.
C. Davis [Sat, 11 Aug 2012 22:00:55 +0000 (15:00 -0700)]
regedit: Improve padding for value summary.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Update dialog position on screen resize.
C. Davis [Sat, 11 Aug 2012 04:56:58 +0000 (21:56 -0700)]
regedit: Update dialog position on screen resize.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Handle term resizes.
C. Davis [Sat, 11 Aug 2012 03:05:20 +0000 (20:05 -0700)]
regedit: Handle term resizes.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Create subkeys.
C. Davis [Fri, 10 Aug 2012 20:16:20 +0000 (13:16 -0700)]
regedit: Create subkeys.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Delete and add keys.
C. Davis [Fri, 10 Aug 2012 01:14:42 +0000 (18:14 -0700)]
regedit: Delete and add keys.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Edit binary values with hexedit.
C. Davis [Thu, 9 Aug 2012 03:44:58 +0000 (20:44 -0700)]
regedit: Edit binary values with hexedit.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Initialize hexedit buf with data if available.
C. Davis [Thu, 9 Aug 2012 03:16:05 +0000 (20:16 -0700)]
regedit: Initialize hexedit buf with data if available.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit:hexedit: make sure cursor is updated on physical screen.
C. Davis [Thu, 9 Aug 2012 03:06:13 +0000 (20:06 -0700)]
regedit:hexedit: make sure cursor is updated on physical screen.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Add an input dialog.
C. Davis [Thu, 9 Aug 2012 00:49:06 +0000 (17:49 -0700)]
regedit: Add an input dialog.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Simplify notice dialogs, don't overwrite existing values.
C. Davis [Wed, 8 Aug 2012 22:36:01 +0000 (15:36 -0700)]
regedit: Simplify notice dialogs, don't overwrite existing values.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Don't pass empty value names to new_item().
C. Davis [Wed, 8 Aug 2012 21:37:20 +0000 (14:37 -0700)]
regedit: Don't pass empty value names to new_item().

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Really delete value.
C. Davis [Wed, 8 Aug 2012 21:16:41 +0000 (14:16 -0700)]
regedit: Really delete value.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Add new value type selection dialog.
C. Davis [Wed, 8 Aug 2012 19:09:03 +0000 (12:09 -0700)]
regedit: Add new value type selection dialog.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Save contents of value editor.
C. Davis [Wed, 8 Aug 2012 06:41:50 +0000 (23:41 -0700)]
regedit: Save contents of value editor.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Value editor changes.
C. Davis [Wed, 8 Aug 2012 02:19:28 +0000 (19:19 -0700)]
regedit: Value editor changes.

* Handle tab and back-tab for navigating among sections of the
  editor dialog.

* Read in REG_MULTI_SZ values into a multi-line form field.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Don't refresh treeview and value list.
C. Davis [Tue, 7 Aug 2012 02:18:56 +0000 (19:18 -0700)]
regedit: Don't refresh treeview and value list.

This is handled by update_panels() and doupdate() now.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Some work on dialogs.
C. Davis [Tue, 7 Aug 2012 02:11:13 +0000 (19:11 -0700)]
regedit: Some work on dialogs.

* Make dialogs modal with a separate getch() loop to avoid extra
  complexity keeping track of dialogs and getting the result.

* Start work on the value editor dialog.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Import hex editor.
C. Davis [Tue, 7 Aug 2012 02:06:15 +0000 (19:06 -0700)]
regedit: Import hex editor.

This was tested separately editing files. It needs to be
connected to regedit's value editor.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Link to ncurses form library
C. Davis [Mon, 6 Aug 2012 19:29:11 +0000 (12:29 -0700)]
regedit: Link to ncurses form library

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Don't panic if we can't open the file.
Andreas Schneider [Thu, 2 Aug 2012 10:41:49 +0000 (12:41 +0200)]
regedit: Don't panic if we can't open the file.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agowaf: Create a better wscript for finding ncurses.
Andreas Schneider [Thu, 2 Aug 2012 09:29:10 +0000 (11:29 +0200)]
waf: Create a better wscript for finding ncurses.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Improve calculation for centering dialogs.
C. Davis [Sat, 28 Jul 2012 01:39:54 +0000 (18:39 -0700)]
regedit: Improve calculation for centering dialogs.

Add some sanity checks to avoid crashing.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Introduce dialog windows.
C. Davis [Fri, 27 Jul 2012 10:37:22 +0000 (03:37 -0700)]
regedit: Introduce dialog windows.

Link to ncurses "panels" library to support popup dialog
windows, and begin working on a small dialog library.

Right now, it is useful for "yes/no" confirmation popups,
but later it'll be used for more complex forms for editing
values.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Take into account that getch() may return a '\n' instead of KEY_ENTER.
C. Davis [Thu, 26 Jul 2012 08:56:31 +0000 (01:56 -0700)]
regedit: Take into account that getch() may return a '\n' instead of KEY_ENTER.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Use tab key to switch between key and value sections.
C. Davis [Tue, 24 Jul 2012 11:12:56 +0000 (04:12 -0700)]
regedit: Use tab key to switch between key and value sections.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Don't overwrite the '/' when printing path.
C. Davis [Tue, 24 Jul 2012 10:10:45 +0000 (03:10 -0700)]
regedit: Don't overwrite the '/' when printing path.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Print value summary, fix heap corruption and path printing.
C. Davis [Fri, 20 Jul 2012 10:53:42 +0000 (03:53 -0700)]
regedit: Print value summary, fix heap corruption and path printing.

Added code to summarize value data. Also fixed a few bugs,
including some heap corruption found with valgrind.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: List values for the selected key.
C. Davis [Wed, 18 Jul 2012 09:31:41 +0000 (02:31 -0700)]
regedit: List values for the selected key.

Next step is to format a preview for the data and show that
next to the data type.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Print the registry path.
C. Davis [Sat, 14 Jul 2012 00:16:51 +0000 (17:16 -0700)]
regedit: Print the registry path.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Make all hives browsable.
C. Davis [Sat, 14 Jul 2012 00:07:44 +0000 (17:07 -0700)]
regedit: Make all hives browsable.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: load the configuration after processing the command line
Michael Adam [Fri, 13 Jul 2012 08:57:02 +0000 (10:57 +0200)]
regedit: load the configuration after processing the command line

this way the "-s" parameter can change the config file to be loaded...

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
11 years agoregedit: Setup a test tree view of HKLM.
C. Davis [Fri, 13 Jul 2012 04:11:55 +0000 (21:11 -0700)]
regedit: Setup a test tree view of HKLM.

Expand on the former test by allowing the user to walk HKLM
with the tree view. Subkeys are loaded dynamically in memory
as the user walks the hierarchy with tree_node_load_children().

One issue with this at the moment is detecting if the
in-memory copy of the hierarchy is out of date.

TODO: figure out when to reload out of date portions of the
hierarchy (probably by checking last_modified_time).

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Initial import of treeview code
C. Davis [Tue, 10 Jul 2012 13:23:33 +0000 (06:23 -0700)]
regedit: Initial import of treeview code

Reviewed-by: Andreas Schneider <asn@samba.org>
11 years agoregedit: First crack at linking to ncurses.
C. Davis [Tue, 10 Jul 2012 13:16:35 +0000 (06:16 -0700)]
regedit: First crack at linking to ncurses.

First attempt of editing build scripts to link to ncurses
libraries. It seems to work, though checks may need to be
expanded upon.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoregedit: Add regedit main source file
C. Davis [Fri, 6 Jul 2012 10:08:17 +0000 (03:08 -0700)]
regedit: Add regedit main source file

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoSupport s3 local access with the s4 libregistry framework
C. Davis [Fri, 6 Jul 2012 09:57:55 +0000 (02:57 -0700)]
Support s3 local access with the s4 libregistry framework

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agos3: Wrap calls to the s3 registry API.
C. Davis [Fri, 6 Jul 2012 09:42:53 +0000 (02:42 -0700)]
s3: Wrap calls to the s3 registry API.

To use Samba 4's libregistry in the registry editor, some
compatibility issues with Samba 3 need to be addressed.
"struct registry_key" is defined differently in source3 and
source4, and so this wrapper is used to isolate conflicting
types and avoid headaches compiling the code.

Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
11 years agoFix bug #9822 - Samba crashing during Win8 sync.
Jeremy Allison [Fri, 26 Apr 2013 17:47:41 +0000 (10:47 -0700)]
Fix bug #9822 - Samba crashing during Win8 sync.

When refactoring the dptr desctructor in the
fix for bug:

9778 (Samba directory code uses dirfd() without vectoring through a VFS call)

I removed the code to NULL out the struct smb_Dir *
pointer inside the fsp struct by mistake.

Re-add the NULLing out of that pointer when
closing a directory pointer associated with
an open file.

Reporter confirms it fixes the crash.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Sat Apr 27 20:44:55 CEST 2013 on sn-devel-104

11 years agotorture: Only test leases if supported
Volker Lendecke [Wed, 17 Apr 2013 11:41:54 +0000 (13:41 +0200)]
torture: Only test leases if supported

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Autobuild-User(master): Richard Sharpe <sharpe@samba.org>
Autobuild-Date(master): Sat Apr 27 18:09:37 CEST 2013 on sn-devel-104

11 years agotorture: Use ZERO_STRUCTPN instead of explicit deref
Volker Lendecke [Wed, 17 Apr 2013 10:34:14 +0000 (12:34 +0200)]
torture: Use ZERO_STRUCTPN instead of explicit deref

Signed-off-by: Volker Lendecke <vl@samba.org>
11 years agoCheck for WRITE_ACCESS on the file before overriding an EACCESS.
Jeremy Allison [Thu, 25 Apr 2013 21:06:03 +0000 (14:06 -0700)]
Check for WRITE_ACCESS on the file before overriding an EACCESS.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Sat Apr 27 15:57:17 CEST 2013 on sn-devel-104

11 years agoEnsure we don't try the open_file_fchmod() if we can't write to the file.
Jeremy Allison [Thu, 25 Apr 2013 21:02:24 +0000 (14:02 -0700)]
Ensure we don't try the open_file_fchmod() if we can't write to the file.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agoRemove indentation around code wrapped by unneeded CAN_WRITE.
Jeremy Allison [Thu, 25 Apr 2013 21:00:42 +0000 (14:00 -0700)]
Remove indentation around code wrapped by unneeded CAN_WRITE.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agoAdd early return in file_set_dosmode() on a read only share.
Jeremy Allison [Thu, 25 Apr 2013 20:59:22 +0000 (13:59 -0700)]
Add early return in file_set_dosmode() on a read only share.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
11 years agosmbd: Do not fetch the record in defer_open_done
Volker Lendecke [Fri, 26 Apr 2013 13:13:14 +0000 (15:13 +0200)]
smbd: Do not fetch the record in defer_open_done

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Apr 27 02:06:10 CEST 2013 on sn-devel-104

11 years agodbwrap: Allow dbwrap_record_watch_recv to not lock the record
Volker Lendecke [Fri, 26 Apr 2013 13:12:05 +0000 (15:12 +0200)]
dbwrap: Allow dbwrap_record_watch_recv to not lock the record

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: We don't use DEFERRED_OPEN_ENTRY anymore
Volker Lendecke [Fri, 26 Apr 2013 13:05:50 +0000 (15:05 +0200)]
smbd: We don't use DEFERRED_OPEN_ENTRY anymore

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Remove unused smb2_deferred_open_timer
Volker Lendecke [Fri, 26 Apr 2013 12:29:42 +0000 (14:29 +0200)]
smbd: Remove unused smb2_deferred_open_timer

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Obsolete MSG_SMB_OPEN_RETRY
Volker Lendecke [Fri, 12 Apr 2013 12:12:38 +0000 (14:12 +0200)]
smbd: Obsolete MSG_SMB_OPEN_RETRY

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Remove the unused fsp->pending_break_messages array
Volker Lendecke [Fri, 12 Apr 2013 12:09:12 +0000 (14:09 +0200)]
smbd: Remove the unused fsp->pending_break_messages array

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Remove unused reply_to_oplock_break_requests
Volker Lendecke [Fri, 12 Apr 2013 12:06:59 +0000 (14:06 +0200)]
smbd: Remove unused reply_to_oplock_break_requests

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
11 years agosmbd: Obsolete MSG_SMB_BREAK_RESPONSE
Volker Lendecke [Fri, 12 Apr 2013 12:03:08 +0000 (14:03 +0200)]
smbd: Obsolete MSG_SMB_BREAK_RESPONSE

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>