From 7a1e69ebb73a61bc76595df99fe023bdc91ff532 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 5 Apr 2018 10:12:41 +0200 Subject: [PATCH] eventlog: Fix CID 1363194 Resource leak Signed-off-by: Volker Lendecke Reviewed-by: Andreas Schneider Autobuild-User(master): Volker Lendecke Autobuild-Date(master): Thu Apr 5 19:11:57 CEST 2018 on sn-devel-144 --- source3/lib/eventlog/eventlog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/source3/lib/eventlog/eventlog.c b/source3/lib/eventlog/eventlog.c index cc4573c869ce..9053fdd9a245 100644 --- a/source3/lib/eventlog/eventlog.c +++ b/source3/lib/eventlog/eventlog.c @@ -958,7 +958,7 @@ NTSTATUS evlog_tdb_entry_to_evt_entry(TALLOC_CTX *mem_ctx, NT_STATUS_HAVE_NO_MEMORY(e->Computername); if (t->sid_length > 0) { - const char *sid_str = NULL; + char *sid_str = NULL; size_t len; if (!convert_string_talloc(mem_ctx, CH_UTF16, CH_UNIX, t->sid.data, t->sid.length, @@ -971,6 +971,7 @@ NTSTATUS evlog_tdb_entry_to_evt_entry(TALLOC_CTX *mem_ctx, return NT_STATUS_INVALID_SID; } } + TALLOC_FREE(sid_str); } e->Strings = talloc_array(mem_ctx, const char *, t->num_of_strings); -- 2.34.1