netcmd: models: Rename username to account_name for consistency
authorRob van der Linde <rob@catalyst.net.nz>
Tue, 27 Feb 2024 02:35:24 +0000 (15:35 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 1 Mar 2024 04:45:36 +0000 (04:45 +0000)
commit076bc6ee1da310d672a74a11b0a2a8ccf5311ac3
tree3ae9627c7db359e4c99a5db60d17d8f6f8d84444
parente70b87513986fbbeae03b73b571f84f0d44eafdc
netcmd: models: Rename username to account_name for consistency

When creating the User model initially, "username" was the only field that was inconsistently named, it maps to "sAMAccountName".

It should really have been account "account_name".

There is also a field "account_type" and should be similarly named to "account_name".

Basically the naming of fields should always be consistent, breaking the rule for one field only was a mistake.

Signed-off-by: Rob van der Linde <rob@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
python/samba/netcmd/domain/models/computer.py
python/samba/netcmd/domain/models/user.py
python/samba/netcmd/service_account/service_account.py
python/samba/tests/samba_tool/domain_models.py
python/samba/tests/samba_tool/service_account.py
python/samba/tests/samba_tool/user_auth_policy.py
python/samba/tests/samba_tool/user_auth_silo.py
python/samba/tests/samba_tool/user_get_kerberos_ticket.py
python/samba/tests/samba_tool/user_getpassword_gmsa.py