From: Amitay Isaacs Date: Thu, 6 Dec 2012 05:05:26 +0000 (+1100) Subject: s4-rpc: dnsserver: dns_name_equal() returns boolean X-Git-Url: http://git.samba.org/?p=obnox%2Fsamba%2Fsamba-obnox.git;a=commitdiff_plain;h=cc103a8187317047347a679e42b076de7d69d181 s4-rpc: dnsserver: dns_name_equal() returns boolean Remove the remaining check for return value after strcmp() was changed to dns_name_equal(). Signed-off-by: Amitay Isaacs Reviewed-by: Andrew Bartlett --- diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c index 87b7d87ae3b..fb2547ff7ec 100644 --- a/source4/rpc_server/dnsserver/dnsdata.c +++ b/source4/rpc_server/dnsserver/dnsdata.c @@ -958,8 +958,8 @@ bool dns_record_match(struct dnsp_DnssrvRpcRecord *rec1, struct dnsp_DnssrvRpcRe return dns_name_equal(rec1->data.cname, rec2->data.cname); case DNS_TYPE_SOA: - return dns_name_equal(rec1->data.soa.mname, rec2->data.soa.mname) == 0 && - dns_name_equal(rec1->data.soa.rname, rec2->data.soa.rname) == 0 && + return dns_name_equal(rec1->data.soa.mname, rec2->data.soa.mname) && + dns_name_equal(rec1->data.soa.rname, rec2->data.soa.rname) && rec1->data.soa.serial == rec2->data.soa.serial && rec1->data.soa.refresh == rec2->data.soa.refresh && rec1->data.soa.retry == rec2->data.soa.retry &&