From ec0f51b200d6e5b99bbd872e169621c17f33524c Mon Sep 17 00:00:00 2001 From: David Disseldorp Date: Wed, 2 Nov 2011 18:39:03 +0100 Subject: [PATCH] pam_winbind: fix segfault in pam_sm_authenticate() Ensure the potentially null winbind context is not dereferenced on cleanup. https://bugzilla.samba.org/show_bug.cgi?id=8564 Signed-off-by: Andreas Schneider Autobuild-User(master): Andreas Schneider Autobuild-Date(master): Fri Oct 26 22:40:57 CEST 2012 on sn-devel-104 --- nsswitch/pam_winbind.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/nsswitch/pam_winbind.c b/nsswitch/pam_winbind.c index 83d7bb67da9..29d6f7c7bc3 100644 --- a/nsswitch/pam_winbind.c +++ b/nsswitch/pam_winbind.c @@ -2736,9 +2736,10 @@ out: _pam_free_data_info3(pamh); } - _PAM_LOG_FUNCTION_LEAVE("pam_sm_authenticate", ctx, retval); - - TALLOC_FREE(ctx); + if (ctx != NULL) { + _PAM_LOG_FUNCTION_LEAVE("pam_sm_authenticate", ctx, retval); + TALLOC_FREE(ctx); + } return retval; } -- 2.34.1